Created attachment 67710 [details]
Test file

In the current master build for Mac OS X, two features involving the spacing of individual letters do not work anymore.

I will attach a test file which shows both problems,
and screenshots exposing the results.


Steps to reproduce (the same as used to create the test file):

I) Letter spacing
-----------------
1) Start LibreOffice.
2) New Writer document (with default styles).
3) Type “Hello world!”
4) Select the text.
5) From the menu bar, select “Format > Character...”.
   → “Character“ dialog appears.
6) Switch to tab “Position”.
7) Under “Spacing”, select “Expanded” from the popup menu
   and enter some value in the “by” field, e.g. (to get impressive results)
   “3pt”.
8) Click “OK”.
Expected result: “Hello world!” shows expanded letterspacing.
Actual result:    There is a very big space between “Hello” and “world!”,
   but the letter spacing is stil default (+/- 0).

II) Feature “expand single word” of justified text
--------------------------------------------------
 1) Start LibreOffice.
 2) New Writer document (with default styles).
 3) Type some lines of arbitrary text (no special formatting).
 4) Select that text.
 5) From the menu bar, select “Format > Paragraph...”.
    → “Paragraph“ dialog appears.
 6) Switch to tab “Indents and Spacing”.
 7) Under “Indent”, set “After text” to a big value, e.g. “12cm”,
    to simulate a very narrow column.
 8) Switch to tab “Alignment.”
 9) Select “Justified” alignment.
10) Check “Expand single word”.
11) Optional: automatic hyphenation should be off to show the problem
    more clearly, so, if you have activated it by default,
    please switch to tab “Text Flow” and uncheck Hyphenation:
    “Automatically”, if necessary.
12) Click “OK”.
13) Now click somewhere into your text and enter a very long word which
    is so long that no other word fits before or after it into the same
    line (this is easier to achieve if you also make the previous and
    next words rather long).
Expected result: The very long word shows expanded letterspacing,
    in order to fill a full line (this is what the feature
    “expand single word” means).
Actual result:   The long word is not expanded at all, but there is
    a big blank space *after* the word until the end of the line.


This is a REGRESSION introduced in the latest master builds --
* LOdev pull time 2012-09-20 05:53:26 was still OK,
* LOdev pull time 2012-09-24 23:40:55 shows the problem.
Tests done on Mac OS X 10.6.8 (Intel), LOdev with US English langpack installed.

I fear that this regression might be a side-effect of the fix for bug 55142 -- “Character position doesn't match caret position in justified text”, which was committed 2012-09-21:
  http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1651ee579bf38a49b839dbcb28ac38c0163a3d2

If this is true, we need either some fine-tuning for this fix (to fix the fix) or we should revert that fix, sorry.