Bug 57063 - FORMATTING/FILEOPEN: spacing "Above/Below paragraph" from old .ott template is lost in 3.5.0 and newer
Summary: FORMATTING/FILEOPEN: spacing "Above/Below paragraph" from old .ott template i...
Status: RESOLVED DUPLICATE of bug 58730
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: BSA
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-11-13 12:18 UTC by Jonas Bygdén
Modified: 2013-01-25 14:23 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
template before saving (67.76 KB, image/png)
2012-11-13 12:18 UTC, Jonas Bygdén
Details
new document based on template in other attachment (52.29 KB, image/png)
2012-11-13 12:19 UTC, Jonas Bygdén
Details
template (11.35 KB, application/vnd.oasis.opendocument.text-template)
2012-11-14 11:26 UTC, Jonas Bygdén
Details
3.3.4 template (10.59 KB, application/vnd.oasis.opendocument.text-template)
2012-11-28 13:11 UTC, Jonas Bygdén
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Bygdén 2012-11-13 12:18:11 UTC
Created attachment 69999 [details]
template before saving

Problem description: 

I've created a template that I've used for a couple of years and updated it with dates yearly.

Now I updated LibreOffice (from some older version, used spring -12, can't remember) to 3.6.3 and my template looses formatting.

The template now looks like it doesn't have the line spacing that I set up in the previous versions.

If I open the old template like any document it looks fine, I edit the date information and save it as a new template while everything looks fine.

When I then try to open a document based on that new template, the line spacing is messed up.

I've attached a screenshot of the template before saving.

The second attachment is a new document based on the template in the first screenshot.

Steps to reproduce:
1. ....
2. ....
3. ....

Current behavior:

Expected behavior:

Platform (if different from the browser): 
              
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.5 Safari/537.17
Comment 1 Jonas Bygdén 2012-11-13 12:19:12 UTC
Created attachment 70000 [details]
new document based on template in other attachment
Comment 2 m_a_riosv 2012-11-14 00:36:35 UTC
Please Jonas, can you attach a sample file?

Otherwise, will be difficult to see what is the issue.
Comment 3 Jonas Bygdén 2012-11-14 11:26:13 UTC
Created attachment 70063 [details]
template

Attached the template used to create the new document.
Comment 4 Jonas Bygdén 2012-11-19 20:07:22 UTC
A document with the wider line spacing saved with 3.6.3 will loose the wider spacing and go to a narrower spacing.

It's not just the template, any document looking like my first image ("template before saving") will lose its line spacing when saved in 3.6.3.

Very annoying.
Comment 5 Roman Eisele 2012-11-27 10:32:47 UTC
Thank you for your bug report and for the sample file!

REPRODUCIBLE first with LibreOffice 3.5.0rc3 (Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735). Tested on Mac OS X 10.6.8 (Intel).

However, what is lost is not the line spacing, but the spacing values for “Above Paragraph” and “Below Paragraph”. 

When I open the sample .ott file with LibreOffice 3.3.0 or 3.4.x, e.g. the headings “Heading 2, bold + italic” all have got some additional spacing “Above paragraph” = 0.42cm and “Below paragraph” = 0.21cm. The file looks like on the first screenshot (attachment 69999 [details]).

But when I open the sample .ott file with LibreOffice 3.5.0 or any newer version, including the current master builds, the same headings have “Above paragraph” = 0.00cm and “Below paragraph” = 0.00cm. Therefore, in all newer versions the file looks like on the second screenshot (attachment 70000 [details]).

The additional spacing “Above paragraph” and “Below paragraph” is part of the “Heading 2” style, so it definitely should not be lost.

This is a regression.

Interesting enough, the additional spacing is NOT lost in LibreOffice 3.5.0 and newer versions if I save the template as .odt (normal text) file in LibreOffice 3.4.0 -- the .odt file is opened by LibreOffice 3.5.0 and newer just like in 3.4.0 (all “Above paragraph” and “Below paragraph” spacing preserved).

If I did not make any errors, this means that the additional spacing is lost *only* in .ott files, not in .odt files.
Comment 6 Jonas Bygdén 2012-11-27 14:00:58 UTC
(In reply to comment #5)
> 
> However, what is lost is not the line spacing, but the spacing values for
> “Above Paragraph” and “Below Paragraph”. 
> 

Sorry, my comment about "line spacing" came from not understanding and knowing the correct name for the problem.

I'm no heavy user of any word processing software, so I haven't learned the "vocabulary" for different types of formatting.
Comment 7 Roman Eisele 2012-11-27 14:20:44 UTC
@ Jonas Bygdén:
(In reply to comment #6)
> Sorry, my comment about "line spacing" came from not understanding and
> knowing the correct name for the problem.
> 
> I'm no heavy user of any word processing software, so I haven't learned the
> "vocabulary" for different types of formatting.

No problem ;-) Your bug report was very helpful, even without the exact terminology. To find out what *exactly* goes wrong and how it is called is the everyday job of us bug wranglers (only that this is not a paid job, just voluntary ;-).

I will forward our bug report to the developers soon, I just have to do some testing on Windows before ...
Comment 8 Roman Eisele 2012-11-27 17:35:24 UTC
This bug is also REPRODUCIBLE with the same results in LibreOffice 3.5.7 on Windows XP. Therefore I set the Platform to All/All.
Comment 9 Roman Eisele 2012-11-27 17:41:17 UTC
@ Writer experts:

Hi Cédric, Michael, and Miklós,

this report is about an important regresssion in 3.5.0. While the settings for spacing “Above paragraph” and “Below paragraph” are imported correctly from .odt files, they are NOT imported correctly from a .ott (template) file -- at least not from the attached sample .ott file, which works correctly in all LibreOffice versions before 3.5.0. Especially the inconsistency between .odt and .ott is IMHO disturbing.

So, any chance one of you could take a look at this issue ...? ;-)

Thank you very much!
Comment 10 Roman Eisele 2012-11-27 17:51:53 UTC
Just a hint:

Interesting enough, AOO 3.4.0 (AOO340m1(Build:9590) - Rev. 1327774) from 2012-04-19 already suffers from the same problem -- it does *not* preserve the spacing above/below the paragraphs, too.

Does this mean that the commit which changed the behaviour could be some commit to AOO which was then copied into LibreOffice? If yes, this hint might be useful to find the faulty commit ... if not, please just ignore the ideas of a simple-minded bug wrangler (me) ;-)
Comment 11 Roman Eisele 2012-11-27 18:24:07 UTC
@ Jonas Bygdén:
Do you still have an old copy (maybe a backup, etc.) of your template file *before* it was updated with LibreOffice 3.5/3.6 (i.e., probably a copy from 2011/early 2012, or even older, if possible)? If yes, could you please attach
it here, too?

Examinating that old version of the .ott file and comparing it to the updated version *might* be helpful to find out what goes wrong here...
Comment 12 Jonas Bygdén 2012-11-28 11:33:59 UTC
(In reply to comment #11)
> @ Jonas Bygdén:
> Do you still have an old copy (maybe a backup, etc.) of your template file
> *before* it was updated with LibreOffice 3.5/3.6 (i.e., probably a copy from
> 2011/early 2012, or even older, if possible)? If yes, could you please attach
> it here, too?
> 
> Examinating that old version of the .ott file and comparing it to the
> updated version *might* be helpful to find out what goes wrong here...

I DO have an old copy, but that contains information that I don't want to share. And I can't edit it with 3.6.3, since it will invalidate the "old" status on it.

I'll see if I can install an older version and use that to edit out the information within that template that I don't want to share.
Comment 13 Roman Eisele 2012-11-28 12:37:32 UTC
(In reply to comment #12)
> I DO have an old copy, but that contains information that I don't want to
> share. And I can't edit it with 3.6.3, since it will invalidate the "old"
> status on it.

I don’t know how confidential the contents of the old copy are. If possible, you can simply send the file to me -- I promise to keep it confidential --, then I can anonymize the contents of the file (I have a collection of all old LibreOffice versions :-) and finally upload the anonymized version.

In case you want to do that yourself, you can find all old LibreOffice versions at
   http://downloadarchive.documentfoundation.org/libreoffice/old/
Comment 14 Jonas Bygdén 2012-11-28 13:11:13 UTC
Created attachment 70732 [details]
3.3.4 template

This template was created with 3.3.4

I created a new document in 3.3.4 based on the "faulty" template from earlier. This actually showed up without the problem, but with correct spacing above/below paragraph.

I just choose "File -> New -> Template..." and then "File -> Templates -> Save..." and this is what got created.
Comment 15 Roman Eisele 2012-11-29 08:36:50 UTC
Thank you for the file!

Interesting results:
* When I open your 3.3.4 template file (“bar.ott”) in LibO 3.6.4.1,
  the spacing “Above paragraph” and “Below paragraph” is correct.
* But when I open the template file,
  save it under a new name as Writer template (.ott file) again,
  close it,
  and then open the new .ott file again,
  all “Above paragraph” and “Below paragraph” spacing is lost.
* This time, the same happens when I open the template file,
  save it under a new name as normal Writer (.odt) file,
  close it,
  and then open the new .odt file again,
  all “Above paragraph” and “Below paragraph” spacing is lost.

So, something is wrong with the handling of these properties in (some?)
.ott files: while the “Above paragraph” and “Below paragraph” spacing is correct first, it gets lost after saving the files created from the .ott template.


@ dear Writer experts:
Can you please take a look at this issue?
Something is going seriously wrong here ...
Comment 16 Jonas Bygdén 2012-11-29 08:40:31 UTC
(In reply to comment #15)
> Thank you for the file!
> 
> Interesting results:
> * When I open your 3.3.4 template file (“bar.ott”) in LibO 3.6.4.1,
>   the spacing “Above paragraph” and “Below paragraph” is correct.
> * But when I open the template file,
>   save it under a new name as Writer template (.ott file) again,
>   close it,
>   and then open the new .ott file again,
>   all “Above paragraph” and “Below paragraph” spacing is lost.
> * This time, the same happens when I open the template file,
>   save it under a new name as normal Writer (.odt) file,
>   close it,
>   and then open the new .odt file again,
>   all “Above paragraph” and “Below paragraph” spacing is lost.
> 

This is exactly what I was seeing, and why I created this bug.
Comment 17 David 2012-12-17 01:49:35 UTC
I am having what looks like may be this same problem on Ubuntu 12-10 64bit. I put my comments under bug 58116 which may be a duplicate.
Comment 18 Michael Stahl (allotropia) 2013-01-25 14:23:44 UTC
ah yes that's the horrible fo:margin="100%" regression
inherited from OOo 3.4 beta, sorry about that...

*** This bug has been marked as a duplicate of bug 58730 ***