Bug 57414 - File Recovery: Don't save read-only and empty files for recovery
Summary: File Recovery: Don't save read-only and empty files for recovery
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.0.0.0.alpha0+ Master
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: AutoSave-AutoRecovery-Backup
  Show dependency treegraph
 
Reported: 2012-11-22 15:16 UTC by Stefan Knorr (astron)
Modified: 2017-09-18 04:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Knorr (astron) 2012-11-22 15:16:10 UTC
As documents that are opened read-only can not be modified anyway, we should turn off automatic saving for recovery for these documents.

Saving empty files for recovery is similarly useless and should be turned off too.
Comment 1 Joel Madero 2012-12-06 21:54:21 UTC
Does this help for recovery purposes? IE. is something saved in /tmp even if read only?
Comment 2 Joel Madero 2013-01-08 17:38:08 UTC
I'm going to assume that there is a reason for doing this. Especially for empty documents, that seems to make perfect sense. 

Marking as NEW and leaving it up to you guys (Developers) to decide how to implement :)

Marking as LOW as it's not going to add a lot for the end user, just a functional addition for "behind the scenes" stuff.
Comment 3 Stefan Knorr (astron) 2013-01-08 22:07:30 UTC
Sorry for my irresponsiveness.

First, a clarification: Read-only files can now (3.6+) be edited. Thus, among read-only files, the non-saving behaviour should only apply to unmodified read-only files (as received via email, etc.).

Rationale for this change:
When LibO crashes and users have accidentally or deliberately opened any of these types of documents, LibO will try to restore them – this is useless (obviously, since there is nothing to restore). It also adds to the many windows that restoration wizard tends to open, therefore can be confusing to users. Lastly, it is also rather disappointing when a file is restored and there is no content in it at all.


Marking medium (again?), because it does have user impact.
Comment 4 Kumāra 2013-03-10 09:32:24 UTC
I've sort of accepted (or tolerated with) this behaviour, but I must say that it makes LibO seem rather unpolished. In that sense too there is an impact. So, it would be a good idea to (carefully) resolve this.
Comment 5 Joel Madero 2013-05-29 21:28:19 UTC
Read only files cannot be edited - an example: just go to https://bugs.freedesktop.org/show_bug.cgi?id=37256, do not download but instead just directly open in LibreOffice version 4, this is technically a read only file now (as it hasn't been saved) but you cannot edit it. Multiple people complaining about this :-/

Just my two cents, as this is already NEW, moving on to more triaging :)
Comment 6 Kumāra 2017-09-18 04:22:01 UTC
(In reply to Stefan Knorr (astron) from comment #3)
> First, a clarification: Read-only files can now (3.6+) be edited. Thus,
> among read-only files, the non-saving behaviour should only apply to
> unmodified read-only files (as received via email, etc.).

Would it be better to say "Don't save doc recovery info for unmodified file"?