Bug 57422 - presenter console RTL support needs completion
Summary: presenter console RTL support needs completion
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.0.alpha0+ Master
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:4.1.0
Keywords:
Depends on: 42070
Blocks: Presenter-Console RTL-UI
  Show dependency treegraph
 
Reported: 2012-11-22 16:46 UTC by Lior Kaplan
Modified: 2023-12-11 21:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Test .odp. (323.98 KB, application/vnd.oasis.opendocument.presentation)
2018-09-17 17:16 UTC, Shlomi Fish
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lior Kaplan 2012-11-22 16:46:33 UTC
This is a follow up for bug 42070 which added RTL support for presenter console.

The missing parts are (taken from http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e5c11c664f67ff9fd1120905b09a32bea3b2f6c):
1. Help layout.
2. Slide sorter view (slides alignment).
3. Note view buttons.
4. Scroll bars.
Comment 1 Not Assigned 2012-12-12 10:54:35 UTC
Faisal M. Al-Otaibi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a77fa7ee84424a5844d836e83978ab0197716bef

fdo#57422 - presenter console RTL support needs completion



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 2 Not Assigned 2012-12-12 11:00:29 UTC
Faisal M. Al-Otaibi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cfa0588e04ee3d132081212ac38fda7c83c45024

fdo#57422 - presenter console RTL support needs completion



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Not Assigned 2013-01-10 13:08:59 UTC
Abdulelah Alarifi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb0d07d3f2937315700dabf72d366f5ef4d4200d

fdo#57422 - presenter console RTL support needs completion



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Not Assigned 2013-01-29 07:42:50 UTC
Ahmad Harthi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e252ac072276a6e9459a5573c862e8066b78c29d

More fixes to fdo#57422



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2013-03-11 09:39:40 UTC
Abdulaziz A Alayed committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b977c27383b36f511bcedc8cd48c160a1c0be514

fdo#57422 fixing scroll bar and slides position



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2013-03-11 10:21:06 UTC
Abdulaziz A Alayed committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=32e593dc2da4266567cf80ee6bea7917e56572c7

fdo#57422 fixing scroll bar and slides position



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2016-10-23 12:46:29 UTC
Hello,
Is this bug already fixed?
If so, could you please close it as RESOLVED FIXED?
Comment 8 Omer Zak 2017-11-02 18:06:15 UTC
How to reproduce the bug in a buggy version (in order to verify that it has been fixed)?
Comment 9 Shlomi Fish 2018-09-17 17:14:21 UTC
How do I invoke the presenter console? On kde plasma 5 on mageia 7 x64 "F5" displays the slides and "alt+f5" does nothing. I'll attach a sample doc.
Comment 10 Shlomi Fish 2018-09-17 17:16:24 UTC
Created attachment 144953 [details]
Test .odp.
Comment 11 QA Administrators 2022-01-09 03:41:46 UTC Comment hidden (obsolete)
Comment 12 Stéphane Guillou (stragu) 2023-12-10 08:51:55 UTC
Testing with:

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

(In reply to Lior Kaplan from comment #0)
> The missing parts are (taken from
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=5e5c11c664f67ff9fd1120905b09a32bea3b2f6c):
> 1. Help layout.
Help panel shows keybindings on right, effects on left -> OK
> 2. Slide sorter view (slides alignment).
Slides are laid out right to left -> OK
> 3. Note view buttons.
Not sure what is meant, but the icon matches the layout. Maybe it should all be changed to have the Note frame on the right, in order to have the Next Slide frame on the bottom left? But this is unclear to me and should be tracked in a new ticket if needed.
> 4. Scroll bars.
Seems commit b977c27383b36f511bcedc8cd48c160a1c0be514 was about that. But again, unsure what the issue is from the description.

Let's mark as "fixed" because of Faisal's related commits, and open new focused, reports if needed.