Created attachment 74484 [details]
Screenshot of bug
When applying a persona with a dark color, the menu items stays black.
When applying the same persona to firefox the menu items change to white/light gray.
I have just checked this on an Ubuntu 12.04 installation, and the bug is NOT present there, so it seems to be a problem specific to my RHEL installation.
Kendy, I'm assigning this to you.
I've the same problem on my computer (Windows Seven SP1, LibreOffice V4)
On Firefox, when I want to install my own persona, Firefox give me the possibility to choose the menu font color, and to choose white when my
persona is dark.
*** Bug 61206 has been marked as a duplicate of this bug. ***
I can confirm this.
Using win7 and 18.104.22.168, all dark hue personas are not usable, because menu titles will stay black and will not be seen anymore.
And a huge part of personas have a dark or darkish background.
It has been confirmed on Windows too (Windows 7 x64 SP 1 LibO 4.0)
I can confirm this bug as well with LO 22.214.171.124 on Windows XP (32-bit) and LO 126.96.36.199 on openSUSE 12.2 (openSUSE-version with KDE extension).
This is actually an easy hack; whoever wants to work on this has to update
static void setupPersonaHeaderFooter()
in vcl/source/app/settings.cxx to update MenuBarTextColor too. The color is available in aPersonaSettings as the next token after the footer bitmap.
So you want to add something like (pseudo code)
if ( nIndex > 0 )
aFooter = aPersonaSettings.getToken( 0, ';', nIndex );
+ if ( nIndex > 0 )
+ aColor = aPersonaSettings.getToken( 0, ';', nIndex );
+ maMenuBarTextColor = Color( aColor.toInt64( 16 ) );
The "Color( aColor.toInt64( 16 ) )" will probably need some tweaking to get right - the color is stored as "#RRGGBB", so you first want to strip the leading "#"; the rest should be fine by toInt64(), but check the Color() constructor in tools/inc/tools/color.hxx to be sure.
Please let me know should you have any more questions :-)
I wish to pick up this one but can't follow steps to reproduce it on my ubuntu 12.10 machine. May you please guide me with the same.
I've made a patch for this bug
Cao Cuong Ngo committed a patch related to this issue.
It has been pushed to "master":
fdo#60542 Persona setting: change color of the text menu.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Marking as fixed - thank you so much for the patch!
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp )