Download it now!
Bug 63216 - : Check for updates is on the help menu while most Mac apps put it on the App menu
Summary: : Check for updates is on the help menu while most Mac apps put it on the App...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.0.1.2 release
Hardware: Other Mac OS X (All)
: low trivial
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
: 111873 (view as bug list)
Depends on:
Blocks: MacOS-Wishlist
  Show dependency treegraph
 
Reported: 2013-04-06 22:05 UTC by Dwayne Bailey
Modified: 2019-12-21 14:46 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dwayne Bailey 2013-04-06 22:05:43 UTC
Problem description: 
The check for updates menu entry is in the help menu.  While on Mac this usually appears in the App menu.

Being in the help menu it is also unavailable if you have no application open i.e. you just have the shell open with no Help menu.


Steps to reproduce:
1. Open LibreOffice in shell
2. No Help menu can't check for new version
3. Open LibreOffice Write
4. Check in App menu - no Check for updates entry
5. Click on Help menu - Check for updates there

Current behavior:
Check for updates is in the Help menu

Expected behavior:
On Mac, Check for Update is available in the LibreOffice app menu.
              
Operating System: Mac OS X
Version: 4.0.1.2 release
Comment 1 Jorendc 2013-04-09 09:04:25 UTC
(In reply to comment #0)
> Problem description: 
> The check for updates menu entry is in the help menu.  While on Mac this
> usually appears in the App menu.

I agree with that
 
> Being in the help menu it is also unavailable if you have no application
> open i.e. you just have the shell open with no Help menu. 
> Steps to reproduce:
> 1. Open LibreOffice in shell
> 2. No Help menu can't check for new version

Mmmh, I can find the 'Check for updates' entry in menu Help in this step.

> 3. Open LibreOffice Write
> 4. Check in App menu - no Check for updates entry
> 5. Click on Help menu - Check for updates there

Because I agree with the fact most applications of Mac OSX can check for updates in the 'LibreOffice' menu entry, I mark this bug as NEW. Following [1] I mark this as 'trivial low'.

Kind regards,
Joren

[1] https://wiki.documentfoundation.org/images/0/06/Prioritizing_Bugs_Flowchart.jpg
Comment 2 Dwayne Bailey 2013-04-14 21:40:08 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Problem description: 
> > The check for updates menu entry is in the help menu.  While on Mac this
> > usually appears in the App menu.
> 
> I agree with that
>  
> > Being in the help menu it is also unavailable if you have no application
> > open i.e. you just have the shell open with no Help menu. 
> > Steps to reproduce:
> > 1. Open LibreOffice in shell
> > 2. No Help menu can't check for new version
> 
> Mmmh, I can find the 'Check for updates' entry in menu Help in this step.

A misinterpretation of 'shell' here.

1) Start LO write
2) Ctrl-W to close any open docs
3) LO is still open but only has LibreOffice and File menu.
4) No help menu, so can't check version info.
Comment 3 Don't use this account, use tml@iki.fi 2013-08-08 21:22:05 UTC
Actgually, I think that most Mac apps will soon be distributed through the Mac App Store. And the App Store has its own update mechanism, so apps don't need any own update mechanism, and are not allowed to have any. Just saying. Whether TDF will see the writing on the wall or not I don't know.
Comment 4 retired 2014-05-22 23:17:12 UTC
Just wanting to add another perspective:
1) as long as LO is not in the MAS, this is a very valid enhancement request
2) coda, the award winning famous OSX editor app from panic inc. just shut down coda being available on the MAS since with their new version apple's restrictions where to annoying so that they instead went back to the good old sparkle updates for their stand-alone only app as update mechanism

Don't get me wrong, if LO was on the MAS I'd instantly stop talking about integrating sparkle. But as long as we are not there yet, the debate should be open and there are several arguments pro and con MAS just as there are pro con sparkle update mechanism.
Comment 5 William Entriken 2014-07-15 18:22:19 UTC
There is additional discussion on the Sparkle project.  https://github.com/sparkle-project/Sparkle/issues/380 

Some Sparkle developers and hackers want to help make this happen.

Are there some experts here that can help explain build details for Mac?
Comment 6 Jorendc 2014-07-15 18:25:01 UTC
(In reply to comment #5)
> There is additional discussion on the Sparkle project. 
> https://github.com/sparkle-project/Sparkle/issues/380 
> 
> Some Sparkle developers and hackers want to help make this happen.
> 
> Are there some experts here that can help explain build details for Mac?

I think you might receive the necessary help by using the developer-mailinglist: http://lists.freedesktop.org/mailman/listinfo/libreoffice and/or using the IRC-chat: irc://chat.freenode.net/libreoffice-dev

How to build on Mac is documented over here: https://wiki.documentfoundation.org/Development/BuildingOnMac

Kind regards,
Joren
Comment 7 QA Administrators 2016-02-21 08:37:16 UTC Comment hidden (obsolete)
Comment 8 Yannick.D 2016-04-02 21:37:11 UTC
Still valid.

Version: 5.0.5.2
Build ID: 55b006a02d247b5f7215fc6ea0fde844b30035b3
Mac OS X 10.11.3
Comment 9 QA Administrators 2017-05-22 13:19:29 UTC Comment hidden (obsolete)
Comment 10 Sierk Bornemann 2017-05-22 15:21:05 UTC
(In reply to QA Administrators from comment #9)

> Test to see if the bug is still present on a currently supported version of
> LibreOffice 
> (5.2.7 or 5.3.3  https://www.libreoffice.org/download/
> 
> If the bug is present, please leave a comment that includes the version of
> LibreOffice and 
> your operating system, and any changes you see in the bug behavior


Still present in LibreOffice 5.3.3.2_de-DE, as well as in 5.4.0.0.beta1_de-DE on macOS Sierra 10.12.5.
Comment 11 Adolfo Jayme 2017-08-19 19:15:17 UTC
*** Bug 111873 has been marked as a duplicate of this bug. ***
Comment 12 QA Administrators 2018-08-20 02:32:38 UTC Comment hidden (obsolete)
Comment 13 Brendan Simon 2018-08-20 11:29:05 UTC
Is it a standard the "Check for updates" is in the App menu?

All the apps that I use have it in the Help menu (sometimes the About or Tools menu).

I use: Mozilla Firefox and Thunderbird, Adobe Acrobat Reader, LibreOffice, Microsoft Office, SourceTree, Eclipse, GnuCash.

I don't mind it being in the App Menu, and probably do prefer it there, but it doesn't seem to be a common practice (based on the Apps I use).
Comment 14 Brendan Simon 2018-08-20 11:30:37 UTC
"Bug" is still present.

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 8; OS: Mac OS X 10.13.6; UI render: default; 
Locale: en-AU (en_AU.UTF-8); Calc: group threaded
Comment 15 QA Administrators 2019-09-02 09:24:01 UTC Comment hidden (obsolete)
Comment 16 Julien Nabet 2019-12-18 08:22:28 UTC
Alex: as MacOs user, any thoughts here?
If you confirm, perhaps we may ping UI team?
Comment 17 Alex Thurgood 2019-12-18 21:32:12 UTC
Confirming

Other FOSS software already does this on macOS, e.g. VLC, Firefox, etc
Still valid IMO.
Comment 18 Julien Nabet 2019-12-21 14:46:28 UTC
Code pointer:
extensions/source/update/check/org/openoffice/Office/Addons.xcu

this file contains:
<node oor:name="OfficeHelp">
https://opengrok.libreoffice.org/xref/core/extensions/source/update/check/org/openoffice/Office/Addons.xcu?r=8dc38dd9#21

Taking a look at officecfg/registry/schema/org/openoffice/Office/Addons.xcs
I noticed these:
- https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Addons.xcs?r=c31fa068#514
for help menu
- https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Addons.xcs?r=c31fa068#479
for app menu?

I tried this patch:

diff --git a/extensions/Configuration_updchk.mk b/extensions/Configuration_updchk.mk
index 394a1ae6c76d..ad543ba584b6 100644
--- a/extensions/Configuration_updchk.mk
+++ b/extensions/Configuration_updchk.mk
@@ -24,8 +24,17 @@ $(eval $(call gb_Configuration_add_spool_modules,updchk,extensions/source/update
 # localized "Title" property values of
 # /org.openoffice.Office.Common/Menus/New/m0 (install:module="writer") end up in
 # registry_*.xcd instead of a, say, writer_*.xcd):
+ifeq ($(OS),MACOSX)
+
+$(eval $(call gb_Configuration_add_localized_datas,updchk,extensions/source/update/check,\
+       org/openoffice/Office/Addons_mac.xcu \
+))
+
+else
+
 $(eval $(call gb_Configuration_add_localized_datas,updchk,extensions/source/update/check,\
        org/openoffice/Office/Addons.xcu \
 ))
 
+endif

copy of extensions/source/update/check/org/openoffice/Office/Addons.xcu to 
extensions/source/update/check/org/openoffice/Office/Addons_mac.xcu
changing just "OfficeHelp" to "AddonMenu"
but got this:
warning: failed to load external entity "schemaRoot"
cannot parse schemaRoot

I found schemaRoot in LO sources but don't understand how it works.

Of course, I'm not sure too that using "AddonMenu" will add "Check for Updates" in App menu.

Stephan: since it concerns Macos and noticed some commits from you about schemaRoot, thought you may be interested and have some ideas?