Bug 63965 - CONFIGURATION: two identical functions
Summary: CONFIGURATION: two identical functions
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: low trivial
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: BSA target:7.6.0 target:7.5.2
Keywords:
Depends on:
Blocks: Customize-Dialog-Keyboard
  Show dependency treegraph
 
Reported: 2013-04-26 15:16 UTC by Kranthi Katikala
Modified: 2023-02-25 09:59 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kranthi Katikala 2013-04-26 15:16:37 UTC
Problem description: 
found two identical functions in tools>customization>keyboard>functions>format> rename sheet <and> rename sheet
Either the two functions are exactly identical,
or they are slightly different, in which case, the function name should be more specific.
Steps to reproduce:
1. go to tools>customization>keyboard
2. you will find under the functions thingie, format category and under that, two exactly identical functions, both named rename sheet

Current behavior:
two identical functions
Expected behavior:
need to be more specific/appropriate
              
Operating System: Fedora
Version: 3.5.7.2 release
Comment 1 Joel Madero 2013-05-29 22:07:09 UTC
Confirmed - seems like the second one isn't even usable. I'll take this bug.

Thanks for reporting!
Comment 2 QA Administrators 2013-07-18 19:20:32 UTC
Unfortunately I just haven't had the time to solve this bug - if I make any progress I will report back but until then setting back to default and NEW
Comment 3 Joel Madero 2013-08-12 22:19:13 UTC
Unassigning myself - after digging and talking to two calc experts - this one is trickier than you'd think - both functions are linked to a bunch of things so I can't just delete the label
Comment 4 QA Administrators 2015-04-01 14:41:57 UTC Comment hidden (obsolete)
Comment 5 Buovjaga 2015-04-24 11:08:53 UTC
Reproduced.

Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64)
Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9
TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50
Locale: fi_FI

OpenOffice.org 3.3.0
OOO330m20 (Build:9567)
Comment 6 QA Administrators 2016-09-20 09:32:37 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2019-12-03 14:10:00 UTC Comment hidden (obsolete)
Comment 8 b. 2020-07-04 10:43:00 UTC
(In reply to QA Administrators from comment #7)
> Dear Kranthi Katikala,
> 
> To make sure we're focusing on the bugs that affect our users today,
> LibreOffice QA is asking bug reporters and confirmers to retest open,
> confirmed bugs which have not been touched for over a year.

dear QA Administrators, 

i still see two entries 'Rename Sheet' in version: 

Version: 7.1.0.0.alpha0+
Build ID: 7b00fbddfb1cd55a68ed7481ebd4a5d5f60c6128
CPU threads: 8; OS: Linux 5.6; UI render: default; VCL: gtk3
Locale: de-DE (en_US.utf8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time: 2020-06-30_22:29:48
Calc: threaded
Comment 9 QA Administrators 2023-02-17 03:26:57 UTC Comment hidden (obsolete)
Comment 10 Gabor Kelemen (allotropia) 2023-02-17 15:39:30 UTC
Still happens in master. Proposed patch:
https://gerrit.libreoffice.org/c/core/+/147222/1
Comment 11 ady 2023-02-17 19:49:17 UTC
I'd like to point out that there are several items that have the same "name" (i.e. "rename sheet" is not the only one).

So, instead of "solving" just one item, perhaps there should be some kind of re-thinking about how to present the info so users can differentiate the items that have equivalent names. ATM, each tool-tip in each item might give some clue, but it is probably not meaningful for final common users.

IMHO, such re-thinking needs some discussion from UX.

The alternative would be to have patches for each individual "repeated" item names, which doesn't seem the right thing to do.
Comment 12 Commit Notification 2023-02-22 13:32:50 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5b7e54ce8fb57203068f1c2e610758523687ef9a

tdf#63965 Hide one extra Rename Sheet command from Customize dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 ady 2023-02-22 15:45:52 UTC
Just to leave an explicit trace about this:

1.
Label: Rename Sheet
Command: .uno:Name
Tooltip: Rename Sheet


2.
Label: Rename Sheet
Command: .uno:RenameTable
Tooltip: Rename Sheet
Comment 14 Gabor Kelemen (allotropia) 2023-02-23 13:27:25 UTC
(In reply to ady from comment #11)
> I'd like to point out that there are several items that have the same "name"
> (i.e. "rename sheet" is not the only one).
> 
> So, instead of "solving" just one item, perhaps there should be some kind of
> re-thinking about how to present the info so users can differentiate the
> items that have equivalent names. ATM, each tool-tip in each item might give
> some clue, but it is probably not meaningful for final common users.
> 
> IMHO, such re-thinking needs some discussion from UX.
> 

Sure, such thinking would belong to:
Bug 115527 - Redesign of the keyboard tab of the Customization dialog

The current GroupId based categorization is independent of the menu / context menu / tabbed toolbars structure, unmaintained and rather obsolete in its current form.
Comment 15 V Stuart Foote 2023-02-23 16:33:59 UTC
(In reply to Gabor Kelemen (allotropia) from comment #14)
> (In reply to ady from comment #11)
> > I'd like to point out that there are several items that have the same "name"
> > (i.e. "rename sheet" is not the only one).
> > 
> > So, instead of "solving" just one item, perhaps there should be some kind of
> > re-thinking about how to present the info so users can differentiate the
> > items that have equivalent names. ATM, each tool-tip in each item might give
> > some clue, but it is probably not meaningful for final common users.
> > 
> > IMHO, such re-thinking needs some discussion from UX.
> > 
> 
> Sure, such thinking would belong to:
> Bug 115527 - Redesign of the keyboard tab of the Customization dialog
> 
> The current GroupId based categorization is independent of the menu /
> context menu / tabbed toolbars structure, unmaintained and rather obsolete
> in its current form.

Actually, we've been down this route for bug 108458 and is why in addition to the Name of the command we now *also* see the specific UNO .uno: command in a pop-out tooltip.
Comment 16 ady 2023-02-23 16:45:21 UTC
(In reply to V Stuart Foote from comment #15)
> Actually, we've been down this route for bug 108458 and is why in addition
> to the Name of the command we now *also* see the specific UNO .uno: command
> in a pop-out tooltip.

As mentioned in comment 13, these are 2 different .uno commands. So, is comment 12 still relevant / in place / valid? Or, should this be reverted?
Comment 17 Commit Notification 2023-02-25 09:59:47 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/90b5817217bea5d789ca727a881e2ad458837a55

tdf#63965 Hide one extra Rename Sheet command from Customize dialog

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.