Bug Hunting Session
Bug 115527 - Redesign of the keyboard tab of the Customization dialog
Summary: Redesign of the keyboard tab of the Customization dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp
Depends on:
Blocks: Customize-Dialog-Keyboard
  Show dependency treegraph
 
Reported: 2018-02-07 19:49 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-04-25 13:12 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
keyboard tab mockup (75.39 KB, image/png)
2018-02-07 19:49 UTC, Yousuf Philips (jay) (retired)
Details
All shortcut keys of a command are visible in one place (35.79 KB, image/png)
2018-02-16 09:46 UTC, Thomas Lendo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2018-02-07 19:49:45 UTC
Created attachment 139674 [details]
keyboard tab mockup

My proposed redesign is available in the Customization Dialog design session and was intended to be done by Muhammet during GSoC '17 (bug 88896), but he didnt have sufficient time to do it.

https://docs.google.com/document/d/1IPXkYMmyXQzoVUdMpnBeoQdf-LNp5_oNaqfW6OFhxqA/edit#heading=h.cx6felll7qma
Comment 1 Thomas Lendo 2018-02-14 19:49:46 UTC
What I like in the current implementation is that I can see ALL keys that are assigned to a command--not only the new assigned/edited one but also the other already assigned keys. The mockup seems to copy the toolbar customization where only one command can be edited.

Also an additional command--to make possible what Heiko suggested in bug 115052 comment 3--can be inserted to assign a key also by pressing it instead of clicking through some lists.

What are the other items of the selection list where "Function keys" is shown as first item? Should the key list kept short with a list for function keys, a second list of modifier1 keys, a third list of modifier2 keys, etc.? I personally like the possibility to see all keys and assigned commands in a single list to scroll here and there without having to click at something and without loosing any change I made meanwhile when looking around.
Comment 2 Thomas Lendo 2018-02-14 19:53:43 UTC
I should have scrolled down in the attached mockup. ;-) The selection list titled "Function keys" also includes the other modifier keys and an "All" list item. My last paragraph in comment 1 is answered.
Comment 3 Yousuf Philips (jay) (retired) 2018-02-14 20:20:35 UTC
(In reply to Thomas Lendo from comment #1)
> What I like in the current implementation is that I can see ALL keys that
> are assigned to a command--not only the new assigned/edited one but also the
> other already assigned keys. The mockup seems to copy the toolbar
> customization where only one command can be edited.

The mockup doesnt change this fact when the filter drop down is set to 'All'. The mockup has filter set to 'Function keys' which is why only the Fn keys are shown.

> Also an additional command--to make possible what Heiko suggested in bug
> 115052 comment 3--can be inserted to assign a key also by pressing it
> instead of clicking through some lists.

An add button works fine in that kind of workflow used in desktop environment shortcut assignment, but isnt useful in this workflow.
Comment 4 Heiko Tietze 2018-02-15 11:06:01 UTC
(In reply to Thomas Lendo from comment #1)
> Also an additional command--to make possible what Heiko suggested in bug
> 115052 comment 3--can be inserted to assign a key also by pressing it
> instead of clicking through some lists.

Didn't remember this mockup which nicely fits into the customization. Freely defined shortcuts are not so easy to implement but this solution is feasible as an (advanced) esayhack.
Comment 5 Thomas Lendo 2018-02-16 09:46:22 UTC
Created attachment 139936 [details]
All shortcut keys of a command are visible in one place

(In reply to Yousuf Philips (jay) (retired) from comment #3)
> (In reply to Thomas Lendo from comment #1)
> > What I like in the current implementation is that I can see ALL keys that
> > are assigned to a command--not only the new assigned/edited one but also the
> > other already assigned keys. The mockup seems to copy the toolbar
> > customization where only one command can be edited.
> The mockup doesnt change this fact when the filter drop down is set to
> 'All'. The mockup has filter set to 'Function keys' which is why only the Fn
> keys are shown.
Jay, your answer is what I meant in paragraph 3 in my previous comment.
What I meant here is shown in the attached screenshot of the Customize dialog.
Comment 6 Yousuf Philips (jay) (retired) 2018-02-16 14:47:49 UTC
(In reply to Thomas Lendo from comment #5)
> Jay, your answer is what I meant in paragraph 3 in my previous comment.
> What I meant here is shown in the attached screenshot of the Customize
> dialog.

Okay i get what you mean now. Yes this functionality would be lost with the new design. If it is a feature that is deemed necessary, then a 'Current Keys' listbox could appear under the command listbox.

(In reply to Thomas Lendo from comment #1)
> Also an additional command--to make possible what Heiko suggested in bug
> 115052 comment 3--can be inserted to assign a key also by pressing it
> instead of clicking through some lists.

Thinking more about this, a plus button could appear in the middle next to add and remove, which would open up a dialog that had a field in it that a user can press the shortcut key they want to assign to the already selected command.
Comment 7 Heiko Tietze 2019-03-23 08:18:47 UTC
Latest posting with mockups is here https://design.blog.documentfoundation.org/2015/01/22/how-to-make-libreoffice-customization-usable/ (havent looked into the documents so it might be the same)
Comment 8 Cor Nouws 2019-04-25 13:12:45 UTC
(In reply to Heiko Tietze from comment #7)
> Latest posting with mockups is here
> https://design.blog.documentfoundation.org/2015/01/22/how-to-make-
> libreoffice-customization-usable/ (havent looked into the documents so it
> might be the same)
(added a comment there)