Bug 164458 - Tools -> Customize -> Keyboard: window lacks "Apply"-button
Summary: Tools -> Customize -> Keyboard: window lacks "Apply"-button
Status: RESOLVED DUPLICATE of bug 66298
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.8.4.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
: 164449 (view as bug list)
Depends on:
Blocks: Customize-Dialog-Keyboard
  Show dependency treegraph
 
Reported: 2024-12-25 13:57 UTC by Liz Lee
Modified: 2025-01-16 12:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the tools -> customize -> keyboard window (66.80 KB, image/png)
2024-12-25 16:45 UTC, Liz Lee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Lee 2024-12-25 13:57:14 UTC
Tools -> Customize -> Keyboard: window lacks "Apply"-button.

if you want to change e.g. a keyboard shortcut for the current application (e.g. writer) and subsequtnly want to change a shortcut for the "global" libre office suite, you are basically forced to klick the "OK"-button and open the window again.

just klicking the other radio button leads the previous made changes forgotten, as mentioned here:
https://bugs.documentfoundation.org/show_bug.cgi?id=164449
Comment 1 m_a_riosv 2024-12-25 15:35:45 UTC
Please attach a screenshot of that window.

Assign is only available, when it is allowed.
Comment 2 Liz Lee 2024-12-25 16:45:46 UTC
Created attachment 198261 [details]
Screenshot of the tools -> customize -> keyboard window

(In reply to m_a_riosv from comment #1)
> Please attach a screenshot of that window.
> 
> Assign is only available, when it is allowed.


yes, of course.

btw. just to be sure: i am talking about the "Apply"-button, not about the "Assign"-button.
Comment 3 V Stuart Foote 2024-12-25 23:15:01 UTC
Revision of the Keyboard panel of the Customize dialog, bug 115527 does not discuss addition of an 'Apply' key to assign/apply workflow. Adding it would allow RB mode change between global or module specific keyboard shortcuts.

Seems like it should?
Comment 4 Heiko Tietze 2025-01-06 10:57:19 UTC
Apply would be in context of the dialog. But why would you want to apply if pressing a shortcut is pointless when the customization dialog is open? I also don't get the "RB mode change"- what exactly is not possible today?
Comment 5 V Stuart Foote 2025-01-06 12:53:44 UTC
(In reply to Heiko Tietze from comment #4)
> Apply would be in context of the dialog. But why would you want to apply if
> pressing a shortcut is pointless when the customization dialog is open? I
> also don't get the "RB mode change"- what exactly is not possible today?

The RB allow you to manage effects on global *OR* on specific target module, but not both.

Currently, any pending changes while in dialog (without OK *and relaunch*) get dropped when attempting to customize if user toggles the RB.  

Seems like the dialog should allow you to complete a module change and then a global change or vice versa in a single session. The current KB 'Assign' button only sets the change as pending, 'OK' button completes assignment but closes the dialog.

Work flow could be the assignment and completion in Global, then select RB for active module and 'Assign' and complete customization(s) there as well all in a single launch of the dialog.
Comment 6 Heiko Tietze 2025-01-07 10:34:30 UTC
(In reply to V Stuart Foote from comment #5)
> The RB allow you to manage effects on global *OR* on specific target module,
> but not both.
Then we need to fix this rather introducing a workaround.
Comment 7 Liz Lee 2025-01-07 11:13:19 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to V Stuart Foote from comment #5)
> > The RB allow you to manage effects on global *OR* on specific target module,
> > but not both.
> Then we need to fix this rather introducing a workaround.

imho right, this is exactly what I have been suggesting here:

https://bugs.documentfoundation.org/show_bug.cgi?id=164449
Comment 8 V Stuart Foote 2025-01-07 12:02:55 UTC
*** Bug 164449 has been marked as a duplicate of this bug. ***
Comment 9 Heiko Tietze 2025-01-16 07:54:14 UTC
We discussed the topic in the design meeting.

Proper solution is to show both, the application-wide and per module shortcut, at once. This is proposed in bug 115052 and bug 115527.

In any case this issue is a duplicate of bug 66298 (and I'll comment there too).

*** This bug has been marked as a duplicate of bug 66298 ***
Comment 10 V Stuart Foote 2025-01-16 12:47:24 UTC
(In reply to Heiko Tietze from comment #9)
> We discussed the topic in the design meeting.
> 
> Proper solution is to show both, the application-wide and per module
> shortcut, at once. This is proposed in bug 115052 and bug 115527.
> 
> In any case this issue is a duplicate of bug 66298 (and I'll comment there
> too).
> 
> *** This bug has been marked as a duplicate of bug 66298 ***

And the resolution would likely be as noted on the duplicate bug 66298#9
<snip>
The design group discussed the topic for bug 164458 and recommend to just immediately apply the shortcuts when entered.

(There are probably more duplicates => higher importance)
</snip>