Steps to Reproduce: 1. Open Spreadsheet 2. Type "this is a test" -- lots of spaces 3. Save as ODS 4. Close 5. Open Expected: You see the text as you wrote it Observed You see "this is a test" with a single space Also exists on master
Marking as NEW as it's been confirmed by erAck & Papamatti Also erAck confirmed that the data is stored - just not reading correctly upon opening
prolly related (not yet reported as bug) type " =3+4" in a cell (without double quotes, but with leading space this shows as " =3+4" save file and reopen > space is removed and cell shows "7"
When reading aaa bbb (5 spaces) =3+4 (text with 1 leading space) saved with 4.0.4 <table:table-row table:style-name='ro1'> <table:table-cell office:value-type='string'> <text:p>aaa <text:s text:c='4' />bbb </text:p> </table:table-cell> </table:table-row> <table:table-row table:style-name='ro1'> <table:table-cell office:value-type='string'> <text:p> <text:s />=3+4 </text:p> </table:table-cell> </table:table-row> in 4.1.0.2 this results in aaa bbb (1 space only) = #NAME? (i.e. interpreted as formula with no content) Saving again in 4.1.0.2 leads to data loss.
Found the cause, working on a fix.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=be10607d358f7587f10e76084893ceed3a4c9215 resolved fdo#67094 handle <text:s> in <text:p> and <text:span> The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Pending review for 4-1 as https://gerrit.libreoffice.org/5051 for 4-1-0 as https://gerrit.libreoffice.org/5052
I can't see this in an RC5 for 4.1.0 personally. Too old a bug, and too big a patch I think; it's obviously the right thing to do for 4.1.1 though [!]. It would be -lovely- to see a unit test for it too IMHO ;-) thanks for the quick fix Eike !
(In reply to comment #7) > .... Too old a bug, and ... of course I can't step in the other considerations, but this issue is only 3 days old :)
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9f768c3443a6194e6b46c4c6a7be1de712d54f6&h=libreoffice-4-1 resolved fdo#67094 handle <text:s> in <text:p> and <text:span> It will be available in LibreOffice 4.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to comment #8) > (In reply to comment #7) > > .... Too old a bug, and ... > > of course I can't step in the other considerations, but this issue is only 3 > days old :) Michael was probably referring that the regression was introduced in master beginning of February and wasn't discovered until now.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-4-1-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3d1ab404feb742c59652b381c54af4ca624dca15&h=libreoffice-4-1-0 resolved fdo#67094 handle <text:s> in <text:p> and <text:span> It will be available already in LibreOffice 4.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to comment #10) > Michael was probably referring that the regression was introduced in master > beginning of February and wasn't discovered until now. I guess so yes ;) (Alas no daylies for me. And no extra time either of course)
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=038d162b175b62d67a94d4418b3a15a1a382419d unit test for <text:s> in <text:p> and <text:span>, fdo#67094 The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This all looks beautiful, and thanks Eike for fixing it so nicely & unit testing it too => marking fixed to make MAB's easier to grok :-)
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a45098d295eeb1848dbe53f79047ffbb75f5f38e&h=libreoffice-4-1 unit test for <text:s> in <text:p> and <text:span>, fdo#67094 It will be available in LibreOffice 4.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to comment #11) > It will be available already in LibreOffice 4.1.0. Note that the commit happened after RC4 tagging, the fix will actually be in 4.1.1 The commit 3d1ab404feb742c59652b381c54af4ca624dca15 could be applied as a hotfix if someone wanted to roll an own 4.1.0 build.
*** Bug 67458 has been marked as a duplicate of this bug. ***