LibreOffice flips icons for e.g. line spacing, numbering, and increased indents when switching to RTL mode. This can result in icons with mirrored numerals and sometimes with incorrect appearance (e.g. the icon style may specify lighting from the top left, mirrored icons appear lit from the top right).
It'd be preferrable if separate RTL icons were used instead.
To reproduce, click the RTL button in the toolbar or press Ctrl-Shift-D.
It would be great if you can send in an image of how it incorrectly looks as it looks fine in my theme.
Created attachment 101757 [details]
how the toolbar looks in RTL mode in English and Arabic UIs
(In reply to comment #2)
> Created attachment 101757 [details]
> how the toolbar looks in RTL mode in English and Arabic UIs
It's only visible in one icon in the screenshot. Take a close look at the numbering icon and you'll see that the numerals are inverted.
So other than the number list icon, are there any other icons that would need an RTL version?
(In reply to comment #4)
> So other than the number list icon, are there any other icons that would
> need an RTL version?
All icons that are currently being flipped need to be replaced with RTL versions.
Many of those may be perfectly legible when flipped and, in some icon sets, may look exactly the same as their RTL versions would, but generally it's better practice to produce RTL versions than rely on flipped icons. For example, some icon sets are lit asymetrically (e.g. from the top left) and flipped icons look out-of-place among correctly-lit icons. Additionally, some icons that perhaps should be flipped aren't because they contain text -- superscript and subscript for example.
Adding the ux-team for their input.
Is there really need to have two versions of icons, LTR and RTL? I have never seen such an overkill, IMHO, and would rather attribute it to badly designed icons if they don't fit in RTL - not mirrored.
On the other hand it makes sense for the bullets. So why don't we prepare a special icon set for RTL, i.e. put designers in charge and not the devs.
(In reply to Heiko Tietze from comment #7)
> Is there really need to have two versions of icons, LTR and RTL? I have
> never seen such an overkill, IMHO, and would rather attribute it to badly
> designed icons if they don't fit in RTL - not mirrored.
No, separate LTR and RTL versions are needed only for a few select icons -- those dependent on text direction. For example: undo, redo, (the new Tango icons use color to distinguish the two), superscript, subscript, bullets, numbering, and I'm sure there are some more, but it's not very many.
> On the other hand it makes sense for the bullets. So why don't we prepare a
> special icon set for RTL, i.e. put designers in charge and not the devs.
It'd be very easy to do -- we just need devs to make it so that an RTL setting prefers icons suffixed with "_rtl" and doesn't flip any icons. It'd be good to get a list of the icons that LibreOffice currently flips, so that we have a list of RTL icons to make.
*** Bug 95613 has been marked as a duplicate of this bug. ***
We're replacing our use of the 'ux-advise' component with a keyword:
Component -> LibreOffice
Add Keyword: needsUXEval
(In reply to Tin Man from comment #8)
> No, separate LTR and RTL versions are needed only for a few select icons --
> those dependent on text direction. For example: undo, redo, (the new Tango
> icons use color to distinguish the two), superscript, subscript, bullets,
> numbering, and I'm sure there are some more, but it's not very many.
Undo, redo, and bullets look fine to me reversed. Cant reverse or do anything about superscript and subscript as it uses english letters. Numbering uses '1' and '2' which when reserved are flipped which it shouldnt, so this should be fixed.
> It'd be very easy to do -- we just need devs to make it so that an RTL
> setting prefers icons suffixed with "_rtl" and doesn't flip any icons. It'd
> be good to get a list of the icons that LibreOffice currently flips, so that
> we have a list of RTL icons to make.
Maxim: What do you think of this solution of switching in rtl icons, as flipping the current one doesnt generate a suitable icon?
*** Bug 114445 has been marked as a duplicate of this bug. ***
So this doesnt affect breeze and galaxy icon themes which use roman numerals in the numbering list icon, but affects other icon themes that use 1 and 2 in their icon.
Created attachment 144770 [details]
LibreOffice 6.0 icon RTL
In the 6.0 version, this is not reproducable
إصدارة: Version: 18.104.22.168
Build ID: 1:6.0.6-0ubuntu0.16.04.1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2;
Locale: id-ID (id_ID.UTF-8); Calc: group
From a user's perspective, I suggest great care be taken to asses users' reaction to icon direction flipping. Some may like it, some may not.
Anyway, things haven't changed as of 22.214.171.124
Created attachment 145501 [details]
Template whose use reproduces icon mirroring issues
I cannot reproduce the bug when opening a blank new document, but it does show up if I use the template I am attaching here.
Build ID: 1:6.1.2-1
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3;
Locale: en-US (en_IL.UTF-8); Calc: group threaded
(en_IL is a bit of a fabricated locale, but I've tried with en_US.UTF-8 and he_IL.UTF-8 and it didn't make any difference)
The numbered list icon in RTL LO 126.96.36.199 on Windows 10 1803 is wrong (mirrored 1 and 2 numbers), Colibre theme.
As this pretty old bug, I am wondering if new bug should be opened, for the specific icon issue?
(In reply to Boaz Dodin from comment #17)
> The numbered list icon in RTL LO 188.8.131.52 on Windows 10 1803 is wrong
> (mirrored 1 and 2 numbers), Colibre theme.
> As this pretty old bug, I am wondering if new bug should be opened, for the
> specific icon issue?
I think this issue still applies...
I submitted today an patch where I add rtl icon support in the language folder where flipping isn't useful. For me that's an good solution, cause it is language specific and don't need coding work.
I hope it will work fine for everybody.
Tested by launching with SAL_RTL_ENABLED=1 and the numbered list icon is ok in all icon themes.
Arch Linux 64-bit
Build ID: cfbb223d5666cb803539ac98918ff39b27efc6e7
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3;
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Built on 24 April 2019
awesome so best practice to fix this bugs is to add language specific icons to the cmd folder.
(In reply to Buovjaga from comment #21)
> Tested by launching with SAL_RTL_ENABLED=1 and the numbered list icon is ok
> in all icon themes.
Hi, thanks for your help, although it is unclear to me:
1) Did you test with Andreas` patch?
2) Did you try the template I attached?
Ok, apologies, for some reason I ignored completely the original description for this. This does not need an RTL UI - I can reproduce the problem simply by clicking the RTL button.
Andreas's commit was in my build.
Andreas patch is just related to Arabic UI, not RTL input. So, we need a dev touch here. My suggestion is to replace flipping behavior with pointing to an RTL icon UI instead. Does the coding work is considerable as a easyhack?
when it's an easyhack than an codepointer is needed.