Created attachment 92595 [details] Doc file causing Writer freeze Problem description: Writer freezes or loop in .doc file trying unsucsessfully to import it. Steps to reproduce: 1. .... 2. .... 3. .... Current behavior: Expected behavior: Operating System: All Version: 4.1.4.2 release
The same file can be opened with Apache OpenOffice 4.0.1
Hi, Reproduced with: - LibO 3.3.0.4 : les 2 fichiers gèlent - LibO 3.5.7.2 : les 2 fichiers gèlent - LibO 4.1.4.2 : les 2 fichiers gèlent - LibO 4.2.0.2 - LibO Version: 4.3.0.0.alpha0+ Build ID: 99159a618fd1ea90a2bc8a72621c88a4cf26e6f5 TinderBox: Win-x86@47-TDF, Branch:MASTER, Time: 2014-01-17_06:46:31 NOT reproduced with: - OOo 3.3.0m20 - AOO 3.4.0 - AOO 4.0.1 The bug was introduced at the beginning of LibO
*** Bug 73937 has been marked as a duplicate of this bug. ***
Created attachment 92621 [details] Simplified version of the test document The non-breaking space just after a long field seems to be responsible of the freeze. Just remove it and LibO could open the document.
Sorry, I made a mistake with attachment 92621 [details]. There is no freeze with it. Note that the field appears in the margin and is ending outside the page. BUT, if you insert a non-breaking space just BEFORE the last point (so just after the field), then LibO freezes.
I confirm freeze with the first attachement on Ubuntu 12.04.4 x86_64 with LibreOffice 4.2.0.2 Build ID: 601a398b803303d1a40a3299729531824fe0db56
Thanks you Laurent !It's really a matter of non breaking space after a field. Allow me to add some details: - The issue appears when we have a list field. (it works fine with a text field). - The freeze occurs when the list field comes after a line break and followed by a non breaking space. - Even if the we have a short list field, the bug is there with the above conditions.
Created attachment 92676 [details] List field causing the freeze List field followed by a non breaking space causing the freeze.
Created attachment 92677 [details] Text field for a successful opening Text field followed by a non breaking space works fine
Confirmed:4.2.0.3:OSX Open test file > crash
I've debugged the freeze behaviour. Here is what i found: Actually, when trying to import "List field causing the freeze" document (and all similar documents), we have a loop when calling: Window::Show( bool bVisible, sal_uInt16 nFlags ) implemented in vcl/source/window/window.cxx. Anyone has any idea to fix this bug that appears in all LibreOffice versions ?
*** Bug 73616 has been marked as a duplicate of this bug. ***
Adding to 4.1 MAB as duplicate Bug 73616 was in 4.1 MAB before being declared a duplicate.
@Mohamed, @Laurent do you have a backtrace of the freeze ?
Created attachment 94243 [details] Freeze backtrace
Seems for me that it is a layout freeze.
it loops in SwTxtFormatter::FormatLine could it be that a nb-space space is taken into account _before_ realizing that the previous character is a new-line hence the non-breaking space should not tie it to the previous thing ? iow something like: \n so that is the end of the line.. but nb-space so we want to keep it and the field after it.. but that is too long so let's try to break it again... oh there is a \n let's break, but there is a nb-space... etc... (just a guess)
I tested with a one week master and it seems to not freeze, but need to be checked, not sure why, (perhaps --enable-debug or something like that)
(In reply to comment #19) > I tested with a one week master and it seems to not freeze, but need to be > checked, not sure why, (perhaps --enable-debug or something like that) Still reproducible with a non-debug build (675ff51f2e0e1bf0d9f689382162a3e62e0f0f48) on Mac OSX 10.9 Kind regards, Joren
*** Bug 75548 has been marked as a duplicate of this bug. ***
Fix priority for MABs.
If enhanced fields is disabled in ww8par5.cxx in Read_F_FormListBox then it layouts out ok
Caolán is right. That works fine for me with this patch (as a draft): https://gerrit.libreoffice.org/#/c/8761/ => Fixed
Tested correctly in LO 4.1.4.2 (Actually Read_F_FormListBox is in ww8par3.cxx)
hang on a sec, lets try something else
Created attachment 96422 [details] rework the dropdown portion to be a fldportion my first cut at this also works and keeps the dropdown list thingy the same as the old one did
With these enhanced fields dropdowns examining how they appear in the spellchecking dialog shows up a whole extra can of worms.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a52ee51269a47e52d68405caf8507e1abaa6fd8f Resolves: fdo#73936 make FormFieldDropDowns a real fieldportion The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c76b8783e2ada67449fd88390c30943ca7f5a55e Related: fdo#73936 detect dropdown form fields as fields for spellchecking The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0c545bede035f3a4757ac433d919f65d1d06cf0 Related: fdo#73936 expand FormFieldDropDowns in ModelToViewHelper The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=88005f6f2541e12325c3e00aa438317ed8ab06bd Related: fdo#73936 allow ModelToViewHelper to not expand footnotes.. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e0118aba0d41008c1a31b1cdc7ce7596b894ae2 Related: fdo#73936 use ModelToViewHelper to expand SwTxtNodes The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolan McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=38e4ef50d43bdab45e7b43244b3fc6dde6f0e697 Related: fdo#73936 for spelling restrict formelements-as-fields.. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you Caolán for the patch. That solves a lot of problems !
I'm not particularly happy about these enhanced fields which seem a little unfinished, but the major issue of hanging is resolved by the first commit so I'll call this tentatively fixed.
I do not reproduce the freeze with LO 4.2.5.0.0+ under Ubuntu 14.04 x86-64 but the commits fixing the problem are for the master. Did these commits have been backported to 4.2 branch ? Best regards. JBF