Bug 77007 - FILEOPEN: User asked to save changes upon exit from unmodified XLS file (because of chart)
Summary: FILEOPEN: User asked to save changes upon exit from unmodified XLS file (beca...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: XLS ModifiedStatus
  Show dependency treegraph
 
Reported: 2014-04-03 14:29 UTC by larin
Modified: 2020-09-15 05:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
a sample .xls file with a chart to illustrate the problem (12.50 KB, application/vnd.ms-excel)
2014-04-03 14:29 UTC, larin
Details
testcase (41.00 KB, application/vnd.ms-excel)
2014-10-19 19:53 UTC, Yan Pas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description larin 2014-04-03 14:29:08 UTC
Created attachment 96853 [details]
a sample .xls file with a chart to illustrate the problem

LibreOffice Calc, ver. 4.0.4.2, Linux CentOS

Problem not critical but annoying.

Calc prompts user to save an XLS file (which contains a chart) when no changes were made to the file.  It seems as if the presence of a chart in the file may be triggering this.

A sample.xls file is attached.  To reproduce the problem, try opening and closing the file.

Thanks,
Max
Comment 1 Owen Genat (retired) 2014-04-04 05:23:25 UTC
Confirmed under Debian 7 with v4.1.4.2 Build ID: 0a0440ccc0227ad9829de5f46be37cfb6edcf72 and Crunchbang 11 with v4.2.2.1 Build ID: 3be8cda0bddd8e430d8cda1ebfd581265cca5a0f. Opening the provided XLS results in the file modified status being triggered, thus closing the file asks for confirmation. Status set to NEW.
Comment 2 Yan Pas 2014-10-19 19:53:41 UTC
Created attachment 108074 [details]
testcase

I have this bug too. My file
Comment 3 ign_christian 2014-10-20 02:28:30 UTC
Repro with LO 4.3.2.2 portable - Win7 x86

Seems a fileopen problem, not filesave. If someone could provide simple test case with exact reproducible steps it would help dev a lot.
Comment 4 Yan Pas 2014-10-20 07:15:33 UTC
What do you mean under testcase? List of steps how to create such file with bug?
Comment 5 ign_christian 2014-10-20 12:34:29 UTC
(In reply to Yan Pashkovsky from comment #4)
> What do you mean under testcase? List of steps how to create such file with
> bug?
Yup. More simple the steps to repro bug, more easy for dev to identify problem & fix the bug.
Comment 6 Yan Pas 2014-11-04 17:51:42 UTC
I have found that if I delete all 3 diagrams from my xls I am no longer asked to save file
Comment 7 Yan Pas 2014-12-12 10:31:21 UTC
(In reply to ign_christian from comment #5)
> (In reply to Yan Pashkovsky from comment #4)
> > What do you mean under testcase? List of steps how to create such file with
> > bug?
> Yup. More simple the steps to repro bug, more easy for dev to identify
> problem & fix the bug.

Another dependency! Steps to reproduce:
1) Create xls file
2) Insert formula (X^2 for example)
3) Save it
4) Open again and try to close - you will be asked if you want to save changes
Comment 8 QA Administrators 2015-12-20 16:07:03 UTC Comment hidden (obsolete)
Comment 9 Yan Pas 2015-12-20 22:02:51 UTC
Still presents 5.0.4
Comment 10 QA Administrators 2017-01-03 19:55:04 UTC Comment hidden (obsolete)
Comment 11 Yan Pas 2017-01-06 20:01:30 UTC
5.2.3 still reproducible (Linux Mint 18)
Comment 12 QA Administrators 2018-01-07 03:31:26 UTC Comment hidden (obsolete)
Comment 13 Yan Pas 2018-01-07 15:36:42 UTC
lo 5.4 win10 still exists
Comment 14 QA Administrators 2019-05-22 02:52:27 UTC Comment hidden (obsolete)
Comment 15 Aron Budea 2020-02-17 02:25:35 UTC
Still repro with 7.0.0.0.alpha0+ (718f540fb63af27c1336f89213444e9af753b8a9).

This is actually a regression that started with the following commit, bibisected using repo bibisect-41max.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=bb97ecdbcc8d8dafd39e728b21bc68efee4eccbc
author		Markus Mohrhard <markus.mohrhard@googlemail.com>	2012-12-22 14:19:38 +0100
committer	Markus Mohrhard <markus.mohrhard@googlemail.com>	2012-12-22 14:26:43 +0100

storing the chart doc while loading is a bad idea, fdo#57530
Comment 16 Commit Notification 2020-09-15 04:10:12 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/574eec9036c5f185b3572ba1e0ca9d111eb361dc

tdf#77007: chart must honor its parent's IsEnableSetModified

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Mike Kaganski 2020-09-15 05:55:17 UTC
Must be fixed in master. The change depends on https://git.libreoffice.org/core/+/0c88fd43aebc57ebe8e4e49b74c1b6bef067ad89; I don't plan to backport them.