Bug 77441 - Display of "candlestick" stock charts is broken
Summary: Display of "candlestick" stock charts is broken
Status: CLOSED DUPLICATE of bug 75075
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
4.2.0.0.alpha0+ Master
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-04-14 16:54 UTC by walt
Modified: 2015-01-24 14:56 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of incorrect stock chart (62.90 KB, image/png)
2014-04-14 19:05 UTC, walt
Details
Very simple example created with 4.2.3.3 (16.76 KB, application/vnd.oasis.opendocument.spreadsheet)
2014-04-15 14:28 UTC, walt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description walt 2014-04-14 16:54:26 UTC
(Note: this problem occurs in at least the Linux and Windows versions.)

When displaying "candlestick" stock charts, the candle "body" is displaced downward in each individual bar.

i.e. the height of the candle body is correct, but the top edge of the body is drawn where the bottom edge should be, and the bottom edge is drawn below the lower end of the tail.

If someone will point me to the appropriate source code I'd be happy to submit a patch :)

BTW, this problem appeared somewhere between 4.1.4.2 and 4.2.3.3 but I can't be more specific than that, sorry.
Comment 1 walt 2014-04-14 17:07:08 UTC
Sorry, I just discovered that this problem also appears in 4.2.1.1
Comment 2 tommy27 2014-04-14 17:52:52 UTC
@walt
please upload a screenshot to better show what you mean and what you consider a bug.

do you remember which was the last version where the bug was not present?
Comment 3 walt 2014-04-14 19:05:45 UTC
Created attachment 97363 [details]
Screenshot of incorrect stock chart

The 'bodies' of the candlesticks look like they're about to slide off the bottom of the bars and land on the floor :)

i.e. the bottom of the body should never be lower than the 'tail'.

The last version that works correctly for me is 4.1.4.2, but I'd be happy to test earlier 4.2.x betas if you can tell me where to download them.
Comment 4 tommy27 2014-04-15 05:08:14 UTC
is this "candlestick" bug a FILEOPEN or a FILESAVE issue?

I mean, does a broken candlestick chart created in 4.2.x load correctly in 4.1.x?
viceversa, a correct chart in 4.1.x will be displayed correctly in 4.2.x?

would you please attach test files?

I don't know where to find early 4.2.x betas

you can download the 4.2.0 final release from here in portable version:
http://sourceforge.net/projects/winpenpack/files/X-LibreOffice/releases/X-LibreOffice_4.2.0_rev17.zip/download
Comment 5 walt 2014-04-15 14:24:41 UTC
I just tested 4.2.0.4 and it shows the same bug.

A spreadsheet created with 4.2.x displays correctly in 4.1.x and one created by 4.1.x displays incorrectly with 4.2.x
Comment 6 walt 2014-04-15 14:28:47 UTC
Created attachment 97416 [details]
Very simple example created with 4.2.3.3

Displays correctly in 4.1.x
Comment 7 walt 2014-04-15 23:12:08 UTC
Okay, I'm about an hour into my very first build of libreoffice from git sources.

Because 4.2.0.4 already has the bug, I decided to start with "libreoffice-4.2-milestone-1".  Does this seem a reasonable place to start bisecting?

I won't know for hours yet whether this build will even finish, or contain the bug, but I can see this process will take many hours of my time, so I'd like to know ASAP if I'm way off target.

Thanks :)
Comment 8 walt 2014-04-16 00:51:43 UTC
I'm amazed :)  git 853299f03 compiled without error.  This is easier than I expected, based on all the warnings about how fragile the libreoffice build is.

Anyway, this build already has the bug I've described, so the guilty patch was committed before 4-2-milestone-1.
Comment 9 tommy27 2014-04-16 04:10:07 UTC
I confirm issue with your test file in 4.2.3.3 under Win7x64 (it is diplayed correctly with 4.1.x, so it's a regression).

I add a Calc developer to CC list. maybe he can help.
Comment 10 Jacques Guilleron 2014-04-16 07:14:16 UTC
Hi walt,

Before anything else, see Bug 75075 - Stock Chart 3 & Stock Chart 4 not appropriate display, where a fix was provided by Markus Mohrhard and is available for master.

Thanks,

Jacques
Comment 11 walt 2014-04-16 11:52:29 UTC
Thanks Jaques, Marckus's patch fixes this bug :)
Comment 12 tommy27 2014-04-16 11:55:41 UTC
great, let's consider this asa duplicate and ask Markus if the patch can be backported to the 4.2.x branch

*** This bug has been marked as a duplicate of bug 75075 ***