Bug 78598 - SIGSEGV in ImplDevFontListData::~ImplDevFontListData()
Summary: SIGSEGV in ImplDevFontListData::~ImplDevFontListData()
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
4.0.2.2 release
Hardware: Other All
: medium normal
Assignee: David Tardon
URL:
Whiteboard: target:4.2.7
Keywords:
: 78836 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-12 10:25 UTC by Björn Michaelsen
Modified: 2014-07-20 16:58 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
stacktrace with resolved symbols (13.26 KB, text/plain)
2014-05-12 10:38 UTC, Björn Michaelsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Michaelsen 2014-05-12 10:25:33 UTC
LibreOffice shows crashes on clearing the FontListData, unfortunately there is no good reproduction scenario yet, but this issue ranks high on http://errors.ubuntu.com and also happens on Fedora. Errors.ubuntu.com reports this stacktrace to first appear on version 4.0.2.

A stacktrace (which has been reported multiple times) can be found on the Launchpad bug.

While the description of the reports by users do provide no conclusive reproduction scenario, there are:
- two report of "crash on close"
- one report of "crash while installing a font"
- one report of "crash while upgrading" 

The latter two might actually be the same as upgrades might install new fonts.
Comment 1 Björn Michaelsen 2014-05-12 10:26:28 UTC
confirmed by multiple Ubuntu reports and a Fedora report.
Comment 2 Björn Michaelsen 2014-05-12 10:38:15 UTC
Created attachment 98899 [details]
stacktrace with resolved symbols

adding stacktrace
Comment 3 Björn Michaelsen 2014-05-12 11:17:04 UTC
Looking at the errors.ubuntu.com stats of today (14.04 LTS is out relatively new still) - it seems that _all_ todays reports are from the 14.04 distro, while the bug was first seen on 4.0.2. This might suggest that this is indeed an issue of users keeping libreoffice running during an distro upgrade (with fonts and lots of other things changing below their feet).
Comment 5 Maxim Monastirsky 2014-05-19 07:06:35 UTC
*** Bug 78836 has been marked as a duplicate of this bug. ***
Comment 6 Yousuf Philips (jay) (retired) 2014-07-19 07:39:42 UTC
Well libreoffice 4.2.5 just crashed for me on Linux Mint 13 (ubuntu 12.04) after i copied some files to my ~/.fonts folder and ran 'fc-cache -fv' to refresh the cache.
Comment 7 David Tardon 2014-07-20 11:40:06 UTC
Oops... That is because the fix has never made it to 4.2... Pushed for review now.
Comment 8 Yousuf Philips (jay) (retired) 2014-07-20 13:07:39 UTC
Weird that it wasnt every put into 4.2 as Bjorn asked me to test it so that 4.2.4 could arrive in ubuntu 14.04's repo.

http://nabble.documentfoundation.org/Libreoffice-qa-Pushing-4-2-4-into-Ubuntu-Update-Repo-tp4112961p4112963.html

https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1219245

Which i replied: while having writer open, it didnt crash when i did a software update including the installation/upgrade of various font related packages (libfontconfig1, fontconfig, libxfont1, fontconfig-config, fonts-opensysmbol).
Comment 9 Björn Michaelsen 2014-07-20 16:31:46 UTC
(In reply to comment #8)
> Weird that it wasnt every put into 4.2 as Bjorn asked me to test it so that
> 4.2.4 could arrive in ubuntu 14.04's repo.

Yes, because this is patches in 4.2.4 on Ubuntu 14.04 with a vendor backport, so I wonder what exact bug you are seeing here as it cant really be the one fixed by this patch. So you likely found a different issue.

Note that the Ubuntu error tracker confirms this as there where >2750 crash reports for lp#1219245 and >560 crash reports for lp#1219732 on on libreoffice version 1:4.2.3~rc3-0ubuntu2 each, but none on 1:4.2.4-0ubuntu3.

If anything, this confirms Davids patch is good. ;)

@David: If you put that patch on gerrit, can you CC me for rubberstamping?
Comment 10 Commit Notification 2014-07-20 16:58:05 UTC
David Tardon committed a patch related to this issue.
It has been pushed to "libreoffice-4-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=dbf5d7e52d0162ba10bb971d5a3187303c386589&h=libreoffice-4-2

fdo#78598 avoid use of invalidated pointers


It will be available in LibreOffice 4.2.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.