When testing attachment 100193 [details] at bug 79476, I noticed the following: when open it with libreoffice 4.3.0.2: 1. If you input a wrong password then click OK, it warns "Wrong Password", but if you then click "Cancel", writer still opens the file which then showing as "plain text" unreadable codes. 2. If you click "Cancel", Writer still opens it with unreadable codes. Expected: When click cancel, writer exits, rather than try to open it.
Yes i've seen this behaviour a few times when it doesnt understand the format of the file.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later): https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-07-18
*** Bug 89320 has been marked as a duplicate of this bug. ***
I'll copy here my comment from Bug 89320: What we should do here is to honor the MediaDescriptor::PROP_ABORTED that written by the oox detector, and stop the detection loop (and then also make sure that GUI users won't see the filter selection dialog).
This seems to have begun at the below commit. Adding Cc: to Michael Stahl ; Could you possibly take a look at this one? Thanks 2bf0cc0044f10891eca579f07bf7b41ce2d6030c is the first bad commit commit 2bf0cc0044f10891eca579f07bf7b41ce2d6030c Author: Matthew Francis <mjay.francis@gmail.com> Date: Thu May 28 19:03:13 2015 +0800 source-hash-e62339f856efa0b8ef03df3bf8b93e098c4ac0d3 commit e62339f856efa0b8ef03df3bf8b93e098c4ac0d3 Author: Michael Stahl <mstahl@redhat.com> AuthorDate: Mon Feb 10 16:45:27 2014 +0100 Commit: Michael Stahl <mstahl@redhat.com> CommitDate: Mon Feb 10 17:02:58 2014 +0100 fdo#73363: sd: fix mis-detection of Visio files as PPT SdFilterDetect::detect() erroneously detects all binary MSO files, and because the Visio types would be checked after PPT, Visio is pre-empted. Change-Id: I6ec3647a508dc8d79b47bfff6de35ccae39416ee :040000 040000 6d44c297d066172eb951eedf8c4a8bb6131563da 249b09f6afaa45b7999171b9a2d363175750cfc9 M opt
Maxim Monastirsky committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=579c2de3a88483eff0664d3a303b19cbd386db47 tdf#80999 Canceling password prompt should abort detection It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.