Bug 81517 - FILEOPEN: pictures in .xls spreadsheets no longer displayed
Summary: FILEOPEN: pictures in .xls spreadsheets no longer displayed
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.0.0.alpha0+ Master
Hardware: Other All
: high normal
Assignee: Kohei Yoshida
URL: https://issues.apache.org/ooo/show_bu...
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: mab4.4
  Show dependency tree / graph
 
Reported: 2014-07-19 04:25 UTC by Luke
Modified: 2018-03-07 21:10 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:

Attachments
Sample XLS with inserted picture (367.50 KB, application/vnd.ms-excel)
2014-07-19 04:25 UTC, Luke 		Details
Simpler .xls illustrating the issue (29.50 KB, application/vnd.ms-excel)
2014-07-19 04:26 UTC, Luke 		Details
Screenshot highlighting the issue (528.38 KB, image/png)
2014-07-19 04:30 UTC, Luke 		Details
build-info.txt from commit b7ea5eb (2.88 KB, text/plain)
2014-08-12 18:07 UTC, Terrence Enger 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2014-07-19 04:25:35 UTC 
Created attachment 103075 [details]
Sample XLS with inserted picture

Steps to reproduce:
1.	Create a new blank workbook in Excel
2.	Insert -> picture 
3.	Save as .XLS
4.	Open file with a recent build of Calc 4.4

Expected Result:
Inserted picture is displayed in Calc like Excel

Actual Result:
“Picture X …” is displayed where the picture should be. 

On Windows Version: 4.4.0.0.alpha0+
Build ID: 3e82897353e576dc6e3fbf55371fda5a0c3415df
TinderBox: Win-x86@39, Branch:master, Time: 2014-06-17_08:55:34
Result: PASS

Version: 4.4.0.0.alpha0+
Build ID: f38bf4c6c29d685ec4f1015be09f64c7ae2eb172
TinderBox: Win-x86@39, Branch:master, Time: 2014-07-04_02:13:48
Result:FAIL
Comment 1 Luke 2014-07-19 04:26:41 UTC 
Created attachment 103076 [details]
Simpler .xls illustrating the issue
Comment 2 Luke 2014-07-19 04:30:06 UTC 
Created attachment 103077 [details]
Screenshot highlighting the issue
Comment 3 tommy27 2014-07-19 06:27:51 UTC 
I confirm bug under Win7x64 using  4.4.0.0.alpha0+
Build ID: abc28ffc04067eb24840fbf564c311aaee10f84d
TinderBox: Win-x86@42, Branch:master, Time: 2014-07-15_07:20:05

works fine in 4.2.5.2
Comment 4 Joel Madero 2014-07-27 00:50:58 UTC 
There is a similar bug in presentation that might be related, added to see also
Comment 5 Xisco Faulí 2014-08-05 14:53:41 UTC 
Regression does not appear in latest version of 43all and must be younger. Add
bibisected and bibisectednewer as specified in the QA Wiki
Comment 6 Terrence Enger 2014-08-11 20:38:18 UTC 
Responding to comment 4:

I think that bug 81078 is different.  I see versions of LibreOffice
back as far as bibisect 43all oldest showing the annoying behaviour.
(But, as I have commented there, the bug may or may not be in
LibreOffice.)
Comment 7 Terrence Enger 2014-08-12 18:04:40 UTC 
Using the daily dbgutil bibisect repository, git bibisect tells me:

    b7ea5ebd0e0fee42d8971dd75b8efbc6e0e47739 is the first bad commit
    commit b7ea5ebd0e0fee42d8971dd75b8efbc6e0e47739
    Author: Miklos Vajna <vmiklos@collabora.co.uk>
    Date:   Wed Jul 2 08:32:21 2014 +0200

        2014-07-02

    :100644 100644 105bec92e1d507efffc2080ca736d51c83f2e7f3 7978c6649b507a5e933d1044156e855691389bbe M	build-info.txt
    :040000 040000 466ed1bd541d7664f41eb2209d699c4413cc7632 d2e27a624bdbf7fdaf180168b898515ef2c069e5 M	opt

and git bisect log:

    # bad: [59a8d89d4255a1cbcab4fcfeff9270dd56c62aed] 2014-08-12
    # good: [b3130c846de5cf1b4be48b48dfc780bb369549fa] 2014-05-21
    git bisect start '59a8d89' 'oldest'
    # good: [51d0b5cdc80ce7b0a3e0694e91547d3e7942f19f] 2014-07-01
    git bisect good 51d0b5cdc80ce7b0a3e0694e91547d3e7942f19f
    # bad: [1d3584c0317743305d4720d30e66335f12f39d9d] 2014-07-21
    git bisect bad 1d3584c0317743305d4720d30e66335f12f39d9d
    # bad: [eb37477c7906b4c4b7eb11433c7566f669a040d1] 2014-07-11
    git bisect bad eb37477c7906b4c4b7eb11433c7566f669a040d1
    # bad: [b195929c45dca218e941073bcb5bcaa92d21d7f7] 2014-07-06
    git bisect bad b195929c45dca218e941073bcb5bcaa92d21d7f7
    # bad: [3c19bff344aa6109cdd40e5ab4986a95ecdd7542] 2014-07-03
    git bisect bad 3c19bff344aa6109cdd40e5ab4986a95ecdd7542
    # bad: [b7ea5ebd0e0fee42d8971dd75b8efbc6e0e47739] 2014-07-02
    git bisect bad b7ea5ebd0e0fee42d8971dd75b8efbc6e0e47739
    # first bad commit: [b7ea5ebd0e0fee42d8971dd75b8efbc6e0e47739] 2014-07-02
Comment 8 Terrence Enger 2014-08-12 18:07:35 UTC 
Created attachment 104517 [details]
build-info.txt from commit b7ea5eb

Attaching this just in case it is helpfu
Comment 9 Kohei Yoshida 2014-08-13 02:47:24 UTC 
Got hit by this myself, and reverted the responsible commit 

http://cgit.freedesktop.org/libreoffice/core/commit/?id=95f0811c093680e6258f3bc973a3f7a3731a28f4

which was a cherrypick of a "fix" from AOO.
Comment 10 Luke 2014-08-13 21:12:20 UTC 
Verified fixed with a current build of 4.4.

From https://issues.apache.org/ooo/show_bug.cgi?id=125187 this BLIP graphic bug would be annoying for anyone trying to import MSO files with large images. Could someone take another shot at merging in this AOO patch?
Comment 11 Robinson Tryon (qubit) 2015-12-15 11:03:13 UTC Comment hidden (obsolete)