Problem description: I have created a custom conditional style, to test its behaviour. After saving the document and reopening it, the style lost its conditional attribute, and it became a regular style. Steps to reproduce: 1. create a new style 2. under the 'Condition' tab check 'Conditional Style' 3. write a paragraph and use the custom style 4. save the document 5. reopen it Current behavior: The conditional style reverts to normal style. Expected behavior: The style should keep its conditional attribute. Operating System: other Version: 4.3.0.4 release
Update: The error occurs when at the time of saving the document, there are no styles applied to the custom style. 'Conditional Style' is still checked though.
Created attachment 104887 [details] screenshot of conditional style setting Hi, I do not reproduce, even after saving and the style not applied in the document, the conditional style is still set, see the screenshot attached. I'm using 4.3.0.4 Ubuntu 14.04 x64. Sophie
(In reply to comment #2) > Created attachment 104887 [details] > screenshot of conditional style setting > > Hi, I do not reproduce, even after saving and the style not applied in the > document, the conditional style is still set, see the screenshot attached. > I'm using 4.3.0.4 Ubuntu 14.04 x64. Sophie As I see, you're modifying the predefined style called 'Text Body' in english. I haven't encountered any problems with that. I created a new style, and set it as conditional. Also, I meant the error was when there were no styles applied to any context inside the settings of the style, not wether it was used in the document.
Hi Marcell, in my tests yesterday it works even with a custom style, but I applied the condition inside the dialog box. Now I understand what you said, in fact, if you do not apply a condition during the creation of the style, it's not possible to modify it after saving the document because the conditional possibility is lost. On one hand I find it normal that if you don't apply a condition, the conditional style doesn't exist, on the other hand, the possibility to modify it once created should be offered. Set it as New - Sophie
Hi Sophie! Yes, it's a bit confusing, that you can only modify it if it was saved with at least one style applied to the conditional style. Even if you create it with some styles applied, and removing them later causes the unability to modify. I can imagine some scenarios when this occurs, like you make up your mind with some formatting, and have it closed when there are no styles applied at the moment. Styles should be able to be designed as conditional styles even after creating them. As I see this wouldn't cause any problem, because the conditional ones are still modifiable later, so why couldn't the normal ones be. More so, if you have the conditional style checked, it should mean that it's meant to be a conditional style, even if it has no styles applied to it. /This time I tried it with LO version 4.2.4.2 under Ubuntu 14.04 LTS./ Marcell
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.0.5 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-09-03
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.5 or 5.2.1 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20160920
I see the problem even the condition is set immediately and works while first working on the document. After save and reload the condition is gone. To reproduce: Define a style "Red" from Default, that has a red font color. Define a style "Blue" from Default, that has a blue font color. Start defining a style "ConditionCaller" from Default. Go to tab Condition and mark "Conditional Style". Apply the style "Red" to the condition "Table Header" and the style "Blue" to "Table". OK Insert a table e.g. 2 columns and 4 rows with table header and some dummy text. Mark the whole table and apply your newly defined style "ConditionCaller". Notice that the text in the first row of the table becomes red and in the other cells blue. Save the document. Reload. Notice that the colors are lost. If you look into the file, you will see, that there are no <style:map> elements, which would be needed for a conditional style. This happens too, if you the set the conditions in the style "Text body". I have used Version: 5.2.6.2 Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Locale: de-DE (de_DE); Calc: group
Created attachment 133098 [details] Conditional formatting made by AOO 4.1.2 Open attached file. Conditions are lost on opening too.
In the meantime conditional formatting is broken totally, see bug 103091.
*** Bug 103091 has been marked as a duplicate of this bug. ***
There is currently no code in the master branch for saving or restoring paragraph style conditions.
there is no practical difference between a style that isn't conditional, and a conditional style with no conditions. as far as i can see there is no way to differentiate those 2 possibilities in an ODF document either; both cases don't have any style:map element below style:style. basically if anything this is an UI problem, we could just remove this checkbox from the dialog without any loss of functionality.
(In reply to Regina Henschel from comment #8) > I see the problem even the condition is set immediately and works while > first working on the document. After save and reload the condition is gone. > > To reproduce: > Define a style "Red" from Default, that has a red font color. > Define a style "Blue" from Default, that has a blue font color. > Start defining a style "ConditionCaller" from Default. Go to tab Condition > and mark "Conditional Style". Apply the style "Red" to the condition "Table > Header" and the style "Blue" to "Table". OK > Insert a table e.g. 2 columns and 4 rows with table header and some dummy > text. > Mark the whole table and apply your newly defined style "ConditionCaller". > Notice that the text in the first row of the table becomes red and in the > other cells blue. > Save the document. > Reload. > Notice that the colors are lost. > > If you look into the file, you will see, that there are no <style:map> > elements, which would be needed for a conditional style. > > This happens too, if you the set the conditions in the style "Text body". > > I have used Version: 5.2.6.2 > Build ID: a3100ed2409ebf1c212f5048fbe377c281438fdc > CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; > Locale: de-DE (de_DE); Calc: group The procedure described now works, but conditions set in the "Text body" style are still not working (they disappear after reloading the document) on 6.1.1.2 (x64, Windows 10).
Dear Marcell Nemes, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Please add keyword 'needsUXEval' and CC 'libreoffice-ux-advise@lists.freedesktop.org' if input from UX is needed.
*** Bug 137166 has been marked as a duplicate of this bug. ***
The built-in style "Text Body" is supposed to be a conditional style, even if currently no condition is set. See https://help.libreoffice.org/7.2/en-US/text/swriter/01/05130100.html?DbPAR=WRITER#bm_id3154656 <quote> Tip Icon The "Text Body" Style was created as a conditional style. Therefore, any styles you derive from it can be used as conditional styles. </quote>
Here is a code sample for disabling that pointless checkbox. It still needs a glade-person to fully remove it from the UI. http://gerrit.libreoffice.org/c/core/+/107162 tdf#82802 sw page-style UI: remove pointless makeConditional CB
(In reply to Justin L from comment #19) > It still needs a glade-person... /done
Proposed fix for Text Body: http://gerrit.libreoffice.org/c/core/+/10735
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1f066313218449cac494a887eb209311efbaa405 tdf#82802 sw page-style UI: remove pointless makeConditional CB It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4b5aaa9edfd58ec8f73de127410656f884f944d7 tdf#82802 sw conditional style conditions not saved for TextBody It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/64b3727adb12601d9a4010ec9160a8958d2ee878 tdf#82802 sw conditional style conditions not saved for TextBody It will be available in 7.1.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/9d6fcca559d8dbfd77448b7aed9835c1fcae93f3 tdf#82802 sw conditional style conditions not saved for TextBody It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #22) > Justin Luth committed a patch related to this issue. > tdf#82802 sw page-style UI: remove pointless makeConditional CB Oh, this regressed. Now you can't enable the styles filter in the bottom right. Will file a bug.
By the way, this seems to settle to "any condition set makes the style conditional; all conditions unset makes it not conditional at any point". Note that the documentation still states [1]: > Once defined, you cannot change the conditional properties of a conditional style. That seemed to be partially wrong even before the changes here (one obviously could add/remove mappings between specific contexts and styles for already defined conditional styles, and also the whole issue here was the ability to change a conditional style into non-conditional just by modifying its mapping); but note how the *checkbox* itself (removed in commit mentioned in comment 22) got disabled once the style was created; and how the Condition tab disappeared completely in non-conditional styles. So now the question is: why do we limit the Condition tab to only appear when the style is either newly created, or already has conditions? It is clearly possible to change this dynamically - why not show it at all times, allowing one to make any style conditional at any moment - and drop the issue that started this bug report? (Needs an own bug report; dumping it here in case I forget it all.) [1] https://help.libreoffice.org/latest/en-US/text/swriter/01/05130100.html?DbPAR=WRITER