Bug 83575 - CALC: comment does not automatically remove itself when the content becomes empty
Summary: CALC: comment does not automatically remove itself when the content becomes e...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
(earliest affected) release
Hardware: Other All
: medium trivial
Assignee: Not Assigned
Keywords: bibisected, bisected, regression
: 125361 (view as bug list)
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
Reported: 2014-09-06 22:43 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-12-13 13:01 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:

how it looks after step 7 (37.24 KB, image/png)
2014-09-06 22:43 UTC, Yousuf Philips (jay) (retired)
evidence screenshot (46.89 KB, image/png)
2014-09-10 17:21 UTC, penttila

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-09-06 22:43:52 UTC
Created attachment 105845 [details]
how it looks after step 7

1) Open Calc
2) In cell A1, add a comment and type some words in it
3) right-click on A1 and you'll see insert comment, delete comment, and show comment
4) select show comment
5) remove all words from comment
6) click out of comment area
7) comment area doesnt disappear as it used to in 4.1 and right-clicking on A1 dont have delete or hide comment options

Tested in 4.2.6 and master on Linux.
Comment 1 penttila 2014-09-10 17:21:30 UTC
Created attachment 106074 [details]
evidence screenshot

I can confirm this behaviour.

Inserting some text again in this cell still doesn't make the delete and view menu entry visible!

LinuxMint 17 Cinnamon
LO Build id.: 420m0(Build:3)
Comment 2 Yousuf Philips (jay) (retired) 2014-09-10 22:34:45 UTC
Setting to new as penttila confirmed it in comment 1.
Comment 3 Dave Richards 2014-12-08 16:36:05 UTC Comment hidden (obsolete)
Comment 4 Matthew Francis 2014-12-08 18:14:44 UTC Comment hidden (obsolete)
Comment 5 Matthew Francis 2014-12-31 08:11:35 UTC
Managed to build this on the second try. The commit where the behaviour changed appears to be the below.

Adding Cc: to lgodard.libre@laposte.net. Could you possibly have a look at this? Thanks

commit 759bdbbc348d320994813a9de1a7927b795580a3
Author: Laurent Godard <lgodard.libre@laposte.net>
Date:   Wed Sep 11 09:06:24 2013 +0200

    Re-implement cell note storage using mdds::multi_type_vector.
    Change-Id: I34ea91e360e2a6b85d65f970c6e43db687d213ca
Comment 6 Robinson Tryon (qubit) 2015-12-13 11:11:04 UTC Comment hidden (obsolete)
Comment 7 Xisco Faulí 2017-09-29 08:49:57 UTC Comment hidden (obsolete)
Comment 8 Andrew 2018-04-12 07:49:16 UTC
I can confirm this behavior is still present in

Version: (x64)
Build ID: 8f48d515416608e3a835360314dac7e47fd0b821
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
Locale: en-GB (en_GB); Calc: CL
Comment 9 Timur 2018-04-12 13:04:44 UTC
Maybe we should have "author not active" with regression, for cases like this one.
Comment 10 bear 2018-11-29 08:15:13 UTC

Still exists in version

Version: (x64)
Build ID: 0f25a3c36f27fd51453b9a9115f236b83c143684
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-27_20:06:55
Locale: zh-TW (zh_TW); UI-Language: en-US
Calc: threaded
Comment 11 QA Administrators 2019-11-30 03:40:20 UTC Comment hidden (obsolete)
Comment 12 Timur 2020-04-02 10:32:11 UTC
*** Bug 125361 has been marked as a duplicate of this bug. ***
Comment 13 Justin L 2021-12-07 12:04:06 UTC
Fixed in 7.0.

I used bibisect-linux-x64-7.0 which clearly pointed to seemingly unrelated
commit 8950cb8ae6a1621729ec43a6dd1c29cf04260797
Author: Caolán McNamara on Tue Feb 4 11:34:29 2020 +0000

    weld SvxFontSizeBox_Impl
    which enables making a native gtk widget a member of a toolbar
    This widget wants to distinguish between a value getting selected
    by the menu or not, which is fairly tricky
    Change-Id: I9014785530bd0d82ffa66842f940feb2d3237e68