Created attachment 108803 [details] screenshot Open the sidebar in an RTL language like arabic and the left and right alignment buttons arent in the right place, as they are in the toolbar.
Confirmed with master (498a40f33908791c3b2409a1ccb4b3c81ea1e032) under Fedora 20.
Fixed for the toolbar in http://cgit.freedesktop.org/libreoffice/core/commit/?id=2fd93f19cf6c1ce808214c659f5a4c4b10c0c441. The commands that need swapping were simply hard-coded in the source.
In addition to the alignment buttons being swapped, there are a number of other icons and buttons that need to be swapped or their icons flipped. LTR/RTL icons: swap Bullets/Numbering: flip Paragraph Background Color: flip Paragraph/Line Spacing: flip (increase spacing, decrease spacing, line spacing) Indent buttons: swap and flip (increase indent, decrease indent, hanging indent) Indent fields: swap (before text indent, after text indent, first line indent)
Made a mistake, the indent buttons only need a flip. :D
Created attachment 119023 [details] Another example (also with directonality buttons) This is also relevant for the directionality buttons, not only alignment buttons.
Katarina Behrens committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=07f75f6e645eca4825541f57e9d5e9479a17c559 tdf#85767: Make also sidebar toolbox item order RTL-sensitive It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified fix with a build from master. Thanks Katarina. Can we cherry-pick this to 5.0.x ?
I've cherry-picked for 5.0.
Created attachment 120172 [details] non-fixed items Reopened as the bug hasnt been fully resolved - a number of images have to be flipped horizontally when RTL is enabled similar to how they are flipped in the toolbars.
The bug mentioned only the alignment buttons (see the bug title and your first screenshot), and that's what been fixed. The bug should be resolved. Please open another issue for the other buttons. I've already asked the developer if that can be done as well (as it already implemented for the toolbar, but not the sidebar).
Katarina Behrens committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a5963b2f1b108db4f0089f41db74b673ba038af&h=libreoffice-5-0 tdf#85767: Make also sidebar toolbox item order RTL-sensitive It will be available in 5.0.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Working on this.
Fixed with http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac97f32307feb488c86d6fa962258fe79320d31b Not sure whether this should be backported, as this includes some rework (also http://cgit.freedesktop.org/libreoffice/core/commit/?id=c5fe98905deac6de4f9e76a17097ce83fe381ac3 is required).
(In reply to Samuel Mehrbrodt from comment #13) > Fixed with > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=ac97f32307feb488c86d6fa962258fe79320d31b > > Not sure whether this should be backported, as this includes some rework > (also > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=c5fe98905deac6de4f9e76a17097ce83fe381ac3 is required). I think it should be fine to have it in 5.1, so add the patch to gerrit and see what others feel about it. ;D
(In reply to Yousuf (Jay) Philips from comment #14) > I think it should be fine to have it in 5.1, so add the patch to gerrit and > see what others feel about it. ;D Ok, but first I'd like someone to confirm that it actually works.
(In reply to Samuel Mehrbrodt from comment #15) > Ok, but first I'd like someone to confirm that it actually works. Seems to work for me.
Verified fix on master (ac97f323). Thanks Samuel.
Samuel Mehrbrodt committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=df9e93750bb7ff39f4346f0e23a0493409b31c2b&h=libreoffice-5-1 tdf#85767 Enable rotated/flipped icons in the Sidebar It will be available in 5.1.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (text:RTL) [NinjaEdit]