Bug 86214 - UI: User isn't warned that entering a cell address is not allowed as range name
Summary: UI: User isn't warned that entering a cell address is not allowed as range name
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: abhilash300singh
URL:
Whiteboard: target:5.4.0
Keywords: difficultyInteresting, easyHack, needsDevEval, skillCpp
: 106608 106610 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-11-12 17:05 UTC by Luuk
Modified: 2017-03-18 14:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot with bug (61.87 KB, image/png)
2014-11-12 17:05 UTC, Luuk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luuk 2014-11-12 17:05:58 UTC
Created attachment 109360 [details]
screenshot with bug

[Version 4.3.3.2; Windows 7]

When trying to add a name to a worksheet, i see the text 
'Invalid name, only use letters, numbers and underscore'

I've use 'B2' which is a letter and a number, LO thing this is not correct, but this is not clear from the given error message.

Other thing like 'BB', 'B_', '_2', 'B2_', 'B_2' are accepted
Comment 1 Cor Nouws 2014-11-12 17:22:02 UTC
confirmed

thanks Luuk :)

I bet this is he case already for a long time...
Comment 2 QA Administrators 2015-12-20 16:07:29 UTC Comment hidden (obsolete)
Comment 3 Cor Nouws 2015-12-27 20:49:41 UTC
same on 5.2 master
Comment 4 Luuk 2016-02-21 15:56:47 UTC
In version 5.1.0.3 the 'wrong' message is still shown.

It would be more clear to a user if this message was change to:
"You cannot enter a reference to a cell, or a range of cells"
Comment 5 Cor Nouws 2016-02-22 20:52:26 UTC
@jani,
Looks as a reasonable candidate for an easy hack to me.
With one check a choice for string A or B is made.
Comment 6 jani 2016-02-22 20:58:06 UTC
I totally and with a code pointer it will be.
Comment 7 QA Administrators 2016-05-09 20:07:38 UTC Comment hidden (obsolete)
Comment 8 Cor Nouws 2016-05-10 08:29:12 UTC
a valid issue, all info here. Was NeedInfo erroneously I think
Comment 9 Cor Nouws 2016-05-10 08:29:27 UTC
.
Comment 10 jani 2016-05-10 08:31:56 UTC
(In reply to Cor Nouws from comment #9)
> .

NEEDINFO was there, because there are no code pointer, which is mandatory for a easyHack. 

Of course we can remove Easyhack, then NEEDINFO is not needed.
Comment 11 jani 2016-05-10 08:33:24 UTC
Remark, easyHacks are normally controlled by an experienced developer, so adding a code pointer should not be a problem.
Comment 12 Luuk 2016-05-13 18:35:53 UTC
(In reply to jan iversen from comment #11)
> Remark, easyHacks are normally controlled by an experienced developer, so
> adding a code pointer should not be a problem.

If that is not a problem, than it should happen within 3 month, otherwise 'QA Administrators' are closing this automatically....  ;)

@Cor, thanks for re-opening this, it's very hard to keep actual track of bugs I created or just following out of curious interest...
Comment 13 jani 2016-05-13 18:55:48 UTC
I follow easyhacks every morning, and update status and other things. I do not close bugs, that is for the QA team to do, but I make sure development easyhack follow the guidelines we have.

If NEEDINFO is disturbing, then simple put it on NEW, and remove easyhack.
Comment 14 Xisco Faulí 2016-09-27 10:36:17 UTC Comment hidden (obsolete)
Comment 15 Commit Notification 2017-01-28 00:10:03 UTC
Abhilash Singh committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=413232229cbfd9d49ce9d1cdbb6b6e2dbe83af38

tdf#86214 User isn't warned entering a cell address not allowed

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 jani 2017-01-30 06:49:10 UTC
Seems solved
Comment 17 Luuk 2017-02-01 08:02:32 UTC
Indeed seems to be solved

B1048577 is OK
B1048599 is NOT OK

now we will only hope the number of lines in Calc won't increase soon ;)
Comment 18 Commit Notification 2017-03-18 01:05:23 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=224a8b3856ec3cbe6d9f864789184d49ecb8c8d8

add test for tdf#86214

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2017-03-18 01:18:24 UTC
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a070d0d34763c83b4e957a7aee8b7f255a1d5519

extend the test for invalid names, related tdf#86214

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Xisco Faulí 2017-03-18 14:05:23 UTC
*** Bug 106610 has been marked as a duplicate of this bug. ***
Comment 21 Xisco Faulí 2017-03-18 14:05:57 UTC
*** Bug 106608 has been marked as a duplicate of this bug. ***