Bug Hunting Session
Bug 87360 - Spacing to content should be disabled for images
Summary: Spacing to content should be disabled for images
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2014-12-16 13:51 UTC by Yousuf Philips (jay) (retired)
Modified: 2018-12-20 16:11 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-12-16 13:51:53 UTC
When setting a border around an image, it automatically sets the 'spacing to contents' entries to 0.05cm and i think it should be set to 0.00cm so that it is touching the sides of the image.
Comment 1 Joel Madero 2014-12-16 15:42:10 UTC
Unless UX disagrees - I'm setting this to WONTFIX.

Sophi and I talked about it and we agree it's better as it is so you can actually see the border. This is just a difference of opinion that we'll endlessly go round and round arguing about.

If UX team discusses and disagrees, please set to NEW.
Comment 2 Yousuf Philips (jay) (retired) 2015-01-26 14:05:47 UTC
We had discussed this in one of the design/ux meetings and kendy stated that there is problems with default setting as it also alters the size of the image.
Comment 3 Yousuf Philips (jay) (retired) 2015-03-17 19:24:56 UTC
I've filled the bug kendy observed in the design session in bug 90071, while this bug report will stick with spacing being set to 0 by default.
Comment 4 Yousuf Philips (jay) (retired) 2015-04-17 10:14:34 UTC
In actuality, spacing to content should be disabled for images, as it is a feature of frames and not images.

Seems bug 90071 was added as a duplicate of bug 90070 when i submitted it.
Comment 5 Yousuf Philips (jay) (retired) 2015-04-17 12:59:53 UTC
Kendy asked me to CC you on this. :D
Comment 6 Yousuf Philips (jay) (retired) 2015-04-23 07:01:04 UTC
So this spacing issue only occurs when you enable borders through the 'Borders' or 'Border Color' buttons in the frame toolbar (.uno:SetBorderStyle, .uno:FrameLineColor) and not when you set the line style in the 'Border Style' button (.uno:LineStyle).
Comment 7 Joshua 2016-01-22 20:47:15 UTC Comment hidden (spam)
Comment 8 Regina Henschel 2016-10-14 23:43:00 UTC
An image is stored in a draw:image element, which is child of a draw:frame element. The draw:image element is the content of the draw:frame element.
And a draw:frame element has a style of style family "graphic". Such styles have a style:graphic-properties element. And this allows fo:margin, fo:border and fo:padding, which correspond to the CSS box model.
So even if you disable this feature in the UI, LO needs to be able to render ODF documents correctly, which uses padding in images.

ODF follows the CSS-box model very close, but LO does not implement it correctly.
Comment 9 Yousuf Philips (jay) (retired) 2017-05-03 15:39:59 UTC
(In reply to Regina Henschel from comment #8)
> So even if you disable this feature in the UI, LO needs to be able to render
> ODF documents correctly, which uses padding in images.

The intend isnt to disable this feature, it is to set a better default value when borders are set.
Comment 10 Regina Henschel 2018-05-26 13:07:00 UTC
Yes, the default for padding should be 0cm.
Comment 11 Heiko Tietze 2018-12-20 16:11:15 UTC
This issue might be obsolete. Newly inserted images have zero spacing in 6.1 (will be changed with bug 122063), and c6 clarifies this issue relates to borders