Bug 87441 - Sending document as Email removes invisible content - this should be a configuration option
Summary: Sending document as Email removes invisible content - this should be a config...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:4.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-18 12:18 UTC by Denis Simonet
Modified: 2022-11-20 09:49 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Proposal for the new option (46.94 KB, image/png)
2014-12-18 12:18 UTC, Denis Simonet 		Details
Sample document (8.74 KB, application/vnd.oasis.opendocument.text)
2014-12-23 08:15 UTC, Denis Simonet 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Simonet 2014-12-18 12:18:15 UTC 
Created attachment 110985 [details]
Proposal for the new option

When sending a document by eMail, OpenOffice intentionally removes any invisible content. While this can be appropriate for some users, others will not expect this to happen. In fact, there are situations where removing invisible content (such as hidden sections) damages the document. Therefore we suggest to introduce a new option which makes it possible to control this behaviour.

It is about the following code: sw/source/uibase/app/docsh2.cxx +830 (Call to mpDoc->RemoveInvisibleContent())
Comment 1 Denis Simonet 2014-12-18 12:23:57 UTC Comment hidden (obsolete)
Comment 2 Denis Simonet 2014-12-23 08:15:37 UTC 
Created attachment 111212 [details]
Sample document

I forgot to add the example document. It contains three sections, one of them being hidden (section 2). If you send this document by E-Mail, the attached document in the e-Mail won't contain section 2 anymore.
Comment 3 sophie 2014-12-26 13:04:23 UTC 
Hi, confirmed using Version: 4.3.4.1 and Ubuntu 14.10, the hidden section is removed once the document sent by mail. Set as New - Sophie
Comment 4 Commit Notification 2015-03-31 10:34:34 UTC 
Charu Tyagi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=50a0ddb99d53f86b571acc0373f0d2b4ec6d611a

fdo#87441-Send document as Email removes invisible content

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2015-03-31 10:34:38 UTC 
Stefan Heinemann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=33f1e29cb91f70e52c1af6ae33491c667b5225a6

tdf#87441: Adjustable hidden content removal in e-mails

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Stephan Bergmann 2015-03-31 10:47:51 UTC 
@libreoffice-ux-advise:  Please see the new "Internet - E-mail - Suppress hidden elements of documents" option, maybe you have suggestions for improvement (if that's the logically best pane to put the new option anyway).
Comment 7 Yousuf Philips (jay) (retired) 2015-04-01 09:30:07 UTC 
@Stephan: Looking at the english text used in the second commit, you have mispelt 'whether' as 'wheter' in "Specify wheter hidden content should be removed when sending via email". I would also suggest using "by" rather than "via". Unfortunately a new build hasnt come out today so i wasnt able to test the dialog yet, but hope to soon.
Comment 8 Commit Notification 2015-04-01 12:27:29 UTC 
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c1a9f4434c2c00a643a8a6ad330138022f2b7701

tdf#87441: RemoveHiddenContent is indep. of ExternalMailer/Program R/O state

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2015-04-01 12:27:34 UTC 
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bd23cf009a7e3c63a066794d41ae0c97589c8891

tdf#87441: Check for read-only RemoveHiddenContent

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 10 Mike §chinagl 2015-05-21 16:13:13 UTC Comment hidden (spam)
Comment 11 Adolfo Jayme Barrientos 2015-05-21 21:41:53 UTC Comment hidden (off-topic)
Comment 12 Mike §chinagl 2015-05-22 14:16:21 UTC Comment hidden (off-topic)
Comment 13 QA Administrators 2016-09-20 10:13:57 UTC Comment hidden (obsolete)
Comment 14 Duffey O. 2016-09-23 12:10:51 UTC 
Test is OK on LibreOffice 5.0.0.5 on Red Hat Enterprise Linux Server release 6.6 (Santiago).