Observed on OSX 10.10, LO from 4.2.0.4 to 4.5 master The tooltip for a hyperlink in Calc is wrong for OSX. It reads: "ctrl+click to open hyperlink:..." but the correct shortcut is "⌘ (command) + click". The equivalent text in Writer is correct (Impress seems never to have been converted from the old-style tooltip which just shows the link text and nothing else)
Code pointers: Ctrl click for Writer is: 142 String STR_LINK_CTRL_CLICK 143 { 144 Text [ en-US ] = "%s-Click to follow link"; 145 }; http://opengrok.libreoffice.org/xref/core/sw/source/uibase/utlui/initui.src#142 which gives: 212 aLinkCtrlClick(SW_RESSTR(STR_LINK_CTRL_CLICK)), http://opengrok.libreoffice.org/xref/core/sw/source/uibase/utlui/initui.cxx#212 then: 221 vcl::KeyCode aCode( KEY_SPACE ); 222 vcl::KeyCode aModifiedCode( KEY_SPACE, KEY_MOD1 ); 223 OUString aModStr( aModifiedCode.GetName() ); 224 aModStr = aModStr.replaceFirst(aCode.GetName(), OUString()); 225 aModStr = aModStr.replaceAll("+", OUString()); 226 aLinkCtrlClick = aLinkCtrlClick.replaceAll("%s", aModStr); http://opengrok.libreoffice.org/xref/core/sw/source/uibase/utlui/initui.cxx#221 So I think the work should begin here: 2056 String STR_CTRLCLICKHYPERLINK 2057 { 2058 Text [ en-US ] = "ctrl+click to open hyperlink:"; 2059 }; http://opengrok.libreoffice.org/xref/core/sc/source/ui/src/globstr.src#2058
Patch submitted here: https://gerrit.libreoffice.org/#/c/13712/ Andras: I'm worrying the fact the patch changes a string to translate whereas the freeze of "Hard English strings" already happened according to https://wiki.documentfoundation.org/ReleasePlan/4.4#4.4.0_release. Moreover, as indicated in the patch, there are still UI things to define. Any thoughts?
Worth noting that the change makes the string in question identical to one which already exists in sw/source/uibase/utlui/initui.src - effectively a translatable string is being removed, not added
(In reply to Matthew Francis from comment #3) > Worth noting that the change makes the string in question identical to one > which already exists in sw/source/uibase/utlui/initui.src - effectively a > translatable string is being removed, not added You meant "replaced" not "added"? Jay: I wonder if a new bugtracker about refactoring these kind of strings could be useful. Indeed, I don't know why there should be 2 locations to define the tip for click link/hyperlink. Any thoughts?
Isnt it better to just detect 'ctrl' in the string and auto convert it to the mac equivalent, so that string replacement wont need to happen.
(In reply to Jay Philips from comment #5) > Isnt it better to just detect 'ctrl' in the string and auto convert it to > the mac equivalent, so that string replacement wont need to happen. You cannot easily detect "Ctrl" string, because it can be localized (e.g. "Strg" in German).
(In reply to Julien Nabet from comment #2) > Patch submitted here: > https://gerrit.libreoffice.org/#/c/13712/ > > Andras: I'm worrying the fact the patch changes a string to translate > whereas the freeze of "Hard English strings" already happened according to > https://wiki.documentfoundation.org/ReleasePlan/4.4#4.4.0_release. > Moreover, as indicated in the patch, there are still UI things to define. > Any thoughts? You can fix it master only. It is not a very important problem in my opinion. You can find more occurrences of "Ctrl" on UI, e.g. on presenter's screen help ("Ctrl+'1'" etc.), "Press Ctrl+Alt+A to move focus for more operations", "Press Ctrl+Alt+B to move focus back to the current structure control", "Ctrl-click required _to follow hyperlinks".
I remember i recently added 'CTRL' to the zoom and pan tool for Impress/Draw. :D So maybe this bug report can be turned into the bug tracker to find and fix all of these issues.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b4e8e77639d3af012879d2419d376041087539e Resolves fdo#87863: Calc tooltip text for hyperlink wrong on OSX It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Following what Andras indicated in https://bugs.freedesktop.org/show_bug.cgi?id=87863#c7, let's put this one to FIXED.
@Matthew: Can you make another bug reporter to be used for the tracking down of similar problems for the Mac.
*** Bug 82682 has been marked as a duplicate of this bug. ***
*** Bug 89083 has been marked as a duplicate of this bug. ***