Working on bug 87937 when suddenly... CRASH! LO Version: 4.5.0.0.alpha0+ Build ID: 5c60dab390d66a4d5abeaf548efecf3913b90839 TinderBox: Linux-rpm_deb-x86_64@46-TDF Branch:master Time: 2014-12-31_00:20:30 Locale: en_US Let's get some REPRO up in this bug: - Enable LibreOffice dialogs - File -> Open -> Servers - Then File Service -> Type -> CMIS - Name: "a" - Type: CMIS - Click the "⟳" (Refresh-looking) button RESULT: LibreOffice will crash
Looks like bug 73090 had the same behavior but unfortunately never got a confirmed REPRO.
On pc Debian x86-64 with master sources updated today, here what I tried: - open Writer - enabled LO dialog (Tools/Options/General/"Use LibreOffice dialogs" checked) - chose File Open - clicked "Servers..." button - Selected Type "CMIS" in "File Service" - typed "a" in "Name" textbox - chose "Alfresco 4" in "Server Type" (Server details) listbox - clicked Refresh => A popup appeared to ask user password Noticed, I let the default binding URL: http://<host>/alfresco/cmisws/RepositoryService?wsdl Did I miss something?
(In reply to Julien Nabet from comment #2) > On pc Debian x86-64 with master sources updated today, here what I tried: > - open Writer > - enabled LO dialog (Tools/Options/General/"Use LibreOffice dialogs" checked) > - chose File Open > - clicked "Servers..." button Ok > - Selected Type "CMIS" in "File Service" > - typed "a" in "Name" textbox Are those fields in reverse-order for you? For me it's: Name: Type: > - chose "Alfresco 4" in "Server Type" (Server details) listbox Why? My instructions didn't say to click the 'Server Type' box :-) > - clicked Refresh > => A popup appeared to ask user password > Noticed, I let the default binding URL: > http://<host>/alfresco/cmisws/RepositoryService?wsdl k > > Did I miss something? I think you were *nice* and tried to fill in all of the fields. My goal here is to break/crash LibreOffice, so this time please follow the steps and just click the Refresh-looking button.
(In reply to Robinson Tryon (qubit) from comment #3) ... > > - Selected Type "CMIS" in "File Service" > > - typed "a" in "Name" textbox > > Are those fields in reverse-order for you? For me it's: > Name: > Type: No but you indicated: " - Then File Service -> Type -> CMIS - Name: "a" " > > - chose "Alfresco 4" in "Server Type" (Server details) listbox > > Why? My instructions didn't say to click the 'Server Type' box :-) Where? I just read: " Type: CMIS " after "Name: "a"" so thought you had made a mistake and meant Alfresco type I tried again and definitely missed something since I still don't reproduce this :-(
(In reply to Julien Nabet from comment #4) > (In reply to Robinson Tryon (qubit) from comment #3) > ... > > > - Selected Type "CMIS" in "File Service" > > > - typed "a" in "Name" textbox > > > > Are those fields in reverse-order for you? For me it's: > > Name: > > Type: > No but you indicated: > " > - Then File Service -> Type -> CMIS > - Name: "a" Ah, okay -- I copied-in some of the repro steps from another bug that I was trying to repro, but I was trying to do too many things at once. Let me rewrite my instructions to not be so shitty :-) REPRO Steps: - Open LibreOffice - Enable LibreOffice dialogs - File -> Open - Click 'Servers' button - Under 'File Service': - Name: a - Type: CMIS - Now click the "⟳" (Refresh-looking) button Expected: Anything but a crash Result: Sadness
I've got a popup error with "Nonexistent file." Hope someone else will be luckier than me! :-)
Just compiled on my PC, from latest master of an hour ago. I did the following: - Enable LibreOffice dialogs - File -> Open -> Servers - Then File Service -> Type -> CMIS - Name: "a" - Type: CMIS - Click the "⟳" (Refresh-looking) button and I got a dialogue box "Nonexistent file." I'm on Xubuntu 14.04 AMD64.
(In reply to David Gerard from comment #7) > Just compiled on my PC, from latest master of an hour ago. I did the > following: > ...[repro steps] > and I got a dialogue box "Nonexistent file." Hmmm, hmm. I'll test the next daily -- hopefully it's been fixed in the last couple of days :-)
Ubuntu 14.04 x 64 LibreOffice 4.5 Build Date: Fri Jan 2 21:30:03 2015 +0100 Cannot reproduce, I see same thing as Julien and David. Closing as WFM. Robinson if you can reproduce on a newer build still, you know what to do :)
I can confirm crash with Version: 4.5.0.0.alpha0+ Build ID: a272f5b7b30f356418ecf28eb95d066f081d1624 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-01-09_09:50:59 Steps from description.
Created attachment 112022 [details] gdbtrace
Thank you raal for the bt. I noticed this part: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff2274736 in vcl::Window::ImplCalcToTop(ImplCalcToTopData*) () from /opt/libreofficedev4.5/program/libvcllo.so (gdb) backtrace #0 0x00007ffff2274736 in vcl::Window::ImplCalcToTop(ImplCalcToTopData*) () from /opt/libreofficedev4.5/program/libvcllo.so Caolan/Chris: I noticed in the function ImplCalcToTop there was no check on pPrevData (which is the parameter of the function): 227 if ( !aInvalidateRegion.IsEmpty() ) 228 { 229 ImplCalcToTopData* pData = new ImplCalcToTopData; 230 pPrevData->mpNext = pData; 231 pData->mpNext = NULL; 232 pData->mpWindow = this; 233 pData->mpInvalidateRegion = new vcl::Region( aInvalidateRegion ); 234 } so I thought about this straightforward patch: - if ( !aInvalidateRegion.IsEmpty() ) + if ( pPrevData && !aInvalidateRegion.IsEmpty() ) Any idea?
Can't reproduce either and not sufficient symbols to determine if julien's theory of a NULL pPrevData is plausible.
TESTING again with the latest daily build of master OS: Ubuntu 14.04 LO Version: 4.5.0.0.alpha0+ Build ID: 84c69550bcb8139669de9cf98b51c35f21fe853d TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-01-13_08:44:23 Locale: en_US (In reply to Robinson Tryon (qubit) from comment #5) > REPRO Steps: > - Open LibreOffice > - Enable LibreOffice dialogs > - File -> Open > - Click 'Servers' button > - Under 'File Service': > - Name: a (Faster repro: Leave the 'Name' field empty) > - Type: CMIS > - Now click the "⟳" (Refresh-looking) button > > Expected: Anything but a crash > > Result: Sadness CONFIRMED -- Same crash with 4.5-master build on 2015-01-13 (In reply to Caolán McNamara from comment #13) > Can't reproduce either and not sufficient symbols to determine if julien's > theory of a NULL pPrevData is plausible. Caolan: What can we do to help track this down?
Might this be a dupe of bug 89947?
Robinson: any update with last stable LO version 5.0.3? Indeed, there've been some improvements on CMIS since July (see http://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=cmis)
Trying again, with master f08d0142afbcb45c12604988022bb3da18be1d84 compiled from source on Xubuntu 14.04: - Open Writer - File -> Open Remote File ... - Add Service -> Google Drive - log in - dialogue box: "General input/output error." (with the full stop) So it's not *crashing* ...
(In reply to David Gerard from comment #17) > Trying again, with master f08d0142afbcb45c12604988022bb3da18be1d84 compiled > from source on Xubuntu 14.04: > > - Open Writer > - File -> Open Remote File ... > - Add Service -> Google Drive > - log in > - dialogue box: "General input/output error." (with the full stop) > > So it's not *crashing* ... With master sources updated today, once I clicked "Add Service" button, the by default option is "Google Drive" and everything is disabled except "Help" and "Cancel" button. I noticed this on logs: warn:vcl.layout:3106:1:vcl/source/window/builder.cxx:1759: probably need to implement GtkCellRendererText or add a makeGtkCellRendererText function
>With master sources updated today, once I clicked "Add Service" button, the by default option is "Google Drive" and everything is disabled except "Help" and "Cancel" button. That's what you get if you compile without the --with-gdrive-client-secret and --with-gdrive-client-id - if you add those (either the ones in the TDF builds or get your own) it works, at least far enough to fail.
Daily masters are not Google Drive enabled, this one: <http://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@70-TDF/gdrivetest2/LibreOfficeDev_5.2.0.0.alpha0_Linux_x86-64_deb.tar.gz> It's a special version of master build created to check bug 98416. It probably fixes this bug as well, or the connect to Google Drive part anyway. Note that there's still bug 87938 (two-factor auth for gdrive not working) - so if you want to test, you have to disable two-factor authentication temporarily. At <http://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@70-TDF/gdrivetest2> rpms are available as well.
The originally reported crash might also be bug 96279 where the various password dialogs could end up modal to the window behind the file dialog even when shown over it, and the resulting stack of widgets was out of sync. The "⟳" likely put up the username/password dialog. Anyway, we're eol for 5-0 soon and its "all changed" in 5.1 onwards so I think this particular bug report is out of date now. If anyone can get 5.1 to crash in a similar fashion feel free to put me on cc on that new bug.
*** Bug 89947 has been marked as a duplicate of this bug. ***