Bug 88455 - Crash when using pivot table and two delete keys pressed on Data field
Summary: Crash when using pivot table and two delete keys pressed on Data field
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.3.5.2 release
Hardware: Other All
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.0.0 target:4.4.0 target:4.3.6
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-15 11:16 UTC by grofaty
Modified: 2015-04-14 03:31 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description grofaty 2015-01-15 11:16:40 UTC
Tested in LibreOffice 4.3.5.2 on Windows 7.

1. Type in text in fields:
A1: London
A2: Berlin
B1: 100
B2: 100
2. Mark fields A1:B2.
3. Data | Pivot Table | Create.
4. Select Source window opens. Click on OK to accept default.
5. Pivot Table Layout appears.
6. Click on "Data" member in "Column Fields" field.
7. Press Delete key twice and crash appears.

How it should work? No crash.

I know that above steps may look like crazy think to delete Data field. But when there are multiple data fields in Column Fields the only way to really quickly delete all the members is clicking on last member in this field and pressing Delete key several several several times or even quicker just press Delete and hold the key down.

P.S. Problem can also be reproduced without steps 1 and 2.
Comment 1 raal 2015-01-15 14:01:56 UTC
I can confirm with LO 4.3.5, win7
Comment 2 Commit Notification 2015-01-22 13:44:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=66df4d7d309ce237e4979d57b1069659ece1e3a5

Resolves: fdo#88455 delete in empty data field crashes

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2015-01-22 15:08:31 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b325c5c009c1a73345520c03ffbf03dc4600eff&h=libreoffice-4-4

Resolves: fdo#88455 delete in empty data field crashes

It will be available in 4.4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2015-01-22 15:09:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=38a2bda69b5052a72e1489f23b06dabf55062d83&h=libreoffice-4-3

Resolves: fdo#88455 delete in empty data field crashes

It will be available in 4.3.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2015-01-22 15:12:31 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-4-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c06f0d71e16ffe68836441d125a4c1eb50d5ccda&h=libreoffice-4-4-0

Resolves: fdo#88455 delete in empty data field crashes

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2015-01-23 20:20:03 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-4-3-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=44ee9731b6ac11699cb9066a8577aba32cab7ab9&h=libreoffice-4-3-6

Resolves: fdo#88455 delete in empty data field crashes

It will be available in 4.3.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 grofaty 2015-02-02 13:44:53 UTC
-1-
Tested using daily build: http://dev-builds.libreoffice.org/daily/libreoffice-4-4/Win-x86@42/2015-01-30_10.23.09/ - crash do not appear anymore, excellent. But it feels little bit strange that "Data" field is now allowed to be deleted, despite appearing in sheet after OK button is pressed. This looks like new bug introduced by this fix - so crash fixed, but "Data" field should not be allowed to be deleted.

-2-
I also found another crash related to Pivot Table. If you click on Available Fields fields and press Delete key. Very similar crash to the crash reported in my first post.
Tested: LibreOffice 4.3.5.2 and with above listed daily build.
Comment 8 grofaty 2015-02-03 07:46:34 UTC
Because of yesterday tests I am marking this bug report as REOPENED.
Comment 9 Caolán McNamara 2015-02-03 09:28:35 UTC
dunno why you reopened it after I pushed the follow up fixes.
Comment 10 grofaty 2015-02-03 14:22:03 UTC
@Caolán McNamara, I have reopened bug. I have found another very similar bug - in the same dialog, just another window, see my response from yesterday under "-2-" section. Should I open a new bug or something?
Comment 11 grofaty 2015-02-04 07:09:29 UTC
To reduce confusion, few minutes ago for "-2-" section I have opened a new bug report https://bugs.documentfoundation.org/show_bug.cgi?id=89108 to follow one problem per bug report. So this bug report can stay in closed state.