Steps to reproduce: 1 Start Calc 2 Input some Simplified Chinese in a cell 3 Select the characters 4 Click Tools->Language->Chinese Convertion->Simplified Chinese to traditional Chinese, and click OK 5 Click Edit->Undo or Undo on the toolbar 6 Calc crashes ps: Undo won't crashes the Calc when doing the tranditional Chinese convert to tranditional Chinese, or simplified Chinese convert to simplefied Chinese.
Reproduced with 4.4. 4.5 doesn't crash on undo, but the cell becomes empty. Win 7 Pro 64-bit, LibO Version: 4.4.0.3 Build ID: de093506bcdc5fafd9023ee680b8c60e3e0645d7 Locale: fi_FI Version: 4.5.0.0.alpha0+ Build ID: 99c00b090533da9818444be2831b8da0e713e5f9 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-02-04_06:38:53 Locale: fi_FI
Created attachment 114481 [details] OSX/LO 4.4.2.1 backtrace
Created attachment 114482 [details] Sample ODS
Still occurs for me with current 4.5 master Results from bibisect 43all: bac2489ff3b644bd046102e379bff5a6c6c469d9 is the first bad commit commit bac2489ff3b644bd046102e379bff5a6c6c469d9 Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com> Date: Fri Oct 18 02:48:35 2013 +0000 source-hash-621c1e491e56db5416da1c763aaff862e8ede67a commit 621c1e491e56db5416da1c763aaff862e8ede67a Author: Michael Meeks <michael.meeks@suse.com> AuthorDate: Tue Aug 20 12:45:34 2013 +0100 Commit: Fridrich Strba <fridrich@documentfoundation.org> CommitDate: Fri Aug 23 09:04:13 2013 +0000
This appears to have changed at the below commit. Adding Cc: to michael.meeks@collabora.com; Could you possibly take a look at this? Thanks (Unsure what the connection is other than that they both concern undo) commit e851ea0ed30e9bb95c273a29aeab7f48f606145f Author: Michael Meeks <michael.meeks@suse.com> Date: Thu Aug 22 17:45:18 2013 +0100 fdo#39484 - don't loose outlines while trying to undo formulae changes. Change-Id: Ib3b2bab5beffb8164a8cd2c0b4db4c97f427507e
Here are some details: 1. The problems introduced ~20 aug 2013 totally prevented the Chinese convertion from working. They have been fixed between 4.2.0.1 and 4.2.0.2 (dec 2013-jan 2014) 2. Meanwhile, another problem was introduced with commit 575e88da278f536ebfb6562dfd98f341240afec4 (author Kohei Yoshida <kohei.yoshida@collabora.com> 2014-02-18 02:57:01 (GMT)): fdo#75032: Handle note copying correctly. That commit fails to check the pointer argument p in void CopyCellNotesHandler::operator() ( size_t nRow, const ScPostIt* p ) The null pointer is passed there if the cell doesn't contain a note. That is the cause of this bug. But fixing that uncovers another problem here. If some cells that undergo the conversion do contain notes with them, then undoing the conversion works (given the zero-checking is enabled), but redoing crashes LO. That's because of a memory corruption in first undo in static void noncopyable_managed_element_block::overwrite_values(base_element_block& block, size_t pos, size_t len) called from multi_type_vector<_CellBlockFunc>::set_impl(size_type pos, size_type start_row, size_type block_index, const _T& value) This method overwrites a copy of ScPostIt, that later is used in redo. So, working on a better fix
Posted patch to gerrit: https://gerrit.libreoffice.org/16181
*** Bug 90741 has been marked as a duplicate of this bug. ***
Michael, Why have you marked Bug 90741 as a duplicate. How are the two related?
(In reply to Matthew Millar from comment #9) > Michael, > > Why have you marked Bug 90741 as a duplicate. > > How are the two related? See this message: http://lists.freedesktop.org/archives/libreoffice/2015-June/068742.html
Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit]
Still reproduciable with Version: 5.1.2.2 (x64) Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f CPU Threads: 2; OS Version: Windows 6.19; UI Render: default; Locale: zh-CN (zh_CN) Win10 x64.
*** This bug has been marked as a duplicate of bug 91995 ***