Bug 90741 - EDITING: Spreadsheet commented cell cut, paste, undo, redo, undo
Summary: EDITING: Spreadsheet commented cell cut, paste, undo, redo, undo
Status: RESOLVED DUPLICATE of bug 89226
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.1.2 release
Hardware: Other All
: high critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2015-04-20 10:42 UTC by Matthew Millar
Modified: 2015-12-17 08:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Millar 2015-04-20 10:42:18 UTC
Further to Bug 66340 (and using the attachment provide therein):

ISSUE
Cutting a cell with a comment and pasting into a cell without, then undoing (2*CTRL+Z), redoing (2*CTRL+Y), and undoing (2*CTRL+Z) causes crash.
Comment 1 raal 2015-04-20 13:17:49 UTC
Hello,
is it duplicate of bug 83192?
Comment 2 Matthew Millar 2015-04-20 13:50:33 UTC
It's similar to Bug 83192, except that the redo doesn't cause the crash, the second undo does.

I expect the two are related, so the dev who takes on either bug should be aware of the other because both can probably be corrected at the same time.
Comment 3 Matthew Millar 2015-04-20 13:58:24 UTC
If similar to Bug 88184 this crash tracks back to the same commit as mentioned Bug 88192, then this bug can be marked as a duplicate.

Though this Bug and Bug 88184 would need noting in Bug 83192 as needing to be reassessed upon resolution, because each of the steps to encounter the bug are different, so resolution of one may not resolve all three without being tweaked.
Comment 4 raal 2015-04-20 14:33:44 UTC
Reproducible with Version: 5.0.0.0.alpha0+
Build ID: 89f5c1516fd3cf96488d97f62065b1ae0bdb9efa
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-04-18_10:10:39
Locale: cs_CZ

No crash with LibreOffice 3.5.0  Build ID: d6cde02 -> regression

Bibisectrequest
https://wiki.documentfoundation.org/QA/HowToBibisect

Matthew, what's your version of LO?
Comment 5 Matthew Millar 2015-04-20 23:03:28 UTC
LO 4.4.1.2
Comment 6 Noel Grandin 2015-06-11 11:53:52 UTC
This is some kind of VclPtr related thing: The crash looks like:

(gdb) bt
#0  0x00002aaaab349267 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:55
#1  0x00002aaaab34aeca in __GI_abort () at abort.c:89
#2  0x00002aaab22d318c in SalAbort (rErrorText="Window ( N2sd10ShowWindowE ()) with live children destroyed:  17SystemChildWindow ()", bDumpCore=true)
    at /home/noel/libo3/vcl/unx/generic/plugadapt/salplug.cxx:311
#3  0x00002aaab20e82b9 in Application::Abort (rErrorText="Window ( N2sd10ShowWindowE ()) with live children destroyed:  17SystemChildWindow ()")
    at /home/noel/libo3/vcl/source/app/svapp.cxx:314
#4  0x00002aaab1b735fe in vcl::Window::dispose (this=0x27a6870) at /home/noel/libo3/vcl/source/window/window.cxx:272
#5  0x00002aaacfc7f6aa in sd::Window::dispose (this=0x27a6870) at /home/noel/libo3/sd/source/ui/view/sdwindow.cxx:109
#6  0x00002aaacf950a23 in sd::ShowWindow::dispose (this=0x27a6870) at /home/noel/libo3/sd/source/ui/slideshow/showwin.cxx:89
#7  0x00002aaab1d21a71 in OutputDevice::disposeOnce (this=0x27a6870) at /home/noel/libo3/vcl/source/outdev/outdev.cxx:203
#8  0x00002aaacf9755ec in VclPtr<sd::ShowWindow>::disposeAndClear (this=0x27df630) at /home/noel/libo3/include/vcl/vclptr.hxx:207
#9  0x00002aaacf960e83 in sd::SlideshowImpl::disposing (this=0x27df4c0) at /home/noel/libo3/sd/source/ui/slideshow/slideshowimpl.cxx:713
#10 0x00002aaaad7d994f in cppu::WeakComponentImplHelperBase::dispose (this=0x27df4c0) at /home/noel/libo3/cppuhelper/source/implbase.cxx:109
#11 0x00002aaacf978a81 in cppu::WeakComponentImplHelper2<com::sun::star::presentation::XSlideShowController, com::sun::star::container::XIndexAccess>::dispose (this=0x27df4c0)
    at /home/noel/libo3/include/cppuhelper/compbase2.hxx:60
#12 0x00002aaacf9570c0 in sd::SlideShow::end (this=0x21111a0) at /home/noel/libo3/sd/source/ui/slideshow/slideshow.cxx:681
#13 0x00002aaacf957f2c in non-virtual thunk to sd::SlideShow::end() () at /home/noel/libo3/sd/source/ui/slideshow/slideshow.cxx:651
#14 0x00002aaacf96959a in sd::SlideshowImpl::endPresentationHdl (this=0x27df4c0) at /home/noel/libo3/sd/source/ui/slideshow/slideshowimpl.cxx:1432
#15 0x00002aaacf969538 in sd::SlideshowImpl::LinkStubendPresentationHdl (instance=0x27df4c0, data=0x0) at /home/noel/libo3/sd/source/ui/slideshow/slideshowimpl.cxx:1427
#16 0x00002aaab1954aa3 in Link<void*, long>::Call (this=0x28acf10, data=0x0) at /home/noel/libo3/include/tools/link.hxx:127
#17 0x00002aaab1b9eacf in ImplHandleUserEvent (pSVEvent=0x28a3740) at /home/noel/libo3/vcl/source/window/winproc.cxx:2022
#18 0x00002aaab1b9bd30 in ImplWindowFrameProc (_pWindow=0x12f6690, nEvent=22, pEvent=0x28a3740) at /home/noel/libo3/vcl/source/window/winproc.cxx:2578
#19 0x00002aaab21dedbf in SalFrame::CallCallback (this=0x12f6f20, nEvent=22, pEvent=0x28a3740) at /home/noel/libo3/vcl/inc/salframe.hxx:244
#20 0x00002aaab21dd960 in SalGenericDisplay::DispatchInternalEvent (this=0x12723f0) at /home/noel/libo3/vcl/generic/app/gendisp.cxx:90
#21 0x00002aaac28eaea4 in GtkData::userEventFn (data=0x642820) at /home/noel/libo3/vcl/unx/gtk/app/gtkdata.cxx:942
#22 0x00002aaac28eafcb in call_userEventFn (data=0x642820) at /home/noel/libo3/vcl/unx/gtk/app/gtkdata.cxx:952
#23 0x00002aaab858fb4d in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#24 0x00002aaab858ff20 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#25 0x00002aaab858ffcc in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#26 0x00002aaac28e9863 in GtkData::Yield (this=0x642820, bWait=true, bHandleAllCurrentEvents=false) at /home/noel/libo3/vcl/unx/gtk/app/gtkdata.cxx:577
#27 0x00002aaac28ef547 in GtkInstance::Yield (this=0x6426c0, bWait=true, bHandleAllCurrentEvents=false) at /home/noel/libo3/vcl/unx/gtk/app/gtkinst.cxx:398
#28 0x00002aaab20ed3f9 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/noel/libo3/vcl/source/app/svapp.cxx:353
#29 0x00002aaab20e8470 in Application::Yield () at /home/noel/libo3/vcl/source/app/svapp.cxx:382
#30 0x00002aaab20e843c in Application::Execute () at /home/noel/libo3/vcl/source/app/svapp.cxx:336
#31 0x00002aaaaafbb4f1 in desktop::Desktop::Main (this=0x7fffffff58b8) at /home/noel/libo3/desktop/source/app/app.cxx:1605
#32 0x00002aaab20f39d4 in ImplSVMain () at /home/noel/libo3/vcl/source/app/svmain.cxx:162
#33 0x00002aaab20f5158 in SVMain () at /home/noel/libo3/vcl/source/app/svmain.cxx:196
#34 0x00002aaaab0166a5 in soffice_main () at /home/noel/libo3/desktop/source/app/sofficemain.cxx:96
#35 0x000000000040092d in sal_main () at /home/noel/libo3/desktop/source/app/main.c:48
#36 0x0000000000400907 in main (argc=4, argv=0x7fffffff5a68) at /home/noel/libo3/desktop/source/app/main.c:47
(gdb) shell gedit sd/source/ui/slideshow/slideshowimpl.cxx
Comment 7 Michael Meeks 2015-06-13 14:58:20 UTC
Noel - your trace looks like it is VclPtr related and for an impress, not calc bug =) and there was no VclPtr in 4.4 =) Instead I suspect this is a duplicate of the existing undo/redo with comments regression that Mike is working on - since 4.4.

*** This bug has been marked as a duplicate of bug 89226 ***
Comment 8 Robinson Tryon (qubit) 2015-12-17 08:55:04 UTC
Migrating Whiteboard tags to Keywords: (bibisectRequest)
[NinjaEdit]