Bug 89269 - LibreOffice notifies for macro's in excel (.xls) files, that actually are only empty libraries
Summary: LibreOffice notifies for macro's in excel (.xls) files, that actually are onl...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-09 18:43 UTC by Kurt Roeckx
Modified: 2016-02-22 20:53 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Roeckx 2015-02-09 18:43:34 UTC
I have an .xls file that always gives a warning that it contains macro's when opening it.  The file doesn't actually contain any macro, but it contains a library/module with no macro's in it.  (Excel also gives a warning opening that file.)

If you go to Tools->Macro->Organize Macro's->Libreoffice basic, under the document itself you see two items.  If you then go to organizer->libraries and select the document you can remove the 2nd item, but not the first ("standard"?) one.

However, if you save that and reopen the file and go check everything is back as it was, as if you didn't remove the library/module.

If you open it in excel and remove the module there both excel and libreoffice don't give a warning anymore when opening it.  However if you go and look at it again, it shows the standard one again in the dialog that you can't remove.  If you save that file using libreoffice the next time you will get the warning again.

It also seems to be possible to have .xls files that does not contain anything related to macro's.  If you go and look at those it doesn't show anything.  If you save them and reopen them it doesn't give you a warning.

If I try to add a library to a file that doesn't have anything related to macro's and save that and then reopen it, it doesn't seem to be saving that library/module.  It also doesn't seem to add the standard one.

As a workaround for all those problems I would be happy with the warning going away if it doesn't actually contain any macro.


Kurt
Comment 1 Kurt Roeckx 2015-02-09 19:23:55 UTC
(In reply to kurt from comment #0)
> As a workaround for all those problems I would be happy with the warning
> going away if it doesn't actually contain any macro.

I guess I would be happy, but others using excel wouldn't be happy.

Also, I think I never saw "Module1" mentioned in libreoffice while excel does show that.

I'm guessing that excel doesn't have the concept of libraries and libreoffice does and that this is causing various problems with opening and saving such files.  Maybe it's an option to create a library for the module when opening and saving the modules instead of skipping the library?  (I guess that skipping will only work when module names in different libraries aren't the same.)


Kurt
Comment 2 Cor Nouws 2015-02-09 19:56:05 UTC
Hi Kurt,

Thanks for filing - I clarify the summary a bit.

Just for your info: I've solved these issues by removing some files/data from the zip-package (of course in a file converted from a MS Binary file).

Cheers,
Cor
Comment 3 m_a_riosv 2015-02-09 21:01:58 UTC
I think this is a duplicate of:
https://bugs.documentfoundation.org/show_bug.cgi?id=86928

Please if you are not agree, reopen it.

*** This bug has been marked as a duplicate of bug 86928 ***
Comment 4 Kurt Roeckx 2015-02-09 21:14:42 UTC
I have to both agree and disagree.  Yes, it's also about the warning about non-existing macro's.  But it's also about other issues, and so I find the summary at least misleading and I'm afraid that you're just going to close it if you don't give the warning any more instead of fixing the underlying problems.
Comment 5 Cor Nouws 2015-02-09 21:28:05 UTC
(In reply to Kurt Roeckx from comment #4)

> ...  instead of fixing the underlying problems.

What problems do you mean?

(Excel/MS Office knows libraries too, just to mention one thing)
Comment 6 Kurt Roeckx 2015-02-09 21:42:05 UTC
So let me repeat the issues:
- If you remove the library in libreoffice, it still saves it with the library
- If you remove the module in excel, open and save it with libreoffice it adds the library again (probably same issue as the one above)
- It doesn't actually show the name of the module
- You can't remove all traces of the macros
Comment 7 QA Administrators 2016-02-21 08:36:15 UTC
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

   Test to see if the bug is still present on a currently supported version of LibreOffice 
   (5.0.5 or 5.1.0)  https://www.libreoffice.org/download/

   If the bug is present, please leave a comment that includes the version of LibreOffice and 
   your operating system, and any changes you see in the bug behavior
 
   If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave 
   a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

   Update the version field
   Reply via email (please reply directly on the bug tracker)
   Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
   appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword


Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2016-02-21
Comment 8 Kurt Roeckx 2016-02-22 17:36:24 UTC
At least all the issues I care about seem to be fixed between 5.0 and 5.1
Comment 9 Cor Nouws 2016-02-22 20:53:57 UTC
(In reply to Kurt Roeckx from comment #8)
> At least all the issues I care about seem to be fixed between 5.0 and 5.1

Thanks for reporting! Then we can close this as WorksForMe.
Cor