After Writer’s status bar was updated to drop the slash in bug 80617 comment 16 (thanks a bunch, Samuel!), the other apps still have a slash (Calc shows “Sheet N / N” and Impress/Draw “Page N / N”). We should update those messages to be consistent with Writer’s.
Thanks in advance!
Win 7 Pro 64-bit Version: 18.104.22.168.alpha0+
Build ID: ca7f62c8262662c8f58a3fa3b298623f25b55eaa
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-02-26_22:43:44
I'd like to work on this bug from now, as a part of GSoC Easy Hacks.
In case anyone knows in which file should I look for at Impress or Calc, it can save some time for me, because I am new to LibreOffice.
dobragab, thanks a lot for having a look at this!
Not being a *true* developer myself, I can refer you to bug 64290 comment 6, which dealt with a very, very similar enhancement.
Please ask the developers list or the IRC channel if you get stuck.
dobragab: For Calc, have a look at sc/source/ui/view/cellsh.cxx , search for STR_TABLE. You want to change the STR_TABLE in sc/source/ui/src/globstr.src to have a kind of "Sheet %1 of %2" and adapt the code in cellsh.cxx the same way as in http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b4e4ccf8d571fd6f6ee538c4e406b07fc810e2d
For Draw/Impress, you wrote me that you have some proof-of-concept patch, but that you have some issues with that - best if you can push the patch to gerrit, and we can sort out the missing pieces there as part of the review :-)
Thanks for working on this!
Submitted a patch: https://gerrit.libreoffice.org/#/c/14797/
Fixed in both Calc and Draw/Impress, text is also able to be localized.
(Note: I changed some little code formatting at one point by accident.)
Uploaded final patch. Successfully built, waiting for review.
Dobra Gabor committed a patch related to this issue.
It has been pushed to "master":
tdf#89641 Page numbering in Calc and Draw/Impress
It will be available in 5.0.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Migrating Whiteboard tags to Keywords: (EasyHack TopicUi SkillCpp DifficultyInteresting )
Remove LibreOffice Dev List from CC on EasyHacks
(curtailing excessive email to list)