Bug 90150 - Page numbering in the status bar should change sooner with a certain proportion of the next page
Summary: Page numbering in the status bar should change sooner with a certain proporti...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low enhancement
Assignee: Jim Raykowski
URL:
Whiteboard: target:5.0.1 target:7.5.0 inReleaseNo...
Keywords:
Depends on:
Blocks: Statusbar
  Show dependency treegraph
 
Reported: 2015-03-21 21:04 UTC by MassinissaHamidi
Modified: 2024-05-03 13:35 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
demo of status bar page number enhancement (5.61 MB, video/x-matroska)
2022-03-29 05:33 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MassinissaHamidi 2015-03-21 21:04:30 UTC
Hi,

the page number shown in the status bar, when I scroll up or down, remains unchanged even if the entire previous page is not visible on the screen. The page number changes at the intersection of the different pages which may cause confusion.

+ Ubuntu 14.04 LTS - 32-bit
+ LibreOffice Version: 4.5.0.0.alpha0+

steps to reproduce:

- create a document with at least 2 pages;
- scroll down to the next page keeping the cursor in the current page
(same behavior when scrolling up);
- check the page number shown in the status bar when reaching the intersection of two pages.

It would be preferable, instead, that this number changes when a certain proportion of the next page is reached.

N.B. This bug appear in the bug tracker of openOffice id#80672.

thanks.
Comment 1 A (Andy) 2015-03-22 08:34:09 UTC
I agree this could be changed/improved.

Reproducible with LO 4.4.1.2, Win 8.1
Changed the importance in accordance with the Bug Priority Triage Flowchart
Comment 2 Commit Notification 2015-05-16 04:16:11 UTC
massinissaHamidi committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1622b67e4b2bc8ecc5dd3ededc0a6e5adb936a6e

tdf#90150 : Page numbering in the status bar which may cause confusion

It will be available in 5.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Mike §chinagl 2015-05-21 15:35:10 UTC
This bug fix is mentioned in the release notes of the coming LibreOffice 5.0 (see release notes https://wiki.documentfoundation.org/ReleaseNotes/5.0). Therefore it would be wonderful if this feature really worked well, otherwise it should not be mentioned in the release notes. 
In the notes it reads:

Another issue inherited from OpenOffice.org—which caused Writer’s status bar to display the incorrect page number when scrolling—has been fixed in LibreOffice. Writer will now update the page indicator when less than the 43% of a page is visible on-screen. tdf#90150 i#80672 Thanks to: Hamidi Massinissa.
Comment 4 Commit Notification 2015-08-12 06:20:55 UTC
Jan Holesovsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0409f83a5a4f9f86fa69a9431ce5aa07be427455

tdf#92305: Revert "tdf#90150 : Page numbering in the status bar ..."

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Jan Holesovsky 2015-08-12 06:44:05 UTC
MassinissaHamidi: I am very sorry, but I had to revert your patch.  It was causing a very visible bug 92305.

The change is problematic from the user experience point of view - with that, the user is never sure what page is he/she looking at exactly.

The better solution would be to extend the status bar indicator to allow showing the entire range of pages that are visible; like:

* only one page visible: "Page 3 of 8."
* more pages visible: "Pages 3-5 of 8."

The code to do that is SwView::GetPageStr() in sw/source/uibase/uiview/view2.cxx.  You'll also need to add the plural version of the string in sw/source/ui/shells/shells.src, search for STR_PAGE_COUNT and STR_PAGE_COUNT_CUSTOM.

Thank you in advance for your help!
Comment 6 Commit Notification 2015-08-12 12:55:19 UTC Comment hidden (obsolete)
Comment 7 Commit Notification 2015-08-15 22:21:03 UTC Comment hidden (obsolete)
Comment 8 Thomas Lendo 2019-07-07 18:40:21 UTC
The last changes were made in the 5.0 release cycle. Is something unfinished or can we close this bug?
Comment 9 sdc.blanco 2020-02-07 10:36:35 UTC
(In reply to Thomas Lendo from comment #8)
> The last changes were made in the 5.0 release cycle. Is something unfinished
> or can we close this bug?
From reading the record here, the OP is more like an "enhancement" request, than a bug report.  The OP and comment 1 did not like how the statusbar showed page numbers (in LO 4.4). A patch was made, but was later reverted (because it created other problems).  Nothing has happened (here) since. 

(fwiw, I do not experience confusion with page numbers in statusbar -- as long as "restart page numbering" is not used.  Close as WFM? or INSUFFICIENTDATA? or change to "enhancement"?
Comment 10 sdc.blanco 2020-02-07 11:48:50 UTC
(In reply to sdc.blanco from comment #9)
> (fwiw, I do not experience confusion with page numbers in statusbar 
Sorry.  Now I "see" the problem.  

1.  Statusbar shows "Page x of y"
2.  Page x+1 of y is only shown when the "top of the page" is at the very top of the window.
3.  The OP wants the page number in the statusbar to change earlier.

The "problem"  is particularly visible when:

     a. document is positioned with bottom part of a page at the top of the window.  (statusbar shows pagenumber of the page whose "bottom" is still visible at top of window)  (the effect does not depend on the window height or zoom size)

     b.  zoom in to 20% for a multipage document (especially with tall window) and scroll down. 

Comment 5 gives a code pointer for how to show multiple page numbers. 

Is this a "bug"?  Would suggest changing to "enhancement" request.
Comment 11 Timur 2021-03-23 17:36:45 UTC Comment hidden (off-topic)
Comment 12 Timur 2021-03-25 10:08:02 UTC Comment hidden (off-topic)
Comment 13 Jim Raykowski 2022-03-29 05:33:43 UTC
Created attachment 179177 [details]
demo of status bar page number enhancement

Following Jan's formatting advice in comment 5

https://gerrit.libreoffice.org/c/core/+/132252
Comment 14 sdc.blanco 2022-03-29 12:19:15 UTC
(In reply to Jim Raykowski from comment #13)
> demo of status bar page number enhancement
Wow!  Elegant and sophisticated.

One naive reaction. 

For two pages:  Pages 3 and 4 of 23
Over two pages  Pages 4-6 of 23

Reason: "-" would then clearly indicate a range (i.e., more than two pages), while "and" would quickly indicate that only two pages are involved (without having to look at the numbers -- which would be necessary in the current version).
Comment 15 Jim Raykowski 2022-03-29 20:34:21 UTC
(In reply to sdc.blanco from comment #14)
> For two pages:  Pages 3 and 4 of 23
> Over two pages  Pages 4-6 of 23

Seth, +1, thanks! Done in patchset 2.
Comment 16 Commit Notification 2022-08-02 16:44:47 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/189b65b02fe1f3ce6be5b7637cc59443561855e4

tdf#90150 Improve Writer page number display in the status bar

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Stéphane Guillou (stragu) 2023-01-03 13:08:38 UTC
Verified the range numbering, including when more than 2 pages are shown at once, in:

Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In release notes:

https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.5&type=revision&diff=606784&oldid=605773

One small drawback is that we lost the helpful hint of which page was being edited. In previous versions, writing text would make the statusbar page number switch to the one being edited. Not sure how useful it was to users, and how it could be brought back elegantly... Just a thought.

Thanks everyone!