Bug Hunting Session
Bug 92311 - rise the limit of auto complete entries
Summary: rise the limit of auto complete entries
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:5.1.0
Keywords:
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2015-06-24 14:40 UTC by Shantanu
Modified: 2016-10-20 13:26 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Marathi language word list (639.43 KB, application/x-rar)
2016-10-20 13:26 UTC, Shantanu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shantanu 2015-06-24 14:40:10 UTC
The maximum number of allowed words in an auto complete list is only 10,000 This number should be increased to 50,000. This should work without any issues on modern hardware.
Comment 1 Julien Nabet 2015-06-24 16:55:44 UTC
On which env are you and which LO version do you use?
Comment 2 Shantanu 2015-06-24 17:07:51 UTC
This is a very old bug that applies to the latest version of LibreOffice (4.4.3)
Comment 3 tommy27 2015-06-25 05:26:11 UTC
I agree with shantanu, expecially considering the fact that a similar thing has been done in the past about autocorrect entries (they had a limit of 65535 from OOo time which has been expanded to ore than 4 millions... see Bug 48729)

moreover I use a text autocomplete software called PhraseExpress that can easily handle more than 50000 text snippets, so LibO could be easily do the same

@shantanu
can you tell if this issue is limited to LibO or affects OOo/AOO as well?
I suspect that it's an inherited from OOo limitation

where did you find documentation about the 10000 limit? could you provide a link?
Comment 4 tommy27 2015-06-25 05:28:27 UTC
ooops...  I didn't notice the link to the Apache bugtracker that confirms the fact the issue is inherited from OOo and confirmed by other users

so I adjust the version and status fields.

anyway, please tell where did you find that the limit is 10000.
Comment 5 Julien Nabet 2015-06-25 05:49:00 UTC
Here are some code pointers to confirm:
http://opengrok.libreoffice.org/xref/core/editeng/source/misc/swafopt.cxx#78
http://opengrok.libreoffice.org/xref/core/sw/inc/acmplwrd.hxx#36
According to the first one, the limit could be to 1000 only.
Comment 6 tommy27 2015-06-25 12:27:15 UTC
I'm not a developer but it seems it could be a trivial hack to change the 1000 number to something bigger

anyway I suspect you cannot set a number higher that 65K if you don't change int16->int32 like Tomaz Vajngerl did in Bug 48729 to rise the number of autocorrect entries from 65K to 4M
Comment 7 Commit Notification 2015-11-09 11:21:16 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=53352be12cb6a191934b8107559ea47171868718

Resolves: tdf#92311 raise auto correct entry limit to unsigned short max

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 tommy27 2015-11-09 11:40:07 UTC
@Caolan

you earned 5 bucks!!!   :-)

https://freedomsponsors.org/issue/741/rise-the-limit-of-auto-complete-entries
Comment 9 tommy27 2015-11-09 11:41:34 UTC
new limit is 65535
I think shantanu should be happy about it!!!
Comment 10 Shantanu 2015-11-09 11:46:15 UTC
1) Is it possible to increase the limit from 65K to 4M as done in case of Bug 48729 mentioned above?

2) Is it possible to save autocomplete list as requested in Bug 86872 ?
Comment 11 tommy27 2015-11-09 12:52:10 UTC
maybe it's possible if the code will be modified from 16bit to 32bit.

anyway you asked for 5000 and now you got 65535, so you should be happy about it.
remember to pay the reward you promised on freedomsponsors  :-)
Comment 12 Shantanu 2016-10-20 04:28:29 UTC
I had asked for 50,000 (and not 5,000) because I did not know the possibilities. If the auto-correct limit can be enhanced to 4 million - so can auto-complete. I have changed the reward from 5 to 50 dollars on freedomsponsors.
Comment 13 tommy27 2016-10-20 05:10:17 UTC
ok, setting it back to NEW.
Comment 14 Bartosz 2016-10-20 12:24:30 UTC
@shantanu Could you please attach some document with big numbers (65,000 ) of words for autocomplete?
I would like to use this document for testing purpose.
Comment 15 Shantanu 2016-10-20 13:26:50 UTC
Created attachment 128096 [details]
Marathi language word list

You can find english word list here...

https://github.com/dwyl/english-words/blob/master/words3.txt

I am attaching my Marathi word list as second file to test.