Bug 92311 - raise the limit of collected entries for Word Completion
Summary: raise the limit of collected entries for Word Completion
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Baole Fang
URL:
Whiteboard: target:5.1.0 target:24.2.0
Keywords:
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2015-06-24 14:40 UTC by Shantanu
Modified: 2023-07-06 16:08 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Marathi language word list (639.43 KB, application/x-rar)
2016-10-20 13:26 UTC, Shantanu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shantanu 2015-06-24 14:40:10 UTC
The maximum number of allowed words in an auto complete list is only 10,000 This number should be increased to 50,000. This should work without any issues on modern hardware.
Comment 1 Julien Nabet 2015-06-24 16:55:44 UTC
On which env are you and which LO version do you use?
Comment 2 Shantanu 2015-06-24 17:07:51 UTC
This is a very old bug that applies to the latest version of LibreOffice (4.4.3)
Comment 3 tommy27 2015-06-25 05:26:11 UTC
I agree with shantanu, expecially considering the fact that a similar thing has been done in the past about autocorrect entries (they had a limit of 65535 from OOo time which has been expanded to ore than 4 millions... see Bug 48729)

moreover I use a text autocomplete software called PhraseExpress that can easily handle more than 50000 text snippets, so LibO could be easily do the same

@shantanu
can you tell if this issue is limited to LibO or affects OOo/AOO as well?
I suspect that it's an inherited from OOo limitation

where did you find documentation about the 10000 limit? could you provide a link?
Comment 4 tommy27 2015-06-25 05:28:27 UTC
ooops...  I didn't notice the link to the Apache bugtracker that confirms the fact the issue is inherited from OOo and confirmed by other users

so I adjust the version and status fields.

anyway, please tell where did you find that the limit is 10000.
Comment 5 Julien Nabet 2015-06-25 05:49:00 UTC
Here are some code pointers to confirm:
http://opengrok.libreoffice.org/xref/core/editeng/source/misc/swafopt.cxx#78
http://opengrok.libreoffice.org/xref/core/sw/inc/acmplwrd.hxx#36
According to the first one, the limit could be to 1000 only.
Comment 6 tommy27 2015-06-25 12:27:15 UTC
I'm not a developer but it seems it could be a trivial hack to change the 1000 number to something bigger

anyway I suspect you cannot set a number higher that 65K if you don't change int16->int32 like Tomaz Vajngerl did in Bug 48729 to rise the number of autocorrect entries from 65K to 4M
Comment 7 Commit Notification 2015-11-09 11:21:16 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=53352be12cb6a191934b8107559ea47171868718

Resolves: tdf#92311 raise auto correct entry limit to unsigned short max

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 tommy27 2015-11-09 11:40:07 UTC
@Caolan

you earned 5 bucks!!!   :-)

https://freedomsponsors.org/issue/741/rise-the-limit-of-auto-complete-entries
Comment 9 tommy27 2015-11-09 11:41:34 UTC
new limit is 65535
I think shantanu should be happy about it!!!
Comment 10 Shantanu 2015-11-09 11:46:15 UTC
1) Is it possible to increase the limit from 65K to 4M as done in case of Bug 48729 mentioned above?

2) Is it possible to save autocomplete list as requested in Bug 86872 ?
Comment 11 tommy27 2015-11-09 12:52:10 UTC
maybe it's possible if the code will be modified from 16bit to 32bit.

anyway you asked for 5000 and now you got 65535, so you should be happy about it.
remember to pay the reward you promised on freedomsponsors  :-)
Comment 12 Shantanu 2016-10-20 04:28:29 UTC
I had asked for 50,000 (and not 5,000) because I did not know the possibilities. If the auto-correct limit can be enhanced to 4 million - so can auto-complete. I have changed the reward from 5 to 50 dollars on freedomsponsors.
Comment 13 tommy27 2016-10-20 05:10:17 UTC
ok, setting it back to NEW.
Comment 14 Bartosz 2016-10-20 12:24:30 UTC
@shantanu Could you please attach some document with big numbers (65,000 ) of words for autocomplete?
I would like to use this document for testing purpose.
Comment 15 Shantanu 2016-10-20 13:26:50 UTC
Created attachment 128096 [details]
Marathi language word list

You can find english word list here...

https://github.com/dwyl/english-words/blob/master/words3.txt

I am attaching my Marathi word list as second file to test.
Comment 16 Baole Fang 2023-06-23 16:07:16 UTC
To look into this ticket, I need a detailed procedure to reproduce what you are asking because I'm not familiar with word completion.

I also need a list with 10000 entries, 50000 entries and 4M entries to test.
Comment 17 Shantanu 2023-06-24 03:28:01 UTC
Word completion helps you finish writing words faster. You might have seen it in gmail.

https://help.libreoffice.org/latest/en-US/text/shared/01/06040600.html

Half a million words can be found here...

https://github.com/dwyl/english-words/blob/master/words.txt

1/4th million Marathi words can be found in the attachment.

If you believe that a limit of 4 million is unnecessary, you can lower it to your preference. However, in my opinion, 65,000 is inadequate.
Comment 18 Baole Fang 2023-06-26 02:08:44 UTC
Please
Comment 19 Baole Fang 2023-06-26 02:09:31 UTC
I‘ve submitted a patch:
https://gerrit.libreoffice.org/c/core/+/153571
Comment 20 Baole Fang 2023-06-26 19:48:03 UTC
(In reply to Shantanu from comment #12)
> I had asked for 50,000 (and not 5,000) because I did not know the
> possibilities. If the auto-correct limit can be enhanced to 4 million - so
> can auto-complete. I have changed the reward from 5 to 50 dollars on
> freedomsponsors.

The limit should have been raised to 4 billion. I'm wondering whether the reward is still available.

https://gerrit.libreoffice.org/c/core/+/153571
Comment 21 Shantanu 2023-06-27 03:40:32 UTC
Unfortunately freedomsponsors site is closed down and so is the reward. 
But $50 reward is available for closing another bug.
https://bugs.documentfoundation.org/show_bug.cgi?id=117100
Comment 22 Commit Notification 2023-07-04 09:17:42 UTC
Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/254161f9dd2b7b3e416c54dfeb8e8c6e81cd7dcd

tdf#92311: increase word completion limit

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Julien Nabet 2023-07-04 10:12:19 UTC
(In reply to Shantanu from comment #21)
> Unfortunately freedomsponsors site is closed down and so is the reward. 
> But $50 reward is available for closing another bug.
> https://bugs.documentfoundation.org/show_bug.cgi?id=117100

Nothing prevents you from finding another way to pay the reward to Baole (and also Caolán) by using another website, "bountysource" for example since it's the website used for the other bugtracker you quoted.
Comment 24 Shantanu 2023-07-04 11:35:24 UTC
I reported the bug first to open office team on 2013-02-03. The bug was reported here in 2015 because at that time I had a use case that really needed this functionality. I found some other alternatives during the last decade. Such offers are not open ended valid for life time.
Let's take an example of the other bug that I mentioned for bounty. That was "introduced" in the version 5.3 as per the fifth comment. If libreoffice fix it after 10 or 20 years, do you expect me (or my legal heir in case I am dead) to pay the bounty?
Comment 25 Julien Nabet 2023-07-04 11:46:00 UTC
(In reply to Shantanu from comment #24)
> I reported the bug first to open office team on 2013-02-03. The bug was
> reported here in 2015 because at that time I had a use case that really
> needed this functionality. I found some other alternatives during the last
> decade. Such offers are not open ended valid for life time.
> Let's take an example of the other bug that I mentioned for bounty. That was
> "introduced" in the version 5.3 as per the fifth comment. If libreoffice fix
> it after 10 or 20 years, do you expect me (or my legal heir in case I am
> dead) to pay the bounty?

There’s no delay in the bug bounty or I missed it, so yes i would have expected you’d pay for it.
No I don’t expect your heir should pay since the bounty is your decision not his or hers.
If you don’t want to pay, at least don’t tease people with another bug to fix with a bounty or perhaps find a website where delay (1 year, 1 month, whatever) is explicit so people will be know.
Comment 26 Shantanu 2023-07-06 03:22:19 UTC
I contacted them by email and asked for the best way to pay. Baole Fang did not reply. Caolán replied, "That's ok, keep it for another good cause."
Comment 27 Baole Fang 2023-07-06 16:08:20 UTC
That's fine. You can keep it.