Bug 93042 - autocorrect replacement table dialog doesn't remember size change
Summary: autocorrect replacement table dialog doesn't remember size change
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.4.0.0.alpha0+ Master
Hardware: Other All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2015-07-31 04:50 UTC by tommy27
Modified: 2017-09-22 05:27 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tommy27 2015-07-31 04:50:39 UTC
the autocorrect replacement table become a resizable Windows since LibO 4.4.0 thanks to Caolan McNamara's job with new widget layout (see Bug 67040)

a further improvement would be to make LibO remember the last size used when you close the table and reopen it later.

actually LibO remembers the "position" of the dialog but not the "size" which is reset to default everytime you reload it.

I work with a large screen in portrait mode and I'd like to keep that dialog always vertically enlarged.

to reproduce the issue:
- click on Tools/AutoCorrect/AutoCorrect Options
- move the dialog and enlarge it
- close it 
- reload it

position is remembered, size is not.
issue is still present in current LibO 4.4.5.2 release and recent 5.1.0.0 alpha daily builds.
Comment 1 Adolfo Jayme 2015-08-01 09:28:59 UTC
enhancement request
Comment 2 tommy27 2015-10-10 06:32:22 UTC
rationale for this enhancement request is that after Bug 64652 fix by Andras Timar you can actually have very long autocorrect replacements so the stardard size of the table is not enough to display most of them and you have to enlarge it.

if the table could remember the last used size, the user could adjust it to the desidered width/height without have to resize it everytime
Comment 3 tommy27 2016-10-05 07:57:31 UTC
still present in 5.3.0.0.alpha0+
Build ID: 4c70a1a6666a079872b8f1966bd398e924dc1d1a
CPU Threads: 8; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-09-22_06:54:24
Locale: it-IT (it_IT); Calc: CL
Comment 4 Caolán McNamara 2016-10-05 09:58:20 UTC
One reason this is potentially a bad idea is what to do when someone redesigns a dialog. How to distinguish that the "last used size" was the previous optimal size and so now that the new optimal size is different so ignore the last used size and use the new optimal size.
Comment 5 tommy27 2016-10-06 04:27:29 UTC
sorry, I don't understand what you said.

actually the autocorrect replacement table has a 566x522 pixels default size.
you can manually enlarge it's width and/or height to whatever you like.

that size change is not remembered when you close it and reload it, whilst the position in the screen is.

the enhancement that I asked for is to remember last used size as well.

so if you enlarge it to 800x600, it should keep that size the next time you load it.

if you change it again, let's say 1200x800, next time you load it it should keep that size as well.

and finally if you wanna shrink it down to default 566x522, at reload it should keep that size.

that is what i called "last used size" which is basically the same about "last used position"... there's something in the code that keeps memory of the x,y coordinates of the panel and reloads it in the same position where it was last time you opened.

I hope I explained better what the enhancement request is about.
Looking forward for your feedback.
thanks, Tommy
Comment 6 Caolán McNamara 2016-10-06 07:58:50 UTC
If the dialogs remember their size when manually resized and then restore that size the next time they are opened, then later if the user upgrades to a new version of libreoffice where the dialogs are redesigned in some way (or in the same version where there is a different layout for a different mode, e.g. extra widgets or different layout for CTL/CJK) then the restored size may be very inappropriate.

I'm just flagging that I don't see this that the simpliest approach of just saving the size and restoring it on next use would go smoothly
Comment 7 tommy27 2016-10-06 08:06:36 UTC
Ok, thanks 4 the clarification.
this is a minor enhancement request so I can live even without it if it's too cumbersome to implement.
Comment 8 tommy27 2016-12-12 09:47:39 UTC
@Caolán McNamara

what about remembering "last used size" just for the current session?

in that way once LibO is closed and relaunched the replacement table would be again restored to the default value and this would prevent issues if the layout is changed among versions.
Comment 9 tommy27 2017-06-06 11:40:29 UTC
@ Caolán McNamara 

a polite ping about my latest request.
what if the "remind last used size" would be limited just to current LibO session.

after a new reboot the size could be resetted to the default one.