Bug 93066 - Start Center non-app accelerators
Summary: Start Center non-app accelerators
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-01 17:17 UTC by Yousuf Philips (jay) (retired)
Modified: 2015-08-02 21:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-08-01 17:17:47 UTC
Now that the app accelerators were changed in bug 91776, it would be useful to change the non-app accelerators as well. The non-app entries are as follows.

O_pen File
O_pen Remote File
R_ecent Files
Te_mplates
Hel_p
Ex_tensions

And i think we can change the following ones.

Open Remote F_ile
T_emplates
H_elp
E_xtensions
Comment 1 V Stuart Foote 2015-08-01 19:56:40 UTC
@Jay,

No the only one that should be changed is the new "_Open Remote File" which conflicts with "_Open File"

The main menu has
~File
~Tools
~Help

The rest of the .UI based accelerators (post bug 91776) are

_Recent Files
T_emplates
_Writer Document
_Calc Spreadsheet
_Impress Presentation
_Draw Drawing
_Math Formula
_Base Database

He_lp
E_xtension

Notice that in your suggestion you would be duplicating accelerators for Templates and Help, as well as Open File and Open Remote File. That is not good UI/UX, and bug 91776 was mainly to fix the duplicate use of "r" as an accelerator.
Comment 2 Adolfo Jayme Barrientos 2015-08-02 09:22:33 UTC
(In reply to Yousuf (Jay) Philips from comment #0)
> Now that the app accelerators were changed in bug 91776, it would be useful
> to change the non-app accelerators as well.

You have not provided any rationales for arbitraringly change the working accelerators we have currently.
 
> O_pen File
> O_pen Remote File
> R_ecent Files
> Te_mplates
> Hel_p
> Ex_tensions

Never, EVER, use lowercase “p” as accelerators (nor g, j, q, y). The descenders conflict with the underline.

(In reply to V Stuart Foote from comment #1)
> No the only one that should be changed is the new "_Open Remote File" which
> conflicts with "_Open File"

Not really, actually, since “Open Remote File” should not exist in the first place; that button should be merged with “Open File” by using a drop-down menu.
 
> Notice that in your suggestion you would be duplicating accelerators for
> Templates and Help, as well as Open File and Open Remote File. That is not
> good UI/UX, and bug 91776 was mainly to fix the duplicate use of "r" as an
> accelerator.

+1
Comment 3 Yousuf Philips (jay) (retired) 2015-08-02 17:33:42 UTC
(In reply to V Stuart Foote from comment #1)
> No the only one that should be changed is the new "_Open Remote File" which
> conflicts with "_Open File"
> 
> The main menu has
> ~File
> ~Tools
> ~Help
...
> Notice that in your suggestion you would be duplicating accelerators for
> Templates and Help, as well as Open File and Open Remote File. That is not
> good UI/UX, and bug 91776 was mainly to fix the duplicate use of "r" as an
> accelerator.

Accelerators for the main menu dont have to do with accelerators for the start center, so there isnt any duplication there. Or am i mistaken about this, because without pressing Alt you cant get to menu accelerators.

(In reply to Adolfo Jayme from comment #2)
> > O_pen File
> > O_pen Remote File
> > R_ecent Files
> > Te_mplates
> > Hel_p
> > Ex_tensions
> 
> Never, EVER, use lowercase “p” as accelerators (nor g, j, q, y). The
> descenders conflict with the underline.

If you had looked closely, you would have seen that the list you are going through wasnt my suggestion, but what is currently there, only thing was that i mistakenly put the accelerator after the letter rather than before it, which Stuart caught in his reply.
Comment 4 V Stuart Foote 2015-08-02 18:46:49 UTC
(In reply to Yousuf (Jay) Philips from comment #3)

> Accelerators for the main menu dont have to do with accelerators for the
> start center, so there isnt any duplication there. Or am i mistaken about
> this, because without pressing Alt you cant get to menu accelerators.
> 

No, when we have a window with a the mix of both src and .UI exposing accelerators we need to be especially careful about them as they appear the same visually.

When they are mixed, as in the StartCenter, in addition to menu widget accelerators that respond with <Alt> combinations, keyboard navigation between .UI widgets with <F6> or <F10> really requires that we NOT have any duplicate accelerators defined on any active window.

They coexist, but it is poor attention to detail if we allow duplicates.
Comment 5 Yousuf Philips (jay) (retired) 2015-08-02 19:09:19 UTC
(In reply to V Stuart Foote from comment #4)
> They coexist, but it is poor attention to detail if we allow duplicates.

So is this also true with the sidebar, as we have duplicated between the menu bar (e.g. _Insert) and the sidebar (e.g. _Indent).
Comment 6 V Stuart Foote 2015-08-02 21:55:42 UTC
(In reply to Yousuf (Jay) Philips from comment #5)
> (In reply to V Stuart Foote from comment #4)
> > They coexist, but it is poor attention to detail if we allow duplicates.
> 
> So is this also true with the sidebar, as we have duplicated between the
> menu bar (e.g. _Insert) and the sidebar (e.g. _Indent).

Yep, and those accelerators present in the Sidebar panel are screwy anyhow. Not sure when they got stuck in , but you have to navigate into the specific Content Panel of the Deck before they respond at all as accelerators. Ugly UX.