Created attachment 117708 [details] Screencast of problem. LibreOffice 5.0.0 on Arch Linux. Selecting preview sound in gallery sidebar opens media player window. Attempting to close window crashes entire application. Window reappears upon reopening Writer. Please refer to attached screencast.
Furthermore, LibreOffice Writer fails to delete /tmp directories on close from here on forward. Document Recovery dialog is shown on every start. Only solution is to delete ~/.config/libreoffice/
This hasn't worked since the Timer/Idle work in the range 9e678c14e4fc8e58b1e0530744f648fa3958d338..d05a64df34fd143670cb939b72abfb32d6b714c7 However, the initial problem thereafter was that trying to play media led to a freeze, rather than a crash, which was fixed on bug 90077 in the commit commit 9a5323655355a01be582a556a99e410c4064ebe4 Author: Noel Grandin <noel@peralex.com> Date: Wed Jun 10 16:58:54 2015 +0200 tdf#90077 fix freeze when enabling media toolbar in Impress Since then, the crash reported on this bug has occurred. Perhaps the root cause is the same or perhaps not, that's as far as I could get just looking at the symptoms. Adding Cc: to noelgrandin@gmail.com; Any thoughts on this one? Thanks
*** Bug 93491 has been marked as a duplicate of this bug. ***
Was just about to report the same thing. Steps: 1) Open Impress 2) Tools > Media Player 3) Click close button in title bar of dialog Regression as this doesnt happen in 4.4 daily. Version: 5.1.0.0.alpha1+ Build ID: 5d6ef74eea5d73b8cd17f313ad87138d56dc76ce TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2015-08-18_01:28:44
That's a VclPtr issue. DockingWindow::dispose calls DockingWindow::SetFloatingMode which calls MediaFloater::ToggleFloatingMode (and the latter tries to dereference the invalid mpMediaWindow pointer, which was already cleaned in MediaFloater::dispose). In the old code, because the cleaning stuff was in the destructor rather than in dispose(), DockingWindow::ToggleFloatingMode was called instead of MediaFloater::ToggleFloatingMode.
Thanks for the analysis Maxim; pushed a fix based on it.
Michael Meeks committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1ce2375b17912622e6db4c2c81afa24527a0104b tdf#93188 - avoid crash in media player. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Meeks committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=444c76830b75528a8130484e24781333535200f3&h=libreoffice-5-0 tdf#93188 - avoid crash in media player. It will be available in 5.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 93638 has been marked as a duplicate of this bug. ***
After installing version 5.0.2.2 (x64), the crashes still remain. Problem is not solved. See also bug report 93491. This bug report is marked as a duplicate of bug 93188.
Hi Wim; this x86_64 windows issue is a different bug; please can you file a new bug - and (ideally) attach a stack-trace to avoid these getting confused. It could easily be something related to media / playback / embedding on Windows and nothing to do with VclPtr. It would be great to get a stack-trace for that too if possible; but not in this bug. Thanks !
Hi Michael. How can I take a stack-trace?
Hi Wim, You can find the instructions here - https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg
Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit]