Bug 95269 - text select doesn't work like normal, in comments
Summary: text select doesn't work like normal, in comments
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on: 139634
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2015-10-23 06:01 UTC by Luke Kendall
Modified: 2023-05-14 08:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Kendall 2015-10-23 06:01:11 UTC
When selecting text in a comment, it does not work in the same way as it does in the body of the document: if you double click on a word to select it, you cannot then drag the mouse to select more words of text in the comment.

This suggests two different implementations of text selection exist, also: if you could refactor the code for the main body to be applicable in other places, you might also be able to reduce redundancy and the code size?  (Apologies for pointing out the obvious.)
Comment 1 Buovjaga 2015-10-24 16:52:37 UTC
Reproduced.

Win 7 Pro 64-bit, Version: 5.0.2.2 (x64)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251fe
Locale: fi-FI (fi_FI)

Version: 5.1.0.0.alpha1+
Build ID: fcc2415ade6ae93710bbbda9f7e163045e323105
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-10-21_16:55:13
Locale: fi-FI (fi_FI)
Comment 2 Luke Kendall 2015-11-22 11:45:49 UTC
In fact, from the numerous bugs in comment text rendering, I suspect it's a separate implementation of a (subset) of the document text render.  I noticed a give-away: that if you use two spaces after a period, unlike the main doc text renderer, if the sentence after the spaces is placed on a new line, the 2nd space can sometimes be displayed, instead of being omitted in that case (as the main document text renderer correctly does.)

Could the main text renderer be adapted to be used for comment text?  I assume it's already used for rendering other text frames...?  I assume then that you'd be able to colour comment text if needed, too.
Comment 3 Luke Kendall 2015-11-22 14:33:47 UTC
Not just the renderer; the editor: I just noticed that when you double-click on a word in a comment, and cut it, it doesn't take the adjacent space as it does when you perform the same operation in the main document.  It takes just the selected word, leaving two spaces adjacent.
Comment 4 QA Administrators 2017-01-03 19:37:04 UTC Comment hidden (obsolete)
Comment 5 Telesto 2018-04-23 18:34:48 UTC
Repro with
Version: 6.1.0.0.alpha0+
Build ID: 2ed7c02478968852d7d39c2c4677f2ecf3441bc7
CPU threads: 4; OS: Windows 6.3; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-04-22_01:00:56
Locale: nl-NL (nl_NL); Calc: CL

and with
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 6 QA Administrators 2019-04-24 02:49:05 UTC Comment hidden (obsolete)
Comment 7 Luke Kendall 2019-05-23 14:15:17 UTC
Just checked in Writer 6.2.3.2

I confirm that comment text is not edited in the same way the main document text is:

- if you double click on a word to select it, you cannot then drag the mouse to select more words of text in the comment
- if you use two spaces after a period, unlike the main doc text renderer, if the sentence after the spaces is placed on a new line, the 2nd space can sometimes be displayed, instead of being omitted in that case (as the main document text renderer correctly does.)
- when you double-click on a word in a comment, and cut it, it doesn't take the adjacent space as it does when you perform the same operation in the main document
- Scrolling isn't 100% reliable. When you have multiple comments on a single page, with at least two long enough to require scrollbars (a great feature!), if you scroll one to a particular point and then click into the other comment, the other comment's displayed text can scroll to a different point and the scroll bar be placed at the wrong point in that other comment.
Comment 8 QA Administrators 2023-05-14 03:19:10 UTC Comment hidden (obsolete)
Comment 9 Luke Kendall 2023-05-14 08:11:30 UTC
Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

It's still the case that after double-clicking to select a word, or triple clicking to select a paragraph, and leaving the mouse down, you can't then drag select anything further in the comment.
Comment 10 Luke Kendall 2023-05-14 08:13:08 UTC
I also noticed a fresh bug, while re-testing that. I'll submit a separate bug report.