Bug 95394 - UI Fill dialog inconsistency in wording (bitmap <> image) when filling with an image
Summary: UI Fill dialog inconsistency in wording (bitmap <> image) when filling with a...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Rahul Balaji
URL:
Whiteboard: target:7.3.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Area-Fill-Tab-Image
  Show dependency treegraph
 
Reported: 2015-10-28 13:30 UTC by Jean-Baptiste Faure
Modified: 2022-06-29 19:58 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2015-10-28 13:30:32 UTC
Step to reproduce:
1/ open a new text document
2/ type some text
3/ right click on the text and choose Paragraph
4/ in the dialog which appears, choose the Area tab
5/ in the dropdown list we have the entry Bitmap although not only bitmap formats are allowed. For example it is possible to use a svg drawing.

Instead of "Bitmap", we should have "Image" in this dropdown menu.

Tha same Area tab is displayed in Page formatting and Image formatting (at least). 

Best regards. JBF
Comment 1 Cor Nouws 2015-10-29 20:07:39 UTC
Thanks Jean-Fraincois. > New
(hope my clarification of the summary is OK )
Comment 2 QA Administrators 2016-11-08 11:53:45 UTC Comment hidden (obsolete)
Comment 3 Jean-Baptiste Faure 2016-11-09 09:34:51 UTC
Still there in current master and in LO 5.2.4.0+.

Best regards. JBF
Comment 4 QA Administrators 2017-11-10 08:03:22 UTC Comment hidden (obsolete)
Comment 5 Jean-Baptiste Faure 2017-11-11 12:42:16 UTC
Still there in current master and in LO 5.4.

Best regards. JBF
Comment 6 QA Administrators 2018-11-12 03:41:24 UTC Comment hidden (obsolete)
Comment 7 Jean-Baptiste Faure 2019-01-05 11:46:05 UTC
Still there in LO 6.2.0.1.0+ 

Best regards. JBF
Comment 8 Heiko Tietze 2020-12-07 10:35:43 UTC
Code pointer: cui/uiconfig/ui/bitmaptabpage.ui
Comment 9 starb1585 2020-12-08 01:41:05 UTC
Hi,

I am interested in working on this, but I am new.  How do I get started?

Thanks
Comment 10 starb1585 2020-12-08 01:41:26 UTC Comment hidden (obsolete)
Comment 11 Heiko Tietze 2020-12-08 10:19:39 UTC
(In reply to starb1585 from comment #9)
> I am interested in working on this, but I am new.  How do I get started?

Open the file, edit the label, submit to Gerrit ;-)

Please ask a bit more specific. Usually you need to set-up the environment first, get the sources, make sure you can submit patches via Git etc. See https://wiki.documentfoundation.org/Development/GetInvolved/en. But in this particular case it's just one string and you may adopt the web editing procedure from the documentation team at https://wiki.documentfoundation.org/Documentation/GerritEditing
Comment 12 Buovjaga 2020-12-08 10:41:48 UTC
(In reply to Heiko Tietze from comment #11)
> https://wiki.documentfoundation.org/Documentation/GerritEditing

That wiki page is out of date, use the Gerrit docs instead https://gerrit.libreoffice.org/Documentation/user-inline-edit.html
Comment 13 Buovjaga 2021-07-22 15:39:57 UTC
Note also that the Sidebar Area fill dropdown has a separate string 'Bitmap'. I was unable to find where it is taken from.

Clues:
svx/uiconfig/ui/sidebararea.ui has <object class="GtkComboBoxText" id="fillstylearea">

svx/source/sidebar/area/AreaPropertyPanelBase.cxx has mxLbFillType, but I don't know

This could be done in a follow-up patch.

I can take care of updating Help.
Comment 14 Commit Notification 2021-07-22 17:34:40 UTC
haru-02 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8580f2d5c8fef0c3c3ff1e92da09e13ec2158bea

tdf#95394 - ui fill dialog from (bitmap -> image)

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Rahul Balaji 2021-07-23 11:12:21 UTC
(In reply to Buovjaga from comment #13)
> Note also that the Sidebar Area fill dropdown has a separate string
> 'Bitmap'. I was unable to find where it is taken from.
> 
> Clues:
> svx/uiconfig/ui/sidebararea.ui has <object class="GtkComboBoxText"
> id="fillstylearea">
> 
> svx/source/sidebar/area/AreaPropertyPanelBase.cxx has mxLbFillType, but I
> don't know
> 
> This could be done in a follow-up patch.
> 
> I can take care of updating Help.

Thank you for the note. I will try to find and change it in the sidebar dropdown too.
Comment 16 BogdanB 2021-07-23 19:22:02 UTC
Thanks for this fix.

We have now "Image" instead of "Bitmap".

Verified in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 17 Commit Notification 2021-07-24 15:09:13 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20c2d7deaab20deb6970cab563d4c7d88fefa53f

tdf#95394 ToTD: Bitmap -> Image

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2021-07-24 20:06:45 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/36052eea4f7977303088774c3299a7c721ca2608

tdf#95394 Help: Bitmap -> Image