When a protected sheet tab is right clicked, it already has the lock mark. But, in order to distinguish protected sheets, it would be nice to also have the small lock mark directly on a protected sheet tab (in the upper right corner).
Thanks :)
We're replacing our use of the 'ux-advise' component with a keyword: Component -> LibreOffice Add Keyword: needsUXEval [NinjaEdit]
(In reply to Timur from comment #0) > When a protected sheet tab is right clicked, it already has the lock mark. > But, in order to distinguish protected sheets, it would be nice to also have > the small lock mark directly on a protected sheet tab (in the upper right > corner). Definitely a good idea. However, "upper right corner" sounds strange. Why no have it directly next to the tab label? (Only the locked tabs would have an icon, do not show an unlock symbol on every tab.) Removing needsUX, moving to Calc
This could be indeed useful, but not in all and any situations. In a corporate environment, it might be preferred to *not* show such a signal to avoid worrying users of spreadsheet templates. Thus I'd prefer having this enhancement to be optional.
Hi, I was working on it for it has new tag. If there is a discussion about the subject, please change the label.
(In reply to Jean-Francois Nifenecker from comment #4) > This could be indeed useful, but not in all and any situations. > In a corporate environment, it might be preferred to *not* show such a > signal to avoid worrying users of spreadsheet templates. Can you please explain? > Thus I'd prefer having this enhancement to be optional. I guess you mean to have this enhancement regularly included in general installation, but with the option in expert configuration not to be shown.
Gülşah, I hope you are still working on this.
Hello, I talked about it during the last ESC and committee seems to like this feature. I have several clients (big French administrations) who would like this feature integrated. Jean-Sébastien Bevilacqua
I was away for a long time. Now i'm back now but i won't continue with that bug. I want to improve myself on import export filters. Anyone can feel free for fixing that bug.
Came back. https://gerrit.libreoffice.org/#/c/44558/ puts an asterisk on protected tabs. Needs code review and help about lock mark.
Gulsah Kose committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=5fccf17f33aa7e97314c14a5a4616b2f2643614c tdf#95880 Add a lock mark on protected sheet tab. It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Nice. Gulsah, please mark as fixed.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=77ee31f4f89a4db50064040d026feecbbfb7b20b Render lock symbol with sheet name, tdf#95880 follow-up It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 137909 [details] Lock mark - Before and after Eike's patch I can't say what's better, look before or after Eike's patch, but I guess there were reasons as written. Anyway, thank you both. Jean-Francois didn't follow with the explanation why we wouldn't show lock mark also in a corporate environment, for spreadsheet templates. For me, it's better to have this mark always because it gives a clue why some sheet is different and why some fields cannot be changed.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7eba8e98508d547f43fecbe3175a11a05956b30a Related: tdf#118547 handle multi-sheet un-/protect, tdf#95880 follow-up It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Also http://cgit.freedesktop.org/libreoffice/core/commit/?id=6fb449d127d1da165f610c4c99c2c7d9c5afbb97 Handle protection lock mark in Undo/Redo, tdf#68290 follow-up It will be available in 6.2.0.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3eeb0096ac7c5beb48441eabc032cde38745a549&h=libreoffice-6-1 Related: tdf#118547 handle multi-sheet un-/protect, tdf#95880 follow-up It will be available in 6.1.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9bc663d8d33d00ba3019151c82f0710b199d387&h=libreoffice-6-1 Handle protection lock mark in Undo/Redo, tdf#95880 follow-up It will be available in 6.1.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc9c326c378f252df83aa90a61df51a60d574c8c&h=libreoffice-6-0 tdf#118547: Remove lock mark only if password is correct, tdf#95880 follow-up It will be available in 6.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.