Bug 96306 - FILEOPEN: RTF table properties spacing left incorrect
Summary: FILEOPEN: RTF table properties spacing left incorrect
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: interoperability
Keywords: bibisected, bisected, filter:rtf
Depends on:
Blocks: RTF-Opening RTF-Tables
  Show dependency treegraph
 
Reported: 2015-12-07 10:26 UTC by Ari Latvala
Modified: 2019-02-12 08:18 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
PDF version showing the expected layout (36.99 KB, application/pdf)
2015-12-07 10:26 UTC, Ari Latvala
Details
RTF version having incorrect table left spacing (1.36 MB, application/rtf)
2015-12-07 10:27 UTC, Ari Latvala
Details
PDF from LO 6.2 alpha 0 (79.84 KB, application/pdf)
2018-10-06 07:40 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ari Latvala 2015-12-07 10:26:44 UTC
Created attachment 121100 [details]
PDF version showing the expected layout

Libre Office 5.0.4.1 on Windows 7 64-bit.

RTF version of the document "kissaliitto_ilmo_141.rtf" from site http://www.kissaliitto.fi/lomakkeet/nayttely has at least table 5 and table 6 left spacing incorrect, when compared to the PDF version or layout on Word.
Comment 1 Ari Latvala 2015-12-07 10:27:41 UTC
Created attachment 121101 [details]
RTF version having incorrect table left spacing
Comment 2 Buovjaga 2015-12-08 11:28:02 UTC
Yeah table5 and 6 are too wide.

The rendering varies between versions. 3.5.0 has equal width. In 4.3 only table 5 is icorrect width (and positioned wrong).

Win 7 Pro 64-bit, Version: 5.0.3.2 (x64)
Build ID: e5f16313668ac592c1bfb310f4390624e3dbfb75
Locale: fi-FI (fi_FI)

Version: 5.2.0.0.alpha0+
Build ID: 81fa5340191baf8687f9c82f1f414f5afc86b529
Threads 4; Ver: Windows 6.1; Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-03_21:19:19
Locale: fi-FI (fi_FI)
Comment 3 Ari Latvala 2016-03-14 21:01:01 UTC
Problem still there on LO 5.1.1.3 for Windows 7 SP1 64-bit.
Comment 4 raal 2016-03-16 11:24:27 UTC
reproducible with Version: 4.5.0.0.alpha0+
Comment 5 raal 2016-03-16 17:04:21 UTC
checked left spacing of table 6:
This seems to have begun at the below commit.
Adding Cc: to Michael Stahl ; Could you possibly take a look at this one?
Thanks
 6947ad8957bcff4ee5a5d25ad5c1ada5e5456fcc is the first bad commit
commit 6947ad8957bcff4ee5a5d25ad5c1ada5e5456fcc
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 00:06:28 2015 +0800

    source-hash-df041e468baf604f6e2606e5b632aa654b19a65d
    
    commit df041e468baf604f6e2606e5b632aa654b19a65d
    Author:     Michael Stahl <mstahl@redhat.com>
    AuthorDate: Fri Aug 1 10:44:00 2014 +0200
    Commit:     Michael Stahl <mstahl@redhat.com>
    CommitDate: Fri Aug 1 11:02:32 2014 +0200
    
        fdo#81892: writerfilter: RTF import: add support for table row alignment
    
        These keywords were simply not implemented.
    
        Change-Id: Ib4d07a4b2dfb07cfd56a4ee07d7c14d1c59323f9
Comment 6 Michael Stahl (allotropia) 2016-04-13 20:49:53 UTC
i'm comparing current master and current master with patch from
comment#5 reverted with the reference pdf rendering.

without the patch, the tables (including table 5/6)
are positioned too far to the left (since they are left aligned).

with the patch, most of the tables (except for table 5/6)
are now centered and positioned like in the reference pdf.

so actually the patch is not a regression, but an improvement.

the problem is that tables 5/6 are still not positioned correctly,
which might have something to do with them being aligned "from left",
which is not a regression.

i can't find an older version that does these 2 tables better;
OOo 3.3 is particularly funny since it imports one of them
into a frame that floats above the others...

=> removing "regression" keyword
Comment 7 Ari Latvala 2016-06-02 20:01:19 UTC
Problem still exists on LO 5.2 beta 1 on Windows 7 SP1 64-bit.
Comment 8 QA Administrators 2018-10-06 02:49:26 UTC Comment hidden (obsolete)
Comment 9 Roman Kuznetsov 2018-10-06 07:39:48 UTC
in 

Version: 6.2.0.0.alpha0+
Build ID: 1aa37aa6bee19099b57555a6d839992b054aa405
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-09-23_10:17:54
Locale: ru-RU (ru_RU); Calc: threaded

still repro on table 6 (see PDF in attach), and we have two pages instead one
Comment 10 Roman Kuznetsov 2018-10-06 07:40:22 UTC
Created attachment 145428 [details]
PDF from LO 6.2 alpha 0
Comment 11 Ari Latvala 2019-02-12 07:03:58 UTC
Original problem for this bug seems to have been fixed, problem for table 6 is on the other bug report: 

Bug 108093 - FILEOPEN: RTF table horizontal position wrong because frame not imported 

As an regression on table 6 font size is currently too big on the first column. Should be 7 points but is 10. This causes incorrect paging.
Comment 12 Buovjaga 2019-02-12 08:18:00 UTC
(In reply to Ari Latvala from comment #11)
> As an regression on table 6 font size is currently too big on the first
> column. Should be 7 points but is 10. This causes incorrect paging.

Reported as bug 123393 now