Bug 96500 - EDITING: flicker during mouse-move of table control (form design mode)
Summary: EDITING: flicker during mouse-move of table control (form design mode)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
4.2 all versions
Hardware: All All
: low trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on: 94069
Blocks: Flickering-UI
  Show dependency tree / graph
 
Reported: 2015-12-15 06:08 UTC by Lionel Elie Mamane
Modified: 2022-11-15 07:51 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lionel Elie Mamane 2015-12-15 06:08:31 UTC 
In form design mode, drag'n drop a table control. It moves, but flickers.

For example in attachment 118555 [details].

Between 5.0.0 and 5.0.3 inclusive it hangs instead, but that is not this bug, but bug 94069. In 5.0.4.2 (and for some range in master) it does not flicker, thanks to

  http://cgit.freedesktop.org/libreoffice/core/commit/?id=a08a5ff76b78f828367467a0a1610d2f7e63ad75&h=libreoffice-5-0

  Resolves: tdf#94069 call setVisible when setDesignMode is called

but this leads to bug 96482 and will thus be reverted very soon.

Joel wrote:

And here is a bibisect of where the flickering started:
 4984b2bcccf87dab80d9c47fb934d4ea0c08bd28 is the first bad commit
commit 4984b2bcccf87dab80d9c47fb934d4ea0c08bd28
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Thu Oct 17 22:20:58 2013 +0000

    source-hash-89aeec9b1d2f771310eeb0fa4c820c19599df0f7

    commit 89aeec9b1d2f771310eeb0fa4c820c19599df0f7
    Author:     Luboš Luňák <l.lunak@suse.cz>
    AuthorDate: Tue Aug 6 23:30:28 2013 +0200
    Commit:     Luboš Luňák <l.lunak@suse.cz>
    CommitDate: Tue Aug 6 23:30:28 2013 +0200

        remove unused variable

        Change-Id: Iaf22f259fa396deee3cab84cc9549427b76017c2

:100644 100644 d35616cd13b3464614c4ea7f19de0b5fd896cb16 e45fdabf18736545b41132e1fda4f59911357d37 M    autogen.log
:100644 100644 52fc9f22d94afc40ef61e23c357dc7e0f9d2a4fd 0cb98ee181f4b9db5d136455ddb13f3829854d49 M    ccache.log
:100644 100644 42bee39af0bdddae12cc95ffbbbe4b87095f3023 9ccbd06f24d165ed9e4d00de1d4f723bc7f98dfc M    commitmsg
:100644 100644 86e4986c08d48d57776b2d2dc8e0bf2e3741ba39 fefef950e909e02916e93259c31b7fce1375bcdc M    dev-install.log
:100644 100644 6dfffb6da3ef540763fa3ed85ef2b4863a7db2fc 8ba4fd5c9afa0897119e72d09fce25468cdb7f20 M    make.log
:040000 040000 14a0727fd795a4c854d6e7d45f0b60ab59cd54c2 b4c0e400f66b81f53315ea13993a0017fd3176fc M    opt

# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b]
source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00]
source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [e02439a3d6297a1f5334fa558ddec5ef4212c574]
source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574
# bad: [4850941efe43ae800be5c76e1102ab80ac2c085d]
source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b
git bisect bad 4850941efe43ae800be5c76e1102ab80ac2c085d
# skip: [a043626b542eb8314218d7439534dce2fc325304]
source-hash-9379a922c07df3cdb7d567cc88dfaaa39ead3681
git bisect skip a043626b542eb8314218d7439534dce2fc325304
# skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6]
source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a
git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6
# skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6]
source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a
git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31]
source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31]
source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930
git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31
# bad: [1d4980621741d3050a5fe61b247c157d769988f2]
source-hash-89d01a7d8028ddb765e02c116d202a2435894217
git bisect bad 1d4980621741d3050a5fe61b247c157d769988f2
# good: [ba096f438393091574da98fe7b8e6b05182a8971]
source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8
git bisect good ba096f438393091574da98fe7b8e6b05182a8971
# bad: [e75547cbd2d9d480ba13e119a8df8098c9d3a0a3]
source-hash-69f686774cfeb803fdd63ed1ef07ff70550930de
git bisect bad e75547cbd2d9d480ba13e119a8df8098c9d3a0a3
# bad: [4984b2bcccf87dab80d9c47fb934d4ea0c08bd28]
source-hash-89aeec9b1d2f771310eeb0fa4c820c19599df0f7
git bisect bad 4984b2bcccf87dab80d9c47fb934d4ea0c08bd28
# good: [08d5ea8e996493ba7371a6cf954fbc0469d9042a]
source-hash-a38f09fec16f24886414c3e9f9574a06b56d8077
git bisect good 08d5ea8e996493ba7371a6cf954fbc0469d9042a
# good: [66426e60b06c075436eaa9640140d3a263dc173c]
source-hash-7e07a45500dcbb891a85f0bc9b7049cf4d50bba1
git bisect good 66426e60b06c075436eaa9640140d3a263dc173c
# good: [a22bedaefd4f837e884f70bc50b0f916160b4c49]
source-hash-a4c385f1aa98b5fb2d85136b653365fb6baa33f8
git bisect good a22bedaefd4f837e884f70bc50b0f916160b4c49
# first bad commit: [4984b2bcccf87dab80d9c47fb934d4ea0c08bd28]
source-hash-89aeec9b1d2f771310eeb0fa4c820c19599df0f7
Comment 1 Alex Thurgood 2015-12-15 08:17:33 UTC 
(In reply to Lionel Elie Mamane from comment #0)
> In form design mode, drag'n drop a table control. It moves, but flickers.
> 
> For example in attachment 118555 [details].
> 
> Between 5.0.0 and 5.0.3 inclusive it hangs instead, but that is not this
> bug, but bug 94069. In 5.0.4.2 (and for some range in master) it does not
> flicker, thanks to
> 
>  
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=a08a5ff76b78f828367467a0a1610d2f7e63ad75&h=libreoffice-5-0
> 
>   Resolves: tdf#94069 call setVisible when setDesignMode is called
> 

Indeed, I see no flicker in master :
Version: 5.2.0.0.alpha0+
Build ID: ce3d3f5543e3e132a3473af27aa2c827336add0f
CPU Threads: 2; OS Version: -; UI Render: default; 
Locale : fr-FR (fr.UTF-8)
OSX 10.11.2
Comment 2 Alex Thurgood 2015-12-22 07:49:13 UTC 
Confirmed on

Version: 4.2.4.2
Build ID: 63150712c6d317d27ce2db16eb94c2f3d7b699f8

OSX 10.11.2
Comment 3 Michael Meeks 2016-01-28 18:26:47 UTC 
Quite probably the flickering will be avoided by GL double-buffering on Windows, and GTK3 on Linux, and Mac does this already too so ... =)
Comment 4 Xisco Faulí 2016-09-12 12:13:57 UTC 
Adding keyword 'bibisectRequest'.
Comment 5 Xisco Faulí 2017-09-29 08:48:11 UTC Comment hidden (obsolete)
Comment 6 Buovjaga 2018-04-30 17:51:40 UTC 
Still flickers, but indeed GTK3 is immune.

Arch Linux 64-bit
Version: 6.1.0.0.alpha1+
Build ID: 632bc11ce8fab1c4046ab24810b90a7ce9ac5914
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on April 27th 2018
Comment 7 QA Administrators 2021-06-11 03:49:29 UTC Comment hidden (obsolete)
Comment 8 Jorge Teixeira 2022-11-08 13:35:39 UTC 
Could not reproduce the flickering in LO 7.4.2.3 / Win10 AMD64.
However, when moving (most?) other controls, i.e., while holding the left mouse button and moving the mouse, there is some indication of the tentative new position, but nothing is shown while moving the table control.


Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: pt-PT (pt_PT); UI: en-US
Calc: threaded
Comment 9 Buovjaga 2022-11-12 20:05:05 UTC 
(In reply to Jorge Teixeira from comment #8)
> Could not reproduce the flickering in LO 7.4.2.3 / Win10 AMD64.
> However, when moving (most?) other controls, i.e., while holding the left
> mouse button and moving the mouse, there is some indication of the tentative
> new position, but nothing is shown while moving the table control.

Thanks, reported as bug 152018
Comment 10 Stéphane Guillou (stragu) 2022-11-15 00:28:04 UTC Comment hidden (obsolete)
Comment 11 Stéphane Guillou (stragu) 2022-11-15 00:31:59 UTC 
no flickering since at least:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

With bug 152018 created, can we make this one WFM?
Comment 12 Buovjaga 2022-11-15 07:51:12 UTC 
Let's keep this open because I see it flickering in the commit preceding bug 152018.