Bug Hunting Session
Bug 97111 - Again bad rendering of scalable brackets
Summary: Again bad rendering of scalable brackets
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha0+ Master
Hardware: x86 (IA32) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2016-01-13 21:25 UTC by Regina Henschel
Modified: 2016-12-03 03:45 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Document with formula and screenshot of bad and good rendering (15.33 KB, application/vnd.oasis.opendocument.text)
2016-01-13 21:25 UTC, Regina Henschel
Details
screen capture from LO 5.1.1.0.0+ (7.85 KB, image/png)
2016-01-15 21:55 UTC, Jean-Baptiste Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2016-01-13 21:25:48 UTC
Created attachment 121910 [details]
Document with formula and screenshot of bad and good rendering

Open attached document. Notice, that the brackets are far to thick. The document contains an image of the correct rendering.

OK
Version: 5.1.0.0.alpha1+
Build ID: a933e01a54f08132c2d8699f7c6851a8b493d5dc
TinderBox: Win-x86@39, Branch:master, Time: 2015-08-04_06:10:12
Locale: de-DE (de_DE)

Bad
Version: 5.1.0.0.alpha1+
Build ID: c614e711136205252ac2c72f9772c718dafc471e
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-08-12_20:36:06
Locale: de-DE (de_DE)
Comment 1 Khaled Hosny 2016-01-14 05:46:33 UTC
While both renderings are bad (scaling brackets to make them bigger is never a good idea, it should be done using glyphs for different sizes like TeX does), but I think the new behaviour is a much more improvement. Thinning the scaled bracket into oblivion is a much worse behaviour than making it thicker.
Comment 2 raal 2016-01-14 11:00:27 UTC
This seems to have begun at the below commit.
Adding Cc: to Tor Lillqvist; Could you possibly take a look at this one? Thanks

7f0371ad242095657660bb4862bcdfa4a28b4e2c is the first bad commit
commit 7f0371ad242095657660bb4862bcdfa4a28b4e2c
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Aug 11 23:27:51 2015 -0700

    source sha:4667db065d34193d99bce82f7e8f3b20a03ecade

    source sha:4667db065d34193d99bce82f7e8f3b20a03ecade

:040000 040000 245203c6558658daaa3c2c56bc92bb8371a13f47 c660e9c56aa230b617b462b941c61f38ef7c0a27 M      instdir

author	Tor Lillqvist <tml@collabora.com>	2015-08-12 05:18:50 (GMT)
committer	Tor Lillqvist <tml@collabora.com>	2015-08-12 06:14:20 (GMT)
commit	4667db065d34193d99bce82f7e8f3b20a03ecade (patch)
Drop SimpleWinLayout
Comment 3 Jean-Baptiste Faure 2016-01-15 21:55:41 UTC
Created attachment 121962 [details]
screen capture from LO 5.1.1.0.0+

Not reproducible for me with LO 5.1.1.0.0+ built at home under Ubuntu 15.10 x86-64.
I do not use OpenGL nor GTK3 in LO.

Best regards. JBF
Comment 4 Wolfgang Jäger 2016-01-19 22:11:06 UTC
I would not judge the image Regina inserted as "Good rendering" in her example attached to the description satisfactory. (May this be due tu unintentional clipping?) 

I meanwhile tested with "Version: 5.1.0.2 (x64)  
Build ID: ecd3574d51754b043f865cf5bafee286d24db7cc  
CPU Threads: 4; OS Version: Windows 6.29; UI Render: default;  
Locale: de-DE (de_DE)"   
In addition: UI en-UK  

No improvemenmt: Ugly brackets and braces unchanged as compared with Regina's example.
Comment 5 V Stuart Foote 2016-02-07 19:21:25 UTC
Tor reverted the incomplete Uniscribe implementation on Windows with

2016-01-21 10:04
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4622689fad7ddff72cd08da9611ccfacdb0aa7bd

For now, that has cleared the regression here.  But Frédéric's and Khaled's comments on bug 32362 on need to rework Math's formula canvas to construct the brackets, parenthesis and boxes with glyphs for multiple codepoints (assume we'd work with codepoints 0x239B -> 0x23B9 from the Unicode Miscellaneous Technical block).
Comment 6 V Stuart Foote 2016-02-07 20:10:10 UTC
Reverted to *less* objectionable stretching with reversion of UniscribeLayout support and reintroduction of SimpleWinLayout

first landed in master

Version: 5.2.0.0.alpha0+
Build ID: c81eddbb20c84280aa64c712e34c829380b24527
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-01-22_04:19:03
Locale: en-US (en_US)