Bug 97577 - UI: Source Sans Pro, as Impress default font
Summary: UI: Source Sans Pro, as Impress default font
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, needsDevEval
Depends on:
Blocks: Fonts Templates Impress-UX
  Show dependency treegraph
 
Reported: 2016-02-04 16:26 UTC by László Németh
Modified: 2019-07-18 11:41 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Liberation Sans and Source Sans Pro comparison (23.13 KB, image/png)
2016-02-04 16:26 UTC, László Németh
Details
New slide with Liberation Sans (19.71 KB, image/png)
2016-02-04 16:28 UTC, László Németh
Details
New slide with Source Sans Pro (19.66 KB, image/png)
2016-02-04 16:29 UTC, László Németh
Details
Test document with Arial font settings (13.33 KB, application/vnd.oasis.opendocument.presentation)
2016-02-04 16:30 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description László Németh 2016-02-04 16:26:20 UTC
Created attachment 122388 [details]
Liberation Sans and Source Sans Pro comparison

Impress uses Liberation Sans, as a default text font. It would be better to use Source Sans Pro, because of the following advantages:

– more elegant for slides (nicer glyphs; bigger X-height; dots are dots, not squares)
– more elegant Impress layout (see empty slides with “Click to add...” font preview on the attached screen shots)
– full hinting (better uppercase text and i18n support, see attached comparison)
– lots of different weights (Black, Semibold, Light, Extralight)

With the proposed patch Impress will prefer Source Sans Pro to Liberation Sans in new documents. It's important, that this change doesn't modify the metric replacement of the missing Arial font: that is still Liberation Sans (see on the attached test presentation).
Comment 1 László Németh 2016-02-04 16:28:27 UTC
Created attachment 122389 [details]
New slide with Liberation Sans
Comment 2 László Németh 2016-02-04 16:29:23 UTC
Created attachment 122390 [details]
New slide with Source Sans Pro
Comment 3 László Németh 2016-02-04 16:30:11 UTC
Created attachment 122391 [details]
Test document with Arial font settings
Comment 4 m.a.riosv 2016-02-04 23:12:12 UTC
Hi @László, maybe I has miss something, but what is the bug status as NEW? Usually this need to be done for other than the reporter. Or was this change approved for some LibreOffice team.
Comment 5 László Németh 2016-02-04 23:31:38 UTC
(In reply to m.a.riosv from comment #4)
> Hi @László, maybe I has miss something, but what is the bug status as NEW?
> Usually this need to be done for other than the reporter. Or was this change
> approved for some LibreOffice team.

Hi @m.a.riosv. I am not the original reporter. I have only forwarded this problem, and confirmed as a LibreOffice developer. Thanks for your question, László
Comment 6 V Stuart Foote 2016-02-04 23:55:14 UTC
László, *

Great idea! Just wish there was more complete BMP and SEP codepoint coverage.
Any reason to not consider instead your Linux Biolinum--are the metrics just too far off for that?

=-=-=

Miguel Angel -- for UX-advise we are not overly picky for these discussions, I've set it to an enhancement discussion.

Stuart
Comment 7 m.a.riosv 2016-02-05 00:14:21 UTC
Thanks László/Stuart, it's clear now.
Comment 8 Yousuf Philips (jay) (retired) 2016-02-12 15:01:13 UTC
It would be more useful to change the default fonts across all the apps than to just change it only in impress, just like when we switched from Times New Roman and Arial to Libration Sans and Liberation Serif, as we want consistency between the apps.

I opened up this topic in this weekly's design meeting and have suggested possible options to shift to.

1. Droid Family - used on Android, available in Google Docs, available in ubuntu 12.04 & debian 6-backports - http://en.wikipedia.org/wiki/Droid_fonts

2. Noto Family - droid derivative to fully cover all scripts in unicode, available in ubuntu 14.04 & debian 7 - https://en.wikipedia.org/wiki/Noto_fonts

3. Caladea, Carlito - bundled with LibO, metric compatible with MS Office default fonts, available in ubuntu 14.04 & debian 7-backports
Comment 9 Robinson Tryon (qubit) 2016-08-25 05:49:28 UTC Comment hidden (obsolete)
Comment 10 Heiko Tietze 2018-12-17 15:22:44 UTC
Font being used depends on the template. Default is DejaVu Sans. And since we made many changes I would suggest to close the ticket.
Comment 11 Heiko Tietze 2018-12-20 16:25:05 UTC
We discussed the topic in the design meeting. And while the font name is part of the template it was agreed on the request to have better defaults. Since the templates are generated from xml files it shouldnt be too difficult to switch to Source Sans Pro. Laurent BP would have the code pointers.
Comment 12 mgalbavy 2019-04-11 20:59:46 UTC
Hi, I'm interested in working on this bug. Is that okay?
Comment 13 Heiko Tietze 2019-04-12 06:03:21 UTC
(In reply to mgalbavy from comment #12)
> Hi, I'm interested in working on this bug. Is that okay?

Please do it. You can always assign yourself.
Comment 14 V Stuart Foote 2019-04-12 16:36:50 UTC
Whoa, hang on Heiko!

mgalbavy@nd.edu, thanks for willingness to take this on. 

But not clear it is the easyhack described. Code pointers are missing, and there was the initial idea to tweak directly in the VCL configuration.

See https://gerrit.libreoffice.org/#/c/22124/

where Kendy indicates a Design team decision to implement Crome OS Core fonts in backing out László's work. I don't remember that as a final decision (think Kendy's quashing the patch).

Time frame was around this meeting: 

http://document-foundation-mail-archive.969070.n3.nabble.com/Minutes-of-the-Design-Hangout-2016-02-05-td4175995.html

But we had an active discussion on the dev mail list:

http://document-foundation-mail-archive.969070.n3.nabble.com/New-default-fonts-td4175420.html

Not sure that all made it back to this change to Impress as to which opensource font(s) to adopt--in default templates or in VCL configuration.
Comment 15 mgalbavy 2019-04-12 19:01:17 UTC
vstuart.foote@utsa.edu: I made the code corrections before I saw your note by editing several lines in core/extras/source/templates/presnt/Impress/styles.xml and core/extras/source/templates/presnt/Vivid/styles.xml, which seem to be the default templates.

I read over the meeting notes and active discussion. It seems no consensus was reached about where to edit the fonts. Should my next step be to ask in the active discussion to see if a consensus can be reached, or should I submit my code in the way László did so that the option exists to keep László's changes or adopt my changes once a consensus is reached?
Comment 16 V Stuart Foote 2019-04-12 19:16:42 UTC
(In reply to mgalbavy from comment #15)
> I read over the meeting notes and active discussion. It seems no consensus
> was reached about where to edit the fonts. Should my next step be to ask in
> the active discussion to see if a consensus can be reached, or should I
> submit my code in the way László did so that the option exists to keep
> László's changes or adopt my changes once a consensus is reached?

I think we may need to tweak the VCL.xcu, but main focus should probably be the template styles.xml.

Just do your git checkout, build, test, and post for review as normal. But, post the gerrit link for review here.

Sorry this is not a clean task to jump in on...
Comment 17 mgalbavy 2019-04-15 01:42:53 UTC
(In reply to V Stuart Foote from comment #16)
> Just do your git checkout, build, test, and post for review as normal. But,
> post the gerrit link for review here.

This is my first time contributing code to LibreOffice. Could you please direct me to instructions for my git checkout, build, test, and post for review?
Comment 18 V Stuart Foote 2019-04-15 03:20:21 UTC
(In reply to mgalbavy from comment #17)
> This is my first time contributing code to LibreOffice. Could you please
> direct me to instructions for my git checkout, build, test, and post for
> review?

Pretty straight forward, good notes laid out in Wiki:

https://wiki.documentfoundation.org/Development/gerrit
Comment 19 mgalbavy 2019-04-15 19:28:07 UTC
(In reply to V Stuart Foote from comment #16)
> post the gerrit link for review here.

Here's the gerrit link: https://gerrit.libreoffice.org/#/c/70799/
Comment 20 Laurent BP 2019-04-16 12:27:41 UTC
(In reply to mgalbavy from comment #19)
> (In reply to V Stuart Foote from comment #16)
> > post the gerrit link for review here.
> 
> Here's the gerrit link: https://gerrit.libreoffice.org/#/c/70799/

Your update was not correctly done. You should:
1. Abandon https://gerrit.libreoffice.org/7082/
2. In your code, rebase your commit and merge both of your commits concerning this issue (see https://wiki.documentfoundation.org/Development/Git_For_LibreOffice_Developers#Reorder.2C_squash_and_in_general_tweak_your_local_history:_git_rebase_-i for more details)
   2.1 "git rebase -i HEAD~3"
   2.2 replace "pick" with "fixup" on your second commit
   2.3 ZZ to save and close
   2.4 "git commit --amend" to update message of your commit
3. Push again your modified commit
Comment 21 Xisco Faulí 2019-07-18 11:41:04 UTC
Dear mgalbavy@nd.edu,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.