tested under Win8.1 x64 using LibO 18.104.22.168, 22.214.171.124 and recent 126.96.36.199 daily build.
this issue is quite similar to:
Bug 96590 - UI: save icon does not give a hint of the document status
however while Bug 96590 referred to the new save "split button" and was fixed by the design team with an icon modification, this problem still exist for the old "single action" save button.
in order to enable the "single action" save icon and replace the "split button" save icon (which is now default in 5.1.x) you should tweak the expert configuration:
Tools -> Options -> Advanced "Expert Configuration" session and searching for "SaveToolbarController"
then edit the "controller" string replacing
on LibreOffice restart, restores the non-split button behavior to the Toolbar "Save" button.
this way you can restore the old "single action" button from 5.0.x and previous LibO releases.
the only problem is that unlike older realeases, the "greyed" out effect that involved the icon after clicking the Save icon for a modified existing file is no longer present.
the "greyed out" effect was a useful visual hint to let the user know when a document was modified and needed saving.
actually the "split button" features 2 different icons to let the user know if the document needs saving.
I don't know what technically gave the greyed out effect in 5.0.x (was it a separate icon or just a processing of the normal icon?) but I think a similar thing should be done for the "single action" button as well.
I set status to NEW since this problem has been already confirmed by another user here: https://bugs.documentfoundation.org/show_bug.cgi?id=98730#c32
There is no way of fixing this without affecting the behavior of the menu item too - which will bring inconsistency to the UI in the default setup (i.e the menu item will be disabled sometimes, but the toolbar button always enabled etc.). The trick with GenericPopupToolbarController is a pure hack based on how it's implemented. The only way to bring the old behavior is to actually reimplement it - either via a proper expert-config setting, a checkbox in configuration, or a separate command like proposed in Bug 98745.
thanks for the clear technical explanation.
just curious to know if from a technical point of view it would be possible to implement an extension that brings a save button with different icons according to the modified/unmodified status of the current document.
I have a little experience with macros and I know that a macro can be converted into an extension with a custom toolbar icon.
the only thing I don't know if icons shipped with extension can change their look according to the document state.
(In reply to tommy27 from comment #2)
> just curious to know if from a technical point of view it would be possible
> to implement an extension that brings a save button with different icons
> according to the modified/unmodified status of the current document.
I doubt it will be possible with BASIC macros, but should be doable with anything else (Python, Java, C++ etc.)
thanks for you valuable input
*** Bug 101743 has been marked as a duplicate of this bug. ***