In bug 99994 it was found that there is a problem with resolving the style for an element where there is a CSS * selector rule. This originally manifested in a crash, as the call getFontFamily() would give different results on the first and second call. The patch on that bug fixes the crash, but does not resolve the underlying issue. A full fix would resolve the crash even after reverting https://cgit.freedesktop.org/libreoffice/core/commit/?id=68ccab350ca5b907f185c729e94a14df15fedc23 (While that commit should be reverted for testing it is still useful, as it saves making multiple calls to a function that must traverse the svg style hierarchy). With '*' CSS rules the style resolution can still be wrong, even with out causing a crash (see attached test). I suspect solving this amounts to the same thing.
Created attachment 125463 [details] tdf100198.svg An svg file with a "*" selector and some text elements with fill color set by multiple methods. The colors are not correct for some elements (compared to firefox and inkscape).
Created attachment 125464 [details] tdf100198.svg in impress
Created attachment 125465 [details] tdf100198.svg in firefox
Created attachment 125466 [details] 0001-tdf-100198-unit-test.patch A unit test using tdf100198.svg. This does not currently pass. (git treats the svg file as binary, I am not how to prevent this)
Thanks for opening the followup report. Confirmed with the new test file.
Hi, In order to investigate this issue, I reverted 68ccab350ca5b907f185c729e94a14df15fedc23, and I found that there 2 places where a new SvgStyleAttribute object is created for attachment 125233 [details]: git grep -F "new SvgStyleAttributes(*this)" svgio/ svgio/source/svgreader/svgnode.cxx: mpLocalCssStyle = new SvgStyleAttributes(*this); svgio/source/svgreader/svgstylenode.cxx: SvgStyleAttributes* pNewStyle = new SvgStyleAttributes(*this); one for the element's style attribute like style="stroke:#000000;" and the other for the style node like: <style type="text/css" id="style6"> *{stroke-linecap:butt;stroke-linejoin:round;} </style> Could it be the cause why const SvgStyleAttributes* pSvgStyleAttributes = getParentStyle(); if(pSvgStyleAttributes) { return pSvgStyleAttributes->getFontFamily(); } ends up in an infinite loop where the parent points to its child?
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still incorrectly rendered in: Version: 5.4.2.2 Build ID: 22b09f6418e8c2d508a9eaf86b2399209b0990f4 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk2; Locale: en-GB (en_GB.utf8); Calc: group
still repro in LO 6.1 beta 2
Dear sam tygier, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still incorrectly rendered in: Version: 6.2.2.2 Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d CPU threads: 8; OS: Linux 5.1; UI render: default; VCL: gtk3; Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB
*** Bug 103154 has been marked as a duplicate of this bug. ***
This is another regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=e17a730c0076b10678c860ae3285bc8a98282415 Closing as RESOLVED DUPLICATED of bug 99115 *** This bug has been marked as a duplicate of bug 99115 ***