Bug 101807 - UI: Options Language settings > English sentence checking ... convert options conflict
Summary: UI: Options Language settings > English sentence checking ... convert options...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.1.5.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Options-Dialog-Language
  Show dependency tree / graph
 
Reported: 2016-08-30 22:38 UTC by MM
Modified: 2022-08-17 10:05 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:

Attachments
conflicting options (1.05 MB, image/png)
2016-09-26 20:42 UTC, MM 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description MM 2016-08-30 22:38:32 UTC 
In LO 5.2+, goto: Options > Language settings > english sentence checking > others.
You can now click on 'convert to metric' and 'convert to non-metric' at the same time. I think these conflict with each other. You either have one or the other, but not both.
Comment 1 Buovjaga 2016-09-23 19:01:54 UTC 
Just to be clear, to repro I need http://extensions.libreoffice.org/extension-center/languagetool installed?
Comment 2 MM 2016-09-26 20:39:51 UTC 
(In reply to Buovjaga from comment #1)
> Just to be clear, to repro I need
> http://extensions.libreoffice.org/extension-center/languagetool installed?

No, I don't have any extensions installed.
Some systems might not have the 'english sentence checking' as option in prefs.
LO language (user interface / LO setting) is set as 'Default - English (USA)'.
Comment 3 MM 2016-09-26 20:42:32 UTC 
Created attachment 127649 [details]
conflicting options
Comment 4 Buovjaga 2016-09-27 04:44:37 UTC 
Did you check you don't have Languagetool (or some similar extension) installed? I don't see the option entry even though I have English (USA) as the UI language.
I see no other way of getting the entry except installing such an extension: http://askubuntu.com/questions/525544/libreoffice-english-sentence-checking-option-missing
Comment 5 Aron Budea 2016-09-27 06:20:52 UTC 
I see the option in 5.2.2.2 / Windows 7.

I wonder what's the user-friendly way to have it look. First of all, bring the options next to each other. Is any kind of visual aid needed to show the two settings belong together? (and basically function as a 3-way switch)
Jay, what are your thoughts?
Comment 6 Yousuf Philips (jay) (retired) 2016-09-28 10:40:35 UTC 
I'd say they should likely be radio buttons rather than checkboxes.

@Stuart, @Adolfo, @Cor, @Heiko: What you guys think?
Comment 7 Cor Nouws 2016-09-28 11:03:40 UTC 
(In reply to Yousuf Philips (jay) from comment #6)
> I'd say they should likely be radio buttons rather than checkboxes.


that is what one would expect. Looking in the Help, I see no explanation.
Comment 8 Heiko Tietze 2016-09-28 11:38:03 UTC 
(In reply to Yousuf Philips (jay) from comment #6)
> I'd say they should likely be radio buttons rather than checkboxes.

Metric is mutually exclusive to _imperial_ units, no question. But I still do not know how to get these aids.
Comment 9 MM 2016-09-28 15:39:30 UTC 
(In reply to Yousuf Philips (jay) from comment #6)
> I'd say they should likely be radio buttons rather than checkboxes.
> 

Yes, a radio button with none/metric/non-metric will do fine.
Comment 10 V Stuart Foote 2016-09-28 15:50:14 UTC 
Before we get to excited about this, can anyone point to where in source the Lightproof grammar checker performs the filtering?

Couldn't find it yet, but suspect the two filter sets are not exclusive--so should not (can not?) be linked action via radio button. And check boxes must remain.
Comment 11 Aron Budea 2016-09-28 23:58:03 UTC 
Well, it's true that you could mix metric and non-metric units in a text, and then have the checker suggest conversion for both kind of units.
Comment 12 MM 2016-10-01 17:17:22 UTC 
(In reply to Aron Budea from comment #11)
> Well, it's true that you could mix metric and non-metric units in a text,
> and then have the checker suggest conversion for both kind of units.

An added option for 'both' then ?
Comment 13 V Stuart Foote 2016-10-01 18:21:26 UTC 
(In reply to MM from comment #12)
> (In reply to Aron Budea from comment #11)
> > Well, it's true that you could mix metric and non-metric units in a text,
> > and then have the checker suggest conversion for both kind of units.
> 
> An added option for 'both' then ?

Or just leave things as they are with check-boxes. But move the two entries adjacent rather than split by the "Thousand separation of large numbers" entry.
Comment 14 QA Administrators 2018-09-04 02:54:19 UTC Comment hidden (obsolete)
Comment 15 Cor Nouws 2018-09-07 15:30:34 UTC 
still in 6.2-master
Comment 16 Cor Nouws 2018-09-07 15:31:22 UTC 
(In reply to V Stuart Foote from comment #13)

> Or just leave things as they are with check-boxes. But move the two entries
> adjacent rather than split by the "Thousand separation of large numbers"
> entry.

As it doesn't seem to hurt either..
@mm: what is your idea now?
Comment 17 QA Administrators 2019-09-08 05:03:03 UTC Comment hidden (obsolete)
Comment 18 QA Administrators 2021-09-08 03:41:42 UTC Comment hidden (obsolete)
Comment 19 sdc.blanco 2022-08-17 09:35:41 UTC 
Behavior still present in:

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 450471ebbdbff40998509731028b28e0ada53f58
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL

But in light of discussion here -- maybe this is NAB?
Comment 20 sdc.blanco 2022-08-17 10:05:31 UTC 
If a documentation issue, then see bug 143754