Bug 102255 - UNO: Transpose Paste
Summary: UNO: Transpose Paste
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Roland Kurmann
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: UNO-Command-New Paste
  Show dependency treegraph
 
Reported: 2016-09-18 15:26 UTC by Yousuf Philips (jay) (retired)
Modified: 2021-05-21 07:48 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-09-18 15:26:28 UTC
Similar to the request for a paste link command in bug 90101, an uno command to transpose paste is required, which will be added to the menu and the context menu.
Comment 1 Roland Kurmann 2021-04-12 06:09:04 UTC
I want to try this one.
Comment 2 Roland Kurmann 2021-04-24 07:05:26 UTC
I've implemented the .uno:PasteTransposed locally.

I've 2 UX related questions:

1. How should the new transpose command be integrated into the menus, e.g cell context menu?

My proposition:

Cut
Copy
Paste
Paste Special >
    Unformatted text
    ---
    Text
    Number
    Formula
    ---
    Transpose               <---- new entry
    Paste Special...
---
Insert...
Delete...
and more ...


2. How is the process for creating the icon(s)?
Should I create the initial sc_ and lc_ icons for colibre as described in icon-themes/README.md? Could these icons just be placeholders, e.g. a copy of the lc_pastespecial.png?
I'm a programmer; I've not the good skills.

There is already an existing icon showing the transpose idea, see 
icon-themes/colibre/sc/res/paste_transpose.png. So, this could be the basis for the new menu icons.
Comment 3 Rizal Muttaqin 2021-04-24 07:15:07 UTC
(In reply to Scito from comment #2)

> There is already an existing icon showing the transpose idea, see 
> icon-themes/colibre/sc/res/paste_transpose.png. So, this could be the basis
> for the new menu icons.
Yes, you can make use the icon.

If you don't mind, give me the icon creation task (a separate bug report would be welcome) so you just be relax :D
Comment 4 Roland Kurmann 2021-04-24 08:37:35 UTC
> If you don't mind, give me the icon creation task
> (a separate bug report would be welcome) so you just be relax :D

Great!

I've created bug 141866
Comment 5 Roman Kuznetsov 2021-04-24 09:11:11 UTC
(In reply to Scito from comment #2)
> I've implemented the .uno:PasteTransposed locally.
> 
> I've 2 UX related questions:
> 
> 1. How should the new transpose command be integrated into the menus, e.g
> cell context menu?
> 

May be:

Cut
Copy
Paste
Paste Special >
    Unformatted text
    ---
    Transpose               <---- new entry
    ---
    Text
    Number
    Formula
    ---
    Paste Special...
---
Insert...
Delete...
and more ...
Comment 6 Roland Kurmann 2021-04-25 05:32:13 UTC
Yeah, I think a separate group is better. Especially, I'll plan to implement "As Link" (bug 90101) as well. I can do it in a similar fashion. (I'll submit two separate patches.)

However, I suggest display "As Link, Transposed" group after the "Text, Number and Formula" group as "Text, Number and Formula" seems more important/popular. An indication is that is was implemented before this issue. According to UX principles (https://wiki.documentfoundation.org/Design/Guidelines/ContextMenu) "More important contextual entries groups appear at the top".

Additionally, I suggest to used "Transposed" instead of "Transpose".

I think I'll implement it as this:

Cut
Copy
Paste
Paste Special >
    Unformatted text
    ---
    Text
    Number
    Formula
    ---
    Transposed               <---- new entry
    As Link                  <---- planned with bug 90101
    ---
    Paste Special...
---
Insert...
Delete...
and more ...
Comment 7 Heiko Tietze 2021-04-26 08:29:50 UTC
Position below the more frequently used items is correct and I would keep "Transpose". But I doubt "As Link" is important enough for being in the context menu; hesitate with Transpose too (no hard feeling to add, OTOH).

Wonder if we need shortcuts for the new UNO commands.
Comment 8 Roland Kurmann 2021-04-30 13:58:08 UTC
I've submitted a patch https://gerrit.libreoffice.org/c/core/+/114911

Waiting for review.

> I would keep "Transpose".

OK

> But I doubt "As Link" is important enough for being in the context menu;

OK, I won't add it.

> hesitate with Transpose too (no hard feeling to add, OTOH).

I've added it in my patch. I think it's worth to add transpose.

> Wonder if we need shortcuts for the new UNO commands.

I do not know. However, people you need it could add shortcuts themselves.
Comment 9 Heiko Tietze 2021-05-03 09:39:46 UTC
(In reply to Scito from comment #8)
> I've submitted a patch https://gerrit.libreoffice.org/c/core/+/114911

Works like a charm!
Comment 10 Commit Notification 2021-05-03 09:40:22 UTC
scito committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/02b72784e5601636d26c8e4592958c262efb1a7d

tdf#102255 add .uno:PasteTransposed

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-05-07 07:22:04 UTC
scito committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b450b6ccd9f9bee0bb47500e7bf71f9ba641e36

tdf#102255 improve test and docu of .uno:PasteTransposed

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 BogdanB 2021-05-10 07:14:11 UTC
Great to see this new option here.
Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 1a99b4e44190e182d56a04678850d62635d74c65
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 13 Commit Notification 2021-05-21 07:48:31 UTC
scito committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0ae3cf8d0f9d882011a120bb9955951f838c3534

tdf#102255 tdf#90101 remove trailing space in labels

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.