Bug 103388 - UI: "View > Show Formula" shows the shortcut as "Ctrl+grave"
Summary: UI: "View > Show Formula" shows the shortcut as "Ctrl+grave"
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: NISZ LibreOffice Team
URL:
Whiteboard: target:7.3.0 target:7.2.0.0.beta2
Keywords:
: 117724 (view as bug list)
Depends on:
Blocks: Main-Menu Shortcuts-Grave
  Show dependency treegraph
 
Reported: 2016-10-21 15:03 UTC by brucehohl
Modified: 2021-09-11 19:29 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
View -> Formula on Windows (master 2016-10-23) (23.47 KB, image/png)
2016-10-26 05:56 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description brucehohl 2016-10-21 15:03:14 UTC
View > Show Formula shows the shortcut as "Ctrl+grave".
My keyboard does not have "grave" key :)

Under Tools > Customize > Keyboard tab + Category = View + Function = Show Formula, Keys = Null.  That is, nothing appears defined.
Comment 1 Samuel Mehrbrodt (allotropia) 2016-10-21 17:42:47 UTC
The "^" key is called grave. Not sure why this is used as a shortcut.
Comment 2 V Stuart Foote 2016-10-21 17:55:04 UTC
On Windows builds, the shortcut on the menu entry is just Ctrl, and does toggle the formula <> calculation.

But the expected shortcut <Ctrl>+` toggles the view of the cell. (On en-US 102 keyboard that is combined with the ~ key upper left)

Customize keyboard for Calc or LibreOffice shows no keys assigned to the View -> Show Formula action.

Hmm...

@Jay?

Windows 10 Pro 64-bit (1607) en-US with
Version: 5.3.0.0.alpha0+
Build ID: c2b48a763df113e63e6a27ee05b9a6834e4e49a4
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-10-20_06:56:44
Locale: en-US (en_US); Calc: CL
Comment 3 brucehohl 2016-10-21 18:11:55 UTC
A few comments:
(1) Use of the "grave" key might not be the best choice for this shortcut as this key apparently is referred to by different names.  Reference this discussion: https://askubuntu.com/questions/114578/what-is-the-grave-button. I have in the past heard this key referred to as the back-tick key.

(2) It is inconsistent for the menu to show, in this particular case, the name of the key instead of the key symbol. "grave" instead of "`".

(3) Another apparent inconsistency is that for some reason the use of this shortcut was not defined at Tools > Customize > Keyboard tab.
Comment 4 Yousuf Philips (jay) (retired) 2016-10-21 19:52:21 UTC
@Stuart: The show formula uno command (.uno:ToggleFormula) has been assigned[1] to "QUOTELEFT_MOD1" since the OOo days, but i recently added it to the view menu in master.

I noticed the shortcut a few days ago when i was in the menu and found it was strange as well to say 'grave'. :D

So i'm assuming we should show the character rather than naming it, like we do with command and semi colon.

[1] https://cgit.freedesktop.org/libreoffice/core/tree/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
Comment 5 Joel Madero 2016-10-26 04:08:19 UTC
Is this still an issue? I don't see "grave" in that menu at all.
Comment 6 V Stuart Foote 2016-10-26 05:56:25 UTC
Created attachment 128270 [details]
View -> Formula on Windows (master 2016-10-23)

Wrong to display the word "grave" as a shortcut on some Linux builds--or to show shortcut with only "Ctrl" without the "`" as happening on Windows builds.
Comment 7 QA Administrators 2017-10-27 08:49:09 UTC Comment hidden (obsolete)
Comment 8 V Stuart Foote 2018-01-26 23:47:53 UTC
(In reply to QA Administrators from comment #7)

Handling of the label on the View menu on Windows remains an issue. On Windows builds-the Grave accent, aka "back tic" is not showing in the UI for the menu.

Also, seems the mapping of "QUOTELEFT_MOD1" to the .uno:ToggleFormula action is overriding a preferred OSX window navigation as in bug 114858.

As Bruce suggested comment 3 (1) maybe assigning a different key for the shortcut would be better cross platform?
Comment 9 V Stuart Foote 2018-01-27 00:39:46 UTC
Another facet to this and perhaps why historically the "Ctrl+Grave" text label was used on the menu--we don't include the Grave (QUOTELEFT) in the Tools -> Customize dialog panels for menu, keyboard. Does OS clobber application use of the glyph.

Als, the mapping of .uno:ToggleFormula's "Show Formula" Function to Ctrl+` (QUOTELEFT_MOD1) does not display in the Customize dialog. Why is that? The command can be assigned to other keyboard shortcut(s) from Customize--but its default using (QUOTELEFT) does not show.
Comment 10 Yousuf Philips (jay) (retired) 2018-01-28 15:47:08 UTC
Lets limit this bug to fixing the issue on linux, the display of 'grave' rather than '`', and use bug 115281 to fix the issue on windows and mac of the shortcut not appearing correctly.
Comment 11 David 2018-03-18 10:48:58 UTC
This has now been raised an AskLibreOffice[1], and I have posted a work-around there.

It doesn't even show up in the `Tools > Customise... > Keyboard` settings, as noted in comment #9, which is a bit disconcerting! 

[1]: https://ask.libreoffice.org/en/question/149646/lo-6021-cannot-switch-between-documents-on-a-mac/?answer=149674#post-id-149674
Comment 12 V Stuart Foote 2018-03-18 13:35:16 UTC
(In reply to David from comment #11)
> This has now been raised an AskLibreOffice[1], and I have posted a
> work-around there.
> 
> It doesn't even show up in the `Tools > Customise... > Keyboard` settings,
> as noted in comment #9, which is a bit disconcerting! 
> 
> [1]:
> https://ask.libreoffice.org/en/question/149646/lo-6021-cannot-switch-between-
> documents-on-a-mac/?answer=149674#post-id-149674

Actually, for bug 114858 the QUOTELEFT_MOD1 uno:ToggleFormula has already been corrected for macOS builds to use QUOTELEFT_MOD3 so it will behave for macOS users. 

Issue here remains why the \` grave is not handled correctly in the LO GUI; either not showing or showing as the work "Grave"
Comment 13 Jean-Baptiste Faure 2018-05-21 16:42:49 UTC
*** Bug 117724 has been marked as a duplicate of this bug. ***
Comment 14 QA Administrators 2019-05-22 02:53:25 UTC Comment hidden (obsolete)
Comment 15 Vas 2019-05-23 08:52:20 UTC
The key sequence "Ctrl+`" (back tick) works to show the formula, but I'm still not seeing the shortcut key against this command, all I see is "Ctrl " in View > Show formula.

Windows, LO Version: v6.2.2.2
Comment 16 Jean-Baptiste Faure 2019-06-08 09:22:55 UTC
In LO 6.3.0 beta1 under Ubuntu 18.04 / Gnome I see the shortcut Ctrl+` in the menu.

Version: 6.3.0.0.beta1+
Build ID: c744dac16ad808c73021cb2cecefe1d484934451
Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Ubuntu_18.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); UI-Language: fr-FR
Calc: threaded

Best regards. JBF
Comment 17 V Stuart Foote 2019-06-08 13:46:23 UTC
(In reply to Jean-Baptiste Faure from comment #16)
> In LO 6.3.0 beta1 under Ubuntu 18.04 / Gnome I see the shortcut Ctrl+` in
> the menu.
> 
> Version: 6.3.0.0.beta1+
> Build ID: c744dac16ad808c73021cb2cecefe1d484934451
> Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
> Ubuntu_18.04_x86-64
> Locale : fr-FR (fr_FR.UTF-8); UI-Language: fr-FR
> Calc: threaded
> 
> Best regards. JBF

So, guess the Ctrl with text "grave" showing as shortcut is fixed for that DE. 
And, do the Customize dialogs register the "`" grave on that build?

Not the case for either on Windows which in current master [1] still shows just the Ctrl as the assigned shortcut for QUOTELEFT_MOD1 -- but I think we agreed that would be bug 115281
 

=-ref-=
[1] Version: 6.4.0.0.alpha0+ (x86)
Build ID: 9870ff897f088563426bee9567dd9cb722c2b929
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 18 Commit Notification 2021-06-16 12:42:03 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f9fcf0e7f154e49bbffeaea925edb6055add494

tdf#103388 Show the backtick used in shortcut in Calc View menu

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2021-06-17 10:53:22 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/80e813fc9c2134fffbaec37246bff506d14d9cc8

tdf#103388 Show the backtick used in shortcut in Calc View menu

It will be available in 7.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Mehmet gelisin 2021-09-11 13:04:06 UTC Comment hidden (spam)