Bug 103455 - Draw: Edit with external tool only reload first image
Summary: Draw: Edit with external tool only reload first image
Status: CLOSED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
5.1.5.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Draw-Images
  Show dependency treegraph
 
Reported: 2016-10-24 09:24 UTC by DjZU
Modified: 2024-01-29 23:11 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
PDF for testing (745.49 KB, application/pdf)
2016-11-15 12:15 UTC, Buovjaga
Details
Screenshot after editing (105.94 KB, image/png)
2018-06-26 17:58 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description DjZU 2016-10-24 09:24:48 UTC
Description:
When using Edit with external tool, only the first .tmp.jpg file will be successfully reloaded.

Steps to Reproduce:
1. Open a PDF document (4 pages from scanner thus full page images)
2. On the first page, right click on the image and Edit with external tool
3. Make the modifications and save the .tmp file
4. LibreOffice succesfully reload the modified .tmp.jpg file

5. On the second page and so on, right click on the image and Edit with external tool
6. Make the modifications and save the .tmp file

7. LibreOffice won't reload the modified .tmp.jpg file
8. Workaround: Right click on the image and Replace with and manually find the .tmp.jpg file

Actual Results:  
Only first image that has been edited with external tool is reloaded

Expected Results:
All images that have been edited with external tool must be reloaded


Reproducible: Always

User Profile Reset: Yes, and it did not solve the problem

Additional Info:
Running LibreOffice 5.1.5.2 under Windows 10 x64

Version: 5.1.5.2
Build ID: 7a864d8825610a8c07cfc3bc01dd4fce6a9447e5
Threads CPU : 4; Version de l'OS :Windows 6.2; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL

See related bug: https://bugs.documentfoundation.org//show_bug.cgi?id=91891


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Comment 1 Buovjaga 2016-11-15 12:15:54 UTC
Created attachment 128759 [details]
PDF for testing

Reproduced.
External tool was Gwenview, I flipped the images and saved. Only first one worked.

Arch Linux 64-bit, KDE Plasma 5
Version: 5.3.0.0.alpha1+
Build ID: 553cfda502a1516673233e409f91372766da6c4d
CPU Threads: 8; OS Version: Linux 4.8; UI Render: default; VCL: kde4; Layout Engine: new; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on November 11th 2016
Comment 2 Buovjaga 2016-11-15 12:17:10 UTC
This might be a dupe of bug 91891, but only if the behavior changed: in bug 91891, not even the first change worked. I'll ask Philippe.
Comment 3 John Maier 2017-03-09 17:00:30 UTC
I have experienced the same issue in Draw:
Version: 5.3.0.3 (x64)
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1

My Environment is:
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; Layout Engine: new; 
Locale: en-US (en_US); Calc: group

The default editor for bmp is mspaint.

If just close the file, not the entire Draw Program. I can reopen the file and then 'Edit with external tool' will work again, but only for one image.

---------

As a double blind test, I tried the same file under LibreOffice Draw on Linux, and discovered the same issue with being unable to edit a subsequent image.
Version: 5.1.6.2
Build ID: 1:5.1.6~rc2-0ubuntu1~xenial1
CPU Threads: 4; OS Version: Linux 4.4; UI Render: default; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 4 Robert de Rooy 2018-01-23 09:31:26 UTC
Same issue with libreoffice-draw-5.4.4.2-2.fc27.x86_64
using the gimp as external editor. Only the first image can be edited using an external tool.
Comment 5 Aron Budea 2018-06-26 17:58:52 UTC
Created attachment 143145 [details]
Screenshot after editing

My experience is somewhat different, when I open in external tool (GIMP), make some edits, and choose overwrite the image, it disappears from Draw, as can be seen in the attached screenshot.

Observed using LO 6.1 beta2 & 5.0.0.5 (so not a newly introduced change) / Ubuntu 17.10. I wonder if there's something in the OS this could depend on...
Comment 6 Justin L 2018-08-24 11:50:03 UTC
(In reply to Aron Budea from comment #5)
> My experience is somewhat different, when I open in external tool (GIMP),
> make some edits, and choose overwrite the image, it disappears from Draw
This matches my experience (using pinta), but I also noticed that the file size changed. If I copied overtop of the /tmp/ image with an identically sized picture, then the image was "restored" in Draw.

But it isn't as simple as that. The tool that opens up for me is Gnome Image Manager, and from there I am launching Shotwell/Pinta etc.  If I *also* save in Gnome Image Manager (after first saving in Pinta where the image disappears), then the edited image appears, even though the size has changed.

Using that workflow (edit with Gnome viewer -> edit with Pinta -> save again with Gnome viewer) I can edit multiple images, so I cannot confirm the original bug using Ubuntu 18.04 and LO 6.0.6
Comment 7 Aron Budea 2018-08-24 12:03:50 UTC
(In reply to Justin L from comment #6)
> But it isn't as simple as that. The tool that opens up for me is Gnome Image
> Manager, and from there I am launching Shotwell/Pinta etc.  If I *also* save
> in Gnome Image Manager (after first saving in Pinta where the image
> disappears), then the edited image appears, even though the size has changed.
The external editor can be set in Ubuntu via Settings -> Details -> Default Applications; Photos. I switched to GIMP there.
Comment 8 Justin L 2018-08-24 12:15:56 UTC
(In reply to Aron Budea from comment #7)
> The external editor can be set in Ubuntu via Settings -> Details -> Default
> Applications; Photos. I switched to GIMP there.
Yup - I just tried that, and Gimp / Pinta / Shotwell all produced broken images, even when set as the default app.  However, if afterward I separately used Gnome Image Viewer to round-trip the /tmp/*.png file, then it re-appeared in Draw.

I also note that the images that are "broken" while being edited can be used without problem to "replace" an image. So Libreoffice can handle the image itself, but some difference between the old and new is not being accepted.
Comment 9 Justin L 2018-08-24 13:15:15 UTC
I WAS able to replicate the original problem of only acknowledging the first external edit using bibisect-linux-6.0 and saw it fixed by author Jan-Marek Glogowski 2017-07-13 12:10:23 +0200
commit 917be98e3f277960635ac66bcea510c2454c80d6
> Round-robin invoked tasks
> Add some round-robin to the task processing, so equal priority
> (auto) tasks won't always be scheduled, if there are multiple
> tasks with the same priority.
which isn't directly related, but definitely could have implications, so it seems plausible and bibisect was pretty clear about this.

created bug 119479 to cover the topic raised by comment 5
Comment 10 Linda Staten 2024-01-29 16:28:46 UTC
Your doorway to a world of unique stickers, frames, fonts, eye-catching collages, and potent editing tools is the PicsArt Gold Membership. You also enjoy an editing experience free of advertisements. PicsArt Gold (https://www.picsartgeeks.com/picsart-gold-apk-8jlx/) is your access to expressing yourself in novel and appealing ways, regardless of your level of experience as a designer or your love for creating.