In Calc document press F11 Sidebar Deck is open,click to expand Styles everything is as expected. Close Sidebar Deck , go to Print Preview, close and press F11: nothing happened.Open Sidebar Deck clicking on button Sidebar Settings, choose Properties, then click Styles - result LO crashes.Try in Writer too.
OS: Windows 7 LO 5.2.3, LO 5.2.4, 5.3.0
I can't reproduce it in Version: 5.4.0.0.alpha0+ Build ID: 53edf60c4ce6ed32f87471e018878c40b788005a CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2016-12-18_06:57:59 Locale: es-ES (es_ES); Calc: group Do you have any specific file opened when the crash happens? Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongsidethe standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
There are 2 issues here: 1. when View-Sidebar is on (regardless if previously expanded or shown as deck), after Print Preview is shown and closed (menu or toolbar), Styles and Formatting doesn't react (via F11 or menu View-Styles and Formatting) unless mouse is used or View-Sidebar clicked - reproduced with 5.4+ 2. crash that I was not able to reproduce so far
(In reply to Xisco Faulí from comment #2) > I can't reproduce it in > > Version: 5.4.0.0.alpha0+ > Build ID: 53edf60c4ce6ed32f87471e018878c40b788005a > CPU Threads: 1; OS Version: Windows 6.1; UI Render: default; > TinderBox: Win-x86@42, Branch:master, Time: 2016-12-18_06:57:59 > Locale: es-ES (es_ES); Calc: group > > Do you have any specific file opened when the crash happens? > > Could you please try to reproduce it with a master build from > http://dev-builds.libreoffice.org/daily/master/ ? > You can install it alongsidethe standard version. > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the bug is still present in the master build With master build crash is not reproducible any more, in earlier versions crash report http://crashreport.libreoffice.org/stats/crash_details/5f27ecd8-805a-4e20-8f0a-03016a805f7b Key F11 - Styles and Formatting doesn't react after Print Preview - this problem still exist.
In 5.1 we get crash immediately (with View-Sidebar is on) when Print Preview shown and closed is followed with F11. In 5.1.5 it was changed, no crash, but F11 doesn't change Styles and Formatting. That's what bug is about. As written in Comment 3, this is reproduced up to master. I checked https://wiki.documentfoundation.org/Releases/5.1.5/RC1 but I couldn't identify the bug. Caolan worked on some sidebar issues there so I cc him. I also reproduced the crash when previous is followed with a click on Sidebar Settings, Properties, Styles with 5.2, but as written in Comment 4 it's not reproducible with 5.3 beta 2 or master anymore.
Reverse bibisect log for the crash using repo bibisect-win32-5.3. 78aa55cc8eab2be8ca1a4c23d658b38affd45f2f is the first bad commit commit 78aa55cc8eab2be8ca1a4c23d658b38affd45f2f Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Fri Dec 9 13:34:18 2016 -0800 source 5768416761756a386cba54314f783cb9c0d0d093 # bad: [166286094e583fb471c9500fdbddee4e83ef478c] source 70b3dd697cb248fb56830db691269fe9e78c57fb # good: [479ca41474b9720803421ab7717aa69fa6c60528] source f8c463b393885b660500bf4f7f73b4fb90ce2389 git bisect start '166286094e583fb471c9500fdbddee4e83ef478c' '479ca41474b9720803421ab7717aa69fa6c60528' # bad: [af99ef748ba2c46c574a6668439f27e2b3b74158] source 83675eeb30c92a17dd272894df34b89628de0142 git bisect bad af99ef748ba2c46c574a6668439f27e2b3b74158 # bad: [626369369677df78749af63bbd005a8e1f25b615] source 6238f71ddbdc766e733b1c808a4fa7d66f7bde87 git bisect bad 626369369677df78749af63bbd005a8e1f25b615 # good: [14ccfca54c2c9f6f02204b0381d7409ade16ad8f] source 7f47d68c4310b8bae09286a81036a6fa669a1705 git bisect good 14ccfca54c2c9f6f02204b0381d7409ade16ad8f # bad: [8e27d55c66beffb3377925bac1d4eb2ca3058e16] source 1093721a260d25f986fd794acd914b8fb7bcf92a git bisect bad 8e27d55c66beffb3377925bac1d4eb2ca3058e16 # bad: [949bab15e5a2d57ef8b5b58762f1e2783dcf1bf0] source b832d7019f7e7499f5fb3da5d5f49ddbf0f35585 git bisect bad 949bab15e5a2d57ef8b5b58762f1e2783dcf1bf0 # good: [2644da24d79bd49ca52f94d8799d66da01b593cc] source 987984ea21f1688eddfc124292f5e4b931d7d138 git bisect good 2644da24d79bd49ca52f94d8799d66da01b593cc # bad: [4f84486bebe27e5010d877b6e8b1ffede23cf2ef] source 56261b0bb06e29b71e2cc555086100282e54d62e git bisect bad 4f84486bebe27e5010d877b6e8b1ffede23cf2ef # bad: [78aa55cc8eab2be8ca1a4c23d658b38affd45f2f] source 5768416761756a386cba54314f783cb9c0d0d093 git bisect bad 78aa55cc8eab2be8ca1a4c23d658b38affd45f2f # first bad commit: [78aa55cc8eab2be8ca1a4c23d658b38affd45f2f] source 5768416761756a386cba54314f783cb9c0d0d093
The crash is resolved by the following commit: https://cgit.freedesktop.org/libreoffice/core/commit/?id=5768416761756a386cba54314f783cb9c0d0d093 author Caolán McNamara <caolanm@redhat.com> 2016-12-09 11:09:21 (GMT) committer Caolán McNamara <caolanm@redhat.com> 2016-12-09 11:14:53 (GMT) "Related: rhbz#1397939 crash with null pSidebarController" Commit has been cherry-picked into 5.2 branch: https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-5-2&id=3e60ccb74ac6589e14a479c6646c63a4e5ac4e35 It's not in 5.2.4 branch, though (branch-off: 2016-11-29). => crash should be gone in 5.2.5.
when we go to print preview mode we change the controller of the frame and on return we change it again, but the sidebar foo remains listening to the original controller. Currently it doesn't even have way to know this happened because framework/source/services/ContextChangeEventMultiplexer.cxx::disposing won't tell it that the original controller is gone, see "Should we notify the remaining listeners"
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=3e27ba70ce212642026874ba73021930a06cdbbd Resolves: tdf#104884 print preview replaces the frame controller It will be available in 5.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fixed in master now, backport for 5-3 and 5-2 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe85d526323ef562504289c2a0d76a1af94e7a82&h=libreoffice-5-2 Resolves: tdf#104884 print preview replaces the frame controller It will be available in 5.2.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9f031721d7b281ef11c93da78d68f7899816094c&h=libreoffice-5-3 Resolves: tdf#104884 print preview replaces the frame controller It will be available in 5.3.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It's all resolved now,no more crashes and F11 active after PP. Thank You. Version: 5.4.0.0.alpha0+ Build ID: a296a69c984b17cfbcd249cf6bdc191d08dff2a6 CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-02-06_00:00:55 Locale: bs-BA (bs_BA); Calc: group