Bug 105192 - FILEOPEN: DOCX: Header is gone and left section is in all pages (continuous break combined with w:br)
Summary: FILEOPEN: DOCX: Header is gone and left section is in all pages (continuous b...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.0.alpha1+
Hardware: All All
: low normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX
  Show dependency treegraph
 
Reported: 2017-01-08 17:32 UTC by Xisco Faulí
Modified: 2018-12-29 16:30 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2017-01-08 17:32:39 UTC
Steps:
1. Open attachment 102915 [details] from bug 81426

Observed behaviour: Header is gone  and left section 'Request for Proposal' is in all pages.


Reproduced in:

Version: 5.4.0.0.alpha0+
Build ID: 7a1add76d542e9929c1feab9e06949990e236616
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2017-01-08 17:33:48 UTC
Regression introduced by:

author	Justin Luth <justin_luth@sil.org>	2016-06-25 19:21:08 (GMT)
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2016-06-29 07:35:54 (GMT)
commit	50bf96d31ab2eb546f6c71cc93c1fa5dd4bf3044 (patch)
tree	6fa465f41eb719352e2c9d730cd452fd5bf41d17
parent	1294013bf5d373ded1d050370569acdc2b68c5f5 (diff)
tdf#90697 docx - don't change continuous break into page break
As soon as you set PROP_PAGE_DESC_NAME, you are inserting that
style as a page break.  Setting a pagebreak via a continous break
was first introduced in commit 50cb1667020494906afaacb68d4163d1eda527cf
but the unittest for that commit no longer uses this code.
I'm suggesting it be reverted.  It really messes up round-tripping
when continuous breaks are removed/replaced with hard page breaks.

There are a few odd cases where the very first section needs to set the
page break via the continuous break, so it hasn't been eliminated
completely.

Adding Cc: to Justin Luth
Comment 2 Justin L 2017-01-10 06:54:55 UTC
385.docx is a demonstration of a document that will be very difficult for LO to emulate.  Before the "regression" the cover page took up 3 pages. Now it properly takes only one page.

This displays the typical problem with continuous section breaks (which LO cannot fully emulate) where headers are set at "random" places and not associated with any page break.  In this case, the header used on page2 is from section 4 (probably first defined in section2).

In this particular document, the continuous break is followed by a page-break. In that specific case, the import ought to be able to convert this into a section-page-break and thus solve at least one part of the header problem.  (I looked into doing this once, and had difficulties.)

I will not be treating this one as a regression (reducing severity to low - perhaps it should instead be changed to enhancement).
Comment 3 QA Administrators 2018-04-06 02:40:59 UTC Comment hidden (obsolete)
Comment 4 Xavier Van Wijmeersch 2018-12-10 18:26:52 UTC
Can reproduce with

Version: 6.3.0.0.alpha0+
Build ID: b15b1a2a90fa4c239ff8a6a33e73ff50ea422abf
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-11-28_06:21:05
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded